symfony/.git
2 years agoMerge branch '3.4' into 4.0 4.0
Nicolas Grekas [Mon, 9 Jul 2018 13:26:23 +0000 (15:26 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [Filesystem] fix lock file mode
  [Console] fix typo in phpdoc

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Mon, 9 Jul 2018 13:24:55 +0000 (15:24 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [Filesystem] fix lock file mode
  [Console] fix typo in phpdoc

2 years ago[Filesystem] fix lock file mode
Nicolas Grekas [Mon, 9 Jul 2018 13:24:25 +0000 (15:24 +0200)]
[Filesystem] fix lock file mode

2 years agominor #27777 [Console] fix typo in phpdoc (Tobion)
Nicolas Grekas [Mon, 9 Jul 2018 12:59:54 +0000 (14:59 +0200)]
minor #27777 [Console] fix typo in phpdoc (Tobion)

This PR was merged into the 2.8 branch.

Discussion
----------

[Console] fix typo in phpdoc

| Q             | A
| ------------- | ---
| Branch?       | 4.1 (#26847)
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7aa45579d5 [Console] fix typo in phpdoc

2 years ago[Console] fix typo in phpdoc
Tobias Schultze [Fri, 29 Jun 2018 14:44:31 +0000 (16:44 +0200)]
[Console] fix typo in phpdoc

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Mon, 9 Jul 2018 12:50:05 +0000 (14:50 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [Filesystem] fix lock file permissions
  [Lock] fix lock file permissions
  [Form] Removed .form-control-label class.
  Removed .mb-0 in errors.
  Fix the detection of the Process new argument
  add @xabbuh as a code owner of the Yaml component
  Replace .initialism with .text-uppercase.

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Mon, 9 Jul 2018 12:47:47 +0000 (14:47 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [Filesystem] fix lock file permissions
  add @xabbuh as a code owner of the Yaml component

2 years agobug #27904 [Filesystem] fix lock file permissions (fritzmg)
Nicolas Grekas [Mon, 9 Jul 2018 12:47:26 +0000 (14:47 +0200)]
bug #27904 [Filesystem] fix lock file permissions (fritzmg)

This PR was squashed before being merged into the 2.8 branch (closes #27904).

Discussion
----------

[Filesystem] fix lock file permissions

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | see linked discussion
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony/pull/27903

Commits
-------

7a68fea2af [Filesystem] fix lock file permissions

2 years ago[Filesystem] fix lock file permissions
fritzmg [Mon, 9 Jul 2018 09:21:24 +0000 (11:21 +0200)]
[Filesystem] fix lock file permissions

2 years agobug #27903 [Lock] fix lock file permissions (fritzmg)
Nicolas Grekas [Mon, 9 Jul 2018 12:45:49 +0000 (14:45 +0200)]
bug #27903 [Lock] fix lock file permissions (fritzmg)

This PR was squashed before being merged into the 3.4 branch (closes #27903).

Discussion
----------

[Lock] fix lock file permissions

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | see discussion below
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See [this comment](https://github.com/symfony/symfony/pull/27668#issuecomment-403392924). Since we are using `r+` now to fix an issue on Solaris, we also need to change the file permissions when the lock file is created for the first time. Otherwise
```php
fopen($fileName, 'r+')
```
will fail due to the file permissions and while
```php
fopen($fileName, 'r')
```
will work, the subsequent locking will again fail on Solaris.

Changing the file permissions to `0666` fixes this issue. __However__ any lock file that was generated _prior_ to this change will still cause issues and would need to be manually deleted. Usually the default `sys_get_temp_dir()` location is used for the lock files and _usually_ these files are purged periodically, so it probably won't matter that much. But it still might cause some confusion since it will not be transparent, why the file lock failed on Solaris systems.

Commits
-------

23481a112e [Lock] fix lock file permissions

2 years ago[Lock] fix lock file permissions
fritzmg [Mon, 9 Jul 2018 09:10:55 +0000 (11:10 +0200)]
[Lock] fix lock file permissions

2 years agominor #27886 [Form] Removed .form-control-label class. (vudaltsov)
Nicolas Grekas [Mon, 9 Jul 2018 12:42:10 +0000 (14:42 +0200)]
minor #27886 [Form] Removed .form-control-label class. (vudaltsov)

This PR was squashed before being merged into the 3.4 branch (closes #27886).

Discussion
----------

[Form] Removed .form-control-label class.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

There is no such a class neither in [bootstrap 4.0](https://getbootstrap.com/docs/4.0/components/forms/#form-controls) nor in [bootstrap 4.1](https://getbootstrap.com/docs/4.1/components/forms/#form-controls).

Commits
-------

cb3e712698 [Form] Removed .form-control-label class.

2 years ago[Form] Removed .form-control-label class.
Valentin [Sat, 7 Jul 2018 12:17:51 +0000 (15:17 +0300)]
[Form] Removed .form-control-label class.

2 years agominor #27887 [Form] Removed .mb-0 in errors. (vudaltsov)
Nicolas Grekas [Mon, 9 Jul 2018 12:39:50 +0000 (14:39 +0200)]
minor #27887 [Form] Removed .mb-0 in errors. (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Removed .mb-0 in errors.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

`<span class="d-block">` will never have a margin on its own, so `.mb-0` is needless.

Commits
-------

925dda130e Removed .mb-0 in errors.

2 years agoRemoved .mb-0 in errors.
Valentin [Mon, 9 Jul 2018 10:08:44 +0000 (13:08 +0300)]
Removed .mb-0 in errors.

2 years agobug #27889 [Form] Replace .initialism with .text-uppercase. (vudaltsov)
Nicolas Grekas [Mon, 9 Jul 2018 12:34:25 +0000 (14:34 +0200)]
bug #27889 [Form] Replace .initialism with .text-uppercase. (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Replace .initialism with .text-uppercase.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I think that the `.initialism` [class](https://getbootstrap.com/docs/4.0/content/typography/#abbreviations) is for different purposes. While the `.text-uppercase` [class](https://getbootstrap.com/docs/4.0/utilities/text/#text-transform) is more neutral and does exactly what we want here.

Commits
-------

3c39dfdaa6 Replace .initialism with .text-uppercase.

2 years agobug #27902 Fix the detection of the Process new argument (stof)
Nicolas Grekas [Mon, 9 Jul 2018 12:30:57 +0000 (14:30 +0200)]
bug #27902 Fix the detection of the Process new argument (stof)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix the detection of the Process new argument

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This fixes the detection of the new method signature when triggering the deprecation warning. The new `$env` parameter is the second argument, not the first one.

Commits
-------

57e95f3f9a Fix the detection of the Process new argument

2 years agominor #27899 add @xabbuh as a code owner of the Yaml component (xabbuh)
Christian Flothmann [Mon, 9 Jul 2018 09:07:51 +0000 (11:07 +0200)]
minor #27899 add @xabbuh as a code owner of the Yaml component (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

add @xabbuh as a code owner of the Yaml component

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

748cad4 add @xabbuh as a code owner of the Yaml component

2 years agoMerge branch '3.4' into 4.0
Christian Flothmann [Mon, 9 Jul 2018 09:06:09 +0000 (11:06 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  improve deprecation messages

2 years agoFix the detection of the Process new argument
Christophe Coevoet [Mon, 9 Jul 2018 09:01:07 +0000 (11:01 +0200)]
Fix the detection of the Process new argument

2 years agominor #27868 improve deprecation messages (xabbuh)
Christian Flothmann [Mon, 9 Jul 2018 08:21:26 +0000 (10:21 +0200)]
minor #27868 improve deprecation messages (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

improve deprecation messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

a3845c7 improve deprecation messages

2 years agoadd @xabbuh as a code owner of the Yaml component
Christian Flothmann [Mon, 9 Jul 2018 08:01:26 +0000 (10:01 +0200)]
add @xabbuh as a code owner of the Yaml component

2 years agoimprove deprecation messages
Christian Flothmann [Fri, 6 Jul 2018 08:46:11 +0000 (10:46 +0200)]
improve deprecation messages

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Sat, 7 Jul 2018 16:00:24 +0000 (18:00 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [Console] fix CS
  [OptionResolver] resolve arrays
  [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output
  [PropertyInfo] Fix dock block lookup fallback loop
  [HttpFoundation] don't encode cookie name for BC
  improve deprecation messages
  minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)
  AppBundle->App.
  [DI] Fix dumping ignore-on-uninitialized references to synthetic services

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Sat, 7 Jul 2018 15:54:55 +0000 (17:54 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [Console] fix CS
  improve deprecation messages
  minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)

2 years ago[Console] fix CS
Nicolas Grekas [Sat, 7 Jul 2018 15:53:36 +0000 (17:53 +0200)]
[Console] fix CS

2 years agobug #27885 [HttpFoundation] don't encode cookie name for BC (nicolas-grekas)
Nicolas Grekas [Sat, 7 Jul 2018 15:50:45 +0000 (17:50 +0200)]
bug #27885 [HttpFoundation] don't encode cookie name for BC (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] don't encode cookie name for BC

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As reported by @Seldaek in https://github.com/symfony/symfony/pull/25348#issuecomment-401696990

Commits
-------

d28949b846 [HttpFoundation] don't encode cookie name for BC

2 years agobug #27782 [DI] Fix dumping ignore-on-uninitialized references to synthetic services...
Nicolas Grekas [Sat, 7 Jul 2018 15:48:58 +0000 (17:48 +0200)]
bug #27782 [DI] Fix dumping ignore-on-uninitialized references to synthetic services (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping ignore-on-uninitialized references to synthetic services

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

97e8d68a05 [DI] Fix dumping ignore-on-uninitialized references to synthetic services

2 years agobug #27435 [OptionResolver] resolve arrays (Doctrs)
Nicolas Grekas [Sat, 7 Jul 2018 15:09:44 +0000 (17:09 +0200)]
bug #27435 [OptionResolver] resolve arrays (Doctrs)

This PR was squashed before being merged into the 3.4 branch (closes #27435).

Discussion
----------

[OptionResolver] resolve arrays

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Option resolver didn't work with nested arrays

Before:

        $resolver->setDefaults([
            'integer' => [
                [
                    12,
                    23,
                ],
            ],
        ]);

        $resolver->setAllowedTypes('integer', 'integer[][]');

Error

    The option "host" with value array is expected to be of type "integer[][]", but is of type "integer[][]".

Option expetcted type `integer[][]` but get... `integer[][]`. So strange

Now that case work correct, and we get

    array (size=1)
      'integer' =>
        array (size=1)
          0 =>
            array (size=2)
              0 => int 12
              1 => int 23

Commits
-------

6d4812e995 [OptionResolver] resolve arrays

2 years ago[OptionResolver] resolve arrays
Oleg Golovakhin [Wed, 30 May 2018 20:05:54 +0000 (23:05 +0300)]
[OptionResolver] resolve arrays

2 years agobug #27728 [TwigBridge] Fix missing path and separators in loader paths list on debug...
Nicolas Grekas [Sat, 7 Jul 2018 15:04:34 +0000 (17:04 +0200)]
bug #27728 [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output (yceruto)

This PR was squashed before being merged into the 3.4 branch (closes #27728).

Discussion
----------

[TwigBridge] Fix missing path and separators in loader paths list on debug:twig output

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**Reproducer**
```bash
$ composer create-project symfony/skeleton repr
$ cd repr
$ composer req twig
# remove duplicated path on `twig.paths: ['%kernel.project_dir%/templates']` config.
$ bin/console debug:twig
```
See "Loader Paths" section at the end of the output and compare it with `--format=json`. Note that the root `templates` path is present in Twig `loader_paths` because `twig.default_path` config, but it isn't visible on `debug:twig` output.

**Missing path:**

| Before | After |
| --- | --- |
| ![debug_twig_before1](https://user-images.githubusercontent.com/2028198/41908937-9af78274-7913-11e8-91d1-bb48f81031dd.png) | ![debug_twig_after1](https://user-images.githubusercontent.com/2028198/41908969-b5fd3140-7913-11e8-8129-8215f3c09b24.png) |

**Extra Lines separator:**

| Before | After |
| --- | --- |
| ![debug_twig_before2](https://user-images.githubusercontent.com/2028198/41909029-e867fcdc-7913-11e8-91f1-bba0d873495c.png) | ![debug_twig_after2](https://user-images.githubusercontent.com/2028198/41915586-12a6426e-7924-11e8-899f-9ecc7d95b74f.png) |

Commits
-------

ba7a4ca863 [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output

2 years ago[TwigBridge] Fix missing path and separators in loader paths list on debug:twig output
Yonel Ceruto [Tue, 26 Jun 2018 11:18:26 +0000 (07:18 -0400)]
[TwigBridge] Fix missing path and separators in loader paths list on debug:twig output

2 years agobug #27837 [PropertyInfo] Fix dock block lookup fallback loop (DerManoMann)
Nicolas Grekas [Sat, 7 Jul 2018 14:54:11 +0000 (16:54 +0200)]
bug #27837 [PropertyInfo] Fix dock block lookup fallback loop (DerManoMann)

This PR was submitted for the 4.1 branch but it was squashed and merged into the 3.4 branch instead (closes #27837).

Discussion
----------

[PropertyInfo] Fix dock block lookup fallback loop

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

`getDocBlock()` in `PhpDocExtractor` implements a fallback loop when trying to lookup a dock block for a property (property, accessor method, mutator method). This relies on the individual lookups to return `null`.

Unfortunately, phpDocumentor will throw an `InvalidArgumentException` exception in case there is no dock block.

Currently the try/catch is wrapping the whole loop which means if the first lookup fails the loop is ended instead of moving on to the next one.

This PR moves the try/catch to each individual call of `$this->docBlockFactory->create()`.

Commits
-------

b1a612087f [PropertyInfo] Fix dock block lookup fallback loop

2 years ago[PropertyInfo] Fix dock block lookup fallback loop
DerManoMann [Wed, 4 Jul 2018 04:15:49 +0000 (16:15 +1200)]
[PropertyInfo] Fix dock block lookup fallback loop

2 years agominor #27866 improve deprecation messages (xabbuh)
Nicolas Grekas [Sat, 7 Jul 2018 14:41:03 +0000 (16:41 +0200)]
minor #27866 improve deprecation messages (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

improve deprecation messages

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

39cb2a99ba improve deprecation messages

2 years agominor #27869 Replaced AppBundle mentions with App (vudaltsov)
Nicolas Grekas [Sat, 7 Jul 2018 14:34:32 +0000 (16:34 +0200)]
minor #27869 Replaced AppBundle mentions with App (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

Replaced AppBundle mentions with App

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Removed some legacy non-test related mentions of AppBundle. Probably this should be done for 4.x only, not >=3.4.

Commits
-------

b4552373c1 AppBundle->App.

2 years agoReplace .initialism with .text-uppercase.
Valentin [Sat, 7 Jul 2018 13:05:57 +0000 (16:05 +0300)]
Replace .initialism with .text-uppercase.

2 years ago[HttpFoundation] don't encode cookie name for BC
Nicolas Grekas [Sat, 7 Jul 2018 09:30:05 +0000 (11:30 +0200)]
[HttpFoundation] don't encode cookie name for BC

2 years agoimprove deprecation messages
Christian Flothmann [Thu, 5 Jul 2018 17:06:52 +0000 (19:06 +0200)]
improve deprecation messages

2 years agominor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)
Robin Chalas [Fri, 6 Jul 2018 09:08:29 +0000 (11:08 +0200)]
minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Console] changed warning verbosity; fixes typo

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes*
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

* Tests pass, but I do not have an installation of MacOS to run tests on.  Tests should be unaffected (the test is simply [skipped on MacOS](https://github.com/symfony/console/blob/master/Tests/Command/CommandTest.php#L345)).

When a Console Command fails to change the process title on MacOS, a warning is issued to output.  This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing.

This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage.
I've also fixed a typo in the message ("get" vs. "set").

Commits
-------

86c771a changed warning verbosity; fixes typo

2 years agoAppBundle->App.
Valentin [Fri, 6 Jul 2018 08:57:10 +0000 (11:57 +0300)]
AppBundle->App.

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Thu, 5 Jul 2018 11:53:42 +0000 (13:53 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [DomCrawler] Fix ChoiceFormField::select() PHPDoc
  [HttpFoundation] add tests for FlashBagInterface::setAll()
  Check for Hyper terminal on all operating systems.
  [DI] Don't show internal service id on binding errors
  Prevent toolbar links color override by css

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Thu, 5 Jul 2018 11:53:23 +0000 (13:53 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [DomCrawler] Fix ChoiceFormField::select() PHPDoc
  [HttpFoundation] add tests for FlashBagInterface::setAll()
  Check for Hyper terminal on all operating systems.
  Prevent toolbar links color override by css

2 years agominor #27849 [DomCrawler] Fix ChoiceFormField::select() PHPDoc (dunglas)
Fabien Potencier [Thu, 5 Jul 2018 07:30:45 +0000 (09:30 +0200)]
minor #27849 [DomCrawler] Fix ChoiceFormField::select() PHPDoc (dunglas)

This PR was merged into the 2.8 branch.

Discussion
----------

[DomCrawler] Fix ChoiceFormField::select() PHPDoc

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

It's allowed by `setValue`, it works, and it makes sense for `<select multiple>` fields.

Commits
-------

154ce9c170 [DomCrawler] Fix ChoiceFormField::select() PHPDoc

2 years agobug #27758 [WebProfilerBundle] Prevent toolbar links color override by css (alcalyn)
Fabien Potencier [Thu, 5 Jul 2018 07:19:04 +0000 (09:19 +0200)]
bug #27758 [WebProfilerBundle] Prevent toolbar links color override by css (alcalyn)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Prevent toolbar links color override by css

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27658
| License       | MIT
| Doc PR        |

Fixes this issue: https://github.com/symfony/symfony/issues/27658#issuecomment-401008659

Links color in toolbar can be easily override by application css. As this could happens sometimes, this PR set links color with a stronger CSS precedence.

Commits
-------

e12e217f2b  Prevent toolbar links color override by css

2 years agobug #27847 [Security] Fix accepting null as $uidKey in LdapUserProvider (louhde)
Robin Chalas [Thu, 5 Jul 2018 05:48:23 +0000 (07:48 +0200)]
bug #27847 [Security] Fix accepting null as $uidKey in LdapUserProvider (louhde)

This PR was merged into the 4.0 branch.

Discussion
----------

[Security] Fix accepting null as $uidKey in LdapUserProvider

| Q             | A
| ------------- | ---
| Branch?       | 4.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixing the hard BC break introduced in https://github.com/symfony/symfony/commit/afeb89fa065be5ebf7f16437551629b028d51f1c#diff-96df7b4cb1c79ec0877d79ae2b61899dL40

Commits
-------

c776259 [Security] LdapUserProvider uidKey could be null

2 years ago[DomCrawler] Fix ChoiceFormField::select() PHPDoc
Kévin Dunglas [Wed, 4 Jul 2018 21:33:50 +0000 (23:33 +0200)]
[DomCrawler] Fix ChoiceFormField::select() PHPDoc

2 years ago[Security] LdapUserProvider uidKey could be null
louhde [Wed, 4 Jul 2018 15:38:36 +0000 (17:38 +0200)]
[Security] LdapUserProvider uidKey could be null

2 years agobug #27834 [DI] Don't show internal service id on binding errors (nicolas-grekas)
Nicolas Grekas [Wed, 4 Jul 2018 15:42:48 +0000 (17:42 +0200)]
bug #27834 [DI] Don't show internal service id on binding errors (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Don't show internal service id on binding errors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Will throw
    Unused binding "$variableName" in service "App\Twig\AppExtension".
instead of the current
    Unused binding "$variableName" in service ".abstract.instanceof.App\Twig\AppExtension".

Commits
-------

61f005af36 [DI] Don't show internal service id on binding errors

2 years agominor #27836 [HttpFoundation] add tests for FlashBagInterface::setAll() (sir-kain)
Nicolas Grekas [Wed, 4 Jul 2018 15:36:33 +0000 (17:36 +0200)]
minor #27836 [HttpFoundation] add tests for FlashBagInterface::setAll() (sir-kain)

This PR was squashed before being merged into the 2.8 branch (closes #27836).

Discussion
----------

[HttpFoundation] add tests for FlashBagInterface::setAll()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Adding documentation for the `FlashBagInterface::setAll()` function

Commits
-------

af96475e2a [HttpFoundation] add tests for FlashBagInterface::setAll()

2 years ago[HttpFoundation] add tests for FlashBagInterface::setAll()
Sir Kane [Tue, 3 Jul 2018 19:59:59 +0000 (19:59 +0000)]
[HttpFoundation] add tests for FlashBagInterface::setAll()

2 years agobug #27831 Check for Hyper terminal on all operating systems. (azjezz)
Nicolas Grekas [Wed, 4 Jul 2018 15:34:59 +0000 (17:34 +0200)]
bug #27831  Check for Hyper terminal on all operating systems.  (azjezz)

This PR was squashed before being merged into the 2.8 branch (closes #27831).

Discussion
----------

 Check for Hyper terminal on all operating systems.

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

return true if the terminal is Hyper.is on all operating systems not limited to windows.

Commits
-------

196e708b68  Check for Hyper terminal on all operating systems.

2 years ago Check for Hyper terminal on all operating systems.
Saif Eddin Gmati [Tue, 3 Jul 2018 15:28:18 +0000 (17:28 +0200)]
 Check for Hyper terminal on all operating systems.

2 years ago[DI] Don't show internal service id on binding errors
Nicolas Grekas [Tue, 3 Jul 2018 19:42:53 +0000 (21:42 +0200)]
[DI] Don't show internal service id on binding errors

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Tue, 3 Jul 2018 17:50:16 +0000 (19:50 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  Add color support for Hyper terminal .
  [HttpFoundation] Fix tests: new message for status 425
  [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid
  [PropertyInfo] added handling of nullable types in PhpDoc
  [HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler
  [Cache] provider does not respect option maxIdLength with versioning enabled

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Tue, 3 Jul 2018 17:49:18 +0000 (19:49 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  Add color support for Hyper terminal .
  [HttpFoundation] Fix tests: new message for status 425
  [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid

2 years agominor #27813 [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber...
Fabien Potencier [Tue, 3 Jul 2018 10:50:43 +0000 (12:50 +0200)]
minor #27813 [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid (stloyd)

This PR was merged into the 2.8 branch.

Discussion
----------

[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27811
| License       | MIT

This change prevents error when invalid subscriber is being used.

Expected result:
```
The Doctrine connection "root" referenced in service "stof_doctrine_extensions.listener.sluggable" does not exist. Available connections names: default
```

Actual error:
```
Notice: Array to string conversion
```

Commits
-------

cf1bc66464 [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid

2 years agobug #27794 Add color support for Hyper terminal . (azjezz)
Fabien Potencier [Tue, 3 Jul 2018 07:19:37 +0000 (09:19 +0200)]
bug #27794 Add color support for Hyper terminal . (azjezz)

This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #27794).

Discussion
----------

Add color support for Hyper terminal .

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Added color support for [Hyper terminal](https://hyper.is), also shade characters support for progress bar.

![image](https://user-images.githubusercontent.com/29315886/42135797-6edb8492-7d50-11e8-968b-2dd19981dcdd.png)

Commits
-------

2ab7bcf797 Add color support for Hyper terminal .

2 years agoAdd color support for Hyper terminal .
AzJezz [Sun, 1 Jul 2018 14:55:08 +0000 (16:55 +0200)]
Add color support for Hyper terminal .

2 years agobug #27809 [HttpFoundation] Fix tests: new message for status 425 (dunglas)
Fabien Potencier [Tue, 3 Jul 2018 07:16:35 +0000 (09:16 +0200)]
bug #27809 [HttpFoundation] Fix tests: new message for status 425 (dunglas)

This PR was squashed before being merged into the 2.8 branch (closes #27809).

Discussion
----------

[HttpFoundation] Fix tests: new message for status 425

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

Makes tests green.
The new meaning of 425 is defined here: https://datatracker.ietf.org/doc/draft-ietf-httpbis-replay/?include_text=1

Commits
-------

8e37d77145 [HttpFoundation] Fix tests: new message for status 425

2 years ago[HttpFoundation] Fix tests: new message for status 425
Kévin Dunglas [Mon, 2 Jul 2018 21:12:41 +0000 (23:12 +0200)]
[HttpFoundation] Fix tests: new message for status 425

2 years ago[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid
Joseph Bielawski [Tue, 3 Jul 2018 06:45:41 +0000 (08:45 +0200)]
[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid

2 years agobug #27618 [PropertyInfo] added handling of nullable types in PhpDoc (oxan)
Fabien Potencier [Mon, 2 Jul 2018 12:52:55 +0000 (14:52 +0200)]
bug #27618 [PropertyInfo] added handling of nullable types in PhpDoc (oxan)

This PR was merged into the 3.4 branch.

Discussion
----------

[PropertyInfo] added handling of nullable types in PhpDoc

While not specified in PSR-5, PhpDocumentor does support parsing nullable types in the PHP 7.1 syntax (i.e. `?string`), and returns those in a `Nullable` wrapper type. We currently don't handle this and neither throw an error, which results in all kind of weird breakage when this syntax is used (e.g. "class string|int not found").

Correctly parse this syntax into a nullable type.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

38b369be3f [PropertyInfo] added handling of nullable types in PhpDoc

2 years ago Prevent toolbar links color override by css
Julien Maulny [Thu, 28 Jun 2018 13:10:19 +0000 (15:10 +0200)]
 Prevent toolbar links color override by css

2 years ago[PropertyInfo] added handling of nullable types in PhpDoc
Oxan van Leeuwen [Sun, 17 Jun 2018 10:05:07 +0000 (12:05 +0200)]
[PropertyInfo] added handling of nullable types in PhpDoc

While not specified in PSR-5, PhpDocumentor does support parsing
nullable types in the PHP 7.1 syntax (i.e. ?string), and returns those
in a Nullable wrapper. We currently don't handle this and neither throw
an error, which results in all kind of weird breakage when this syntax
is used (e.g. "class string|int not found").

Correctly parse this syntax into a nullable type.

2 years agobug #27659 [HttpKernel] Make AbstractTestSessionListener compatible with CookieCleari...
Nicolas Grekas [Sun, 1 Jul 2018 06:51:37 +0000 (08:51 +0200)]
bug #27659 [HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler (thewilkybarkid)

This PR was squashed before being merged into the 3.4 branch (closes #27659).

Discussion
----------

[HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

#26157 started to send a new cookie in `AbstractTestSessionListener`, but is incompatible with `CookieClearingLogoutHandler` as it overrides its `Set-Cookie` by setting a new cookie (breaking my test that checked to see that the cookie was removed after a log out).

Commits
-------

f54d96926a [HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler

2 years ago[HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler
Chris Wilkinson [Wed, 20 Jun 2018 15:02:10 +0000 (16:02 +0100)]
[HttpKernel] Make AbstractTestSessionListener compatible with CookieClearingLogoutHandler

2 years agobug #27752 [Cache] provider does not respect option maxIdLength with versioning enabl...
Nicolas Grekas [Sun, 1 Jul 2018 06:47:52 +0000 (08:47 +0200)]
bug #27752 [Cache] provider does not respect option maxIdLength with versioning enabled (Constantine Shtompel)

This PR was squashed before being merged into the 3.4 branch (closes #27752).

Discussion
----------

[Cache] provider does not respect option maxIdLength with versioning enabled

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27746
| License       | MIT
| Doc PR        |

Component symfony/cache generates cache item ID longer then maxIdLength when versioning is enabled

Commits
-------

ba8b63b195 [Cache] provider does not respect option maxIdLength with versioning enabled

2 years ago[Cache] provider does not respect option maxIdLength with versioning enabled
Constantine Shtompel [Wed, 27 Jun 2018 20:40:07 +0000 (23:40 +0300)]
[Cache] provider does not respect option maxIdLength with versioning enabled

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Sat, 30 Jun 2018 17:31:14 +0000 (19:31 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [Form] Fix fixtures for forward compat
  [Lock] Fix SemaphoreStoreTest on OS X

2 years agominor #27784 [Form] Fix fixtures for forward compat (ogizanagi)
Nicolas Grekas [Sat, 30 Jun 2018 17:30:48 +0000 (19:30 +0200)]
minor #27784 [Form] Fix fixtures for forward compat (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fix fixtures for forward compat

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Completes https://github.com/symfony/symfony/pull/27771 in order to fix https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407. As the Closure signature is variable, we cannot assume the exact number of whitespaces after it, nor if it will or not overtake the length of the `file:` line. So let's just assume an undetermined nb of whitespaces.

Commits
-------

582d797b16 [Form] Fix fixtures for forward compat

2 years ago[Form] Fix fixtures for forward compat
Maxime Steinhausser [Sat, 30 Jun 2018 09:20:07 +0000 (11:20 +0200)]
[Form] Fix fixtures for forward compat

2 years ago[DI] Fix dumping ignore-on-uninitialized references to synthetic services
Nicolas Grekas [Sat, 30 Jun 2018 07:08:55 +0000 (09:08 +0200)]
[DI] Fix dumping ignore-on-uninitialized references to synthetic services

2 years agominor #27779 [Lock] Fix SemaphoreStoreTest on OS X (ogizanagi)
Nicolas Grekas [Fri, 29 Jun 2018 19:23:12 +0000 (21:23 +0200)]
minor #27779 [Lock] Fix SemaphoreStoreTest on OS X (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Lock] Fix SemaphoreStoreTest on OS X

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://github.com/symfony/symfony/pull/27755#pullrequestreview-132772372   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

As spotted in https://github.com/symfony/symfony/pull/27755#pullrequestreview-132772372, for OS X.

If other OS X users could give it a try (`/phpunit src/Symfony/Component/Lock/ --filter=SemaphoreStoreTest`), that would be awesome.

Commits
-------

9055611dc3 [Lock] Fix SemaphoreStoreTest on OS X

2 years ago[Lock] Fix SemaphoreStoreTest on OS X
Maxime Steinhausser [Fri, 29 Jun 2018 16:29:00 +0000 (18:29 +0200)]
[Lock] Fix SemaphoreStoreTest on OS X

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Fri, 29 Jun 2018 16:29:32 +0000 (18:29 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  [ProxyManagerBridge] Fix support of private services (bis)
  bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Form] relax fixtures for forward compat
  [Validator] Fix the namespace of RegexTest
  [Lock] fix locale dependent test case

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Fri, 29 Jun 2018 16:28:23 +0000 (18:28 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Validator] Fix the namespace of RegexTest

2 years agominor #27755 [Lock] fix locale dependent test case (nicolas-grekas)
Nicolas Grekas [Fri, 29 Jun 2018 16:26:23 +0000 (18:26 +0200)]
minor #27755 [Lock] fix locale dependent test case (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Lock] fix locale dependent test case

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Right now, I get a failure with `Exception: Failed to extract list of opend semaphores. Expect a Semaphore status, got ------ États des sémaphores --------` :)

Commits
-------

e665da0c9a [Lock] fix locale dependent test case

2 years agominor #27765 [HttpFoundation] update phpdoc of FlashBagInterface::add() (sir-kain)
Nicolas Grekas [Fri, 29 Jun 2018 16:24:44 +0000 (18:24 +0200)]
minor #27765 [HttpFoundation] update phpdoc of FlashBagInterface::add() (sir-kain)

This PR was squashed before being merged into the 2.8 branch (closes #27765).

Discussion
----------

[HttpFoundation] update phpdoc of FlashBagInterface::add()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**Reason why I propose to change the docblock like this: **
The `FlashBagInterface::add()` function does not work only with the `string` type in second parameter

Commits
-------

9135e18ded [HttpFoundation] update phpdoc of FlashBagInterface::add()

2 years ago[HttpFoundation] update phpdoc of FlashBagInterface::add()
Sir Kane [Thu, 28 Jun 2018 18:39:54 +0000 (18:39 +0000)]
[HttpFoundation] update phpdoc of FlashBagInterface::add()

2 years agobug #27776 [ProxyManagerBridge] Fix support of private services (bis) (nicolas-grekas)
Nicolas Grekas [Fri, 29 Jun 2018 16:22:49 +0000 (18:22 +0200)]
bug #27776 [ProxyManagerBridge] Fix support of private services (bis) (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[ProxyManagerBridge] Fix support of private services (bis)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27756
| License       | MIT
| Doc PR        | -

Commits
-------

3ca0c86afe [ProxyManagerBridge] Fix support of private services (bis)

2 years ago[ProxyManagerBridge] Fix support of private services (bis)
Nicolas Grekas [Fri, 29 Jun 2018 14:05:32 +0000 (16:05 +0200)]
[ProxyManagerBridge] Fix support of private services (bis)

2 years agominor #27771 [Form] relax fixtures for forward compat (nicolas-grekas)
Robin Chalas [Fri, 29 Jun 2018 14:02:08 +0000 (16:02 +0200)]
minor #27771 [Form] relax fixtures for forward compat (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] relax fixtures for forward compat

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Required to make #27768 green.

Commits
-------

2258ce4 [Form] relax fixtures for forward compat

2 years agobug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas...
Nicolas Grekas [Mon, 25 Jun 2018 09:39:34 +0000 (11:39 +0200)]
bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] Dont throw if "security.http_utils" is not found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27445
| License       | MIT
| Doc PR        | -

The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already.

Commits
-------

db88330448 [SecurityBundle] Dont throw if "security.http_utils" is not found

2 years ago[Form] relax fixtures for forward compat
Nicolas Grekas [Fri, 29 Jun 2018 11:03:55 +0000 (13:03 +0200)]
[Form] relax fixtures for forward compat

2 years agominor #27757 [Validator] Fix the namespace of RegexTest (dunglas)
Nicolas Grekas [Thu, 28 Jun 2018 13:08:17 +0000 (15:08 +0200)]
minor #27757 [Validator] Fix the namespace of RegexTest (dunglas)

This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Fix the namespace of RegexTest

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

fe7fc44085 [Validator] Fix the namespace of RegexTest

2 years ago[Validator] Fix the namespace of RegexTest
Kévin Dunglas [Thu, 28 Jun 2018 11:49:38 +0000 (13:49 +0200)]
[Validator] Fix the namespace of RegexTest

2 years ago[Lock] fix locale dependent test case
Nicolas Grekas [Thu, 28 Jun 2018 09:33:10 +0000 (11:33 +0200)]
[Lock] fix locale dependent test case

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Thu, 28 Jun 2018 06:35:12 +0000 (08:35 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  [HttpFoundation] fix registration of session proxies
  failing test to reproduce session problem
  [HttpFoundation] fix session tracking counter

2 years agobug #27714 [HttpFoundation] fix session tracking counter (nicolas-grekas, dmaicher)
Nicolas Grekas [Thu, 28 Jun 2018 06:32:50 +0000 (08:32 +0200)]
bug #27714 [HttpFoundation] fix session tracking counter (nicolas-grekas, dmaicher)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] fix session tracking counter

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As just discussed with @nicolas-grekas I found this issue today while upgrading my app to 3.4.12. Somehow its not possible anymore to set caching headers correctly since this commit: https://github.com/symfony/symfony/commit/146e01cb4442fbcb3b05dd8ae2569d9894374044#diff-5350dc763df30ada9d00563c115f6652

Commits
-------

89ed756462 failing test to reproduce session problem
26fc4e683f [HttpFoundation] fix session tracking counter

2 years agobug #27747 [HttpFoundation] fix registration of session proxies (nicolas-grekas)
Nicolas Grekas [Thu, 28 Jun 2018 06:26:51 +0000 (08:26 +0200)]
bug #27747 [HttpFoundation] fix registration of session proxies (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] fix registration of session proxies

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27674
| License       | MIT
| Doc PR        | -

Commits
-------

5ed40c095b [HttpFoundation] fix registration of session proxies

2 years ago[HttpFoundation] fix registration of session proxies
Nicolas Grekas [Wed, 27 Jun 2018 15:17:35 +0000 (17:17 +0200)]
[HttpFoundation] fix registration of session proxies

2 years agoMerge branch '3.4' into 4.0
Nicolas Grekas [Wed, 27 Jun 2018 21:04:32 +0000 (23:04 +0200)]
Merge branch '3.4' into 4.0

* 3.4:
  Bump ext-mongodb to 1.5 on Travis
  Redesign the Debug error page in prod
  [DI] fix dumping deprecated service in yaml
  bumped Symfony version to 3.4.13
  updated VERSION for 3.4.12
  updated CHANGELOG for 3.4.12
  bumped Symfony version to 2.8.43
  updated VERSION for 2.8.42
  update CONTRIBUTORS for 2.8.42
  updated CHANGELOG for 2.8.42

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Wed, 27 Jun 2018 21:02:57 +0000 (23:02 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  Bump ext-mongodb to 1.5 on Travis

2 years agoBump ext-mongodb to 1.5 on Travis
Nicolas Grekas [Wed, 27 Jun 2018 21:01:14 +0000 (23:01 +0200)]
Bump ext-mongodb to 1.5 on Travis

2 years agofailing test to reproduce session problem
David Maicher [Mon, 25 Jun 2018 18:31:52 +0000 (20:31 +0200)]
failing test to reproduce session problem

2 years ago[HttpFoundation] fix session tracking counter
Nicolas Grekas [Wed, 27 Jun 2018 11:18:14 +0000 (13:18 +0200)]
[HttpFoundation] fix session tracking counter

2 years agobug #27722 Redesign the Debug error page in prod (javiereguiluz)
Fabien Potencier [Tue, 26 Jun 2018 16:31:54 +0000 (18:31 +0200)]
bug #27722 Redesign the Debug error page in prod (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Redesign the Debug error page in prod

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22964
| License       | MIT
| Doc PR        | -

In `debug` mode, things are unchanged and the page looks like this:

![error-debug](https://user-images.githubusercontent.com/73419/41900161-5a2dfc3a-792e-11e8-8806-6333cce8cee9.png)

In `non-debug` mode, all Symfony-related things are removed and we use the same minimal design as the default `prod` error pages (see #27699):

![error-no-debug](https://user-images.githubusercontent.com/73419/41900218-798fda6c-792e-11e8-8b8e-22415ab810ac.png)

Commits
-------

7b9b1b9022 Redesign the Debug error page in prod

2 years agoRedesign the Debug error page in prod
Javier Eguiluz [Tue, 26 Jun 2018 08:45:54 +0000 (10:45 +0200)]
Redesign the Debug error page in prod

2 years agoMerge branch '2.8' into 3.4
Nicolas Grekas [Tue, 26 Jun 2018 08:26:17 +0000 (10:26 +0200)]
Merge branch '2.8' into 3.4

* 2.8:
  [DI] fix dumping deprecated service in yaml
  bumped Symfony version to 2.8.43
  updated VERSION for 2.8.42
  update CONTRIBUTORS for 2.8.42
  updated CHANGELOG for 2.8.42