symfony/.git
7 months agobug #37154 [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait ... 5.1
Fabien Potencier [Tue, 9 Jun 2020 04:53:37 +0000 (06:53 +0200)]
bug #37154 [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait (nicolas-grekas)

This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #37123
| License       | MIT
| Doc PR        | -

Needs https://github.com/symfony/recipes/pull/781

Commits
-------

bf0b48ad87 [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait

7 months ago[FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait
Nicolas Grekas [Mon, 8 Jun 2020 16:13:49 +0000 (18:13 +0200)]
[FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait

7 months agominor #37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh)
Fabien Potencier [Mon, 8 Jun 2020 10:38:09 +0000 (12:38 +0200)]
minor #37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] fix forward compatibility with Doctrine DBAL 2.11+

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

The methods will be deprecated in 2.11 (see doctrine/dbal#4019), but the forward compatibility layer is only present in 3.0 (see doctrine/dbal#4007).

Commits
-------

bca4f9970b fix forward compatibility with Doctrine DBAL 2.11+

7 months agofix forward compatibility with Doctrine DBAL 2.11+
Christian Flothmann [Mon, 8 Jun 2020 09:16:34 +0000 (11:16 +0200)]
fix forward compatibility with Doctrine DBAL 2.11+

7 months agobug #37126 [SecurityBundle] Fix the session listener registration under the new authe...
Fabien Potencier [Mon, 8 Jun 2020 06:10:18 +0000 (08:10 +0200)]
bug #37126 [SecurityBundle] Fix the session listener registration under the new authentication manager (johnvandeweghe)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[SecurityBundle] Fix the session listener registration under the new authentication manager

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37119
| License       | MIT
| Doc PR        | N/A

Fixes the logic that adds session listeners for firewalls to properly add them only for statefull firewalls. Adds tests to confirm that it is only added to statefull ones. Also remove unused abstract field on session listener

Commits
-------

936ae9df75 [SecurityBundle] Fix the session listener registration under the new authentication manager

7 months ago[SecurityBundle] Fix the session listener registration under the new authentication...
John VanDeWeghe [Sun, 7 Jun 2020 04:14:49 +0000 (23:14 -0500)]
[SecurityBundle] Fix the session listener registration under the new authentication manager

7 months agobug #37130 [Console] allow cursor to be used even when STDIN is not defined (xabbuh)
Fabien Potencier [Mon, 8 Jun 2020 06:06:34 +0000 (08:06 +0200)]
bug #37130 [Console] allow cursor to be used even when STDIN is not defined (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Console] allow cursor to be used even when STDIN is not defined

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37124
| License       | MIT
| Doc PR        |

This allows to use the `Cursor` class introduced in Symfony 5.1 even when the `STDIN` constant is not defined. We did a similar bugfix in the past in the `QuestionHelper` class in #10798.

Commits
-------

aff1ffaeff allow cursor to be used even when STDIN is not defined

7 months agoallow cursor to be used even when STDIN is not defined
Christian Flothmann [Sun, 7 Jun 2020 19:21:28 +0000 (21:21 +0200)]
allow cursor to be used even when STDIN is not defined

7 months agobug #37053 [PropertyAccess] Fix getter call order BC (1ed)
Nicolas Grekas [Sun, 7 Jun 2020 15:47:03 +0000 (17:47 +0200)]
bug #37053 [PropertyAccess] Fix getter call order BC (1ed)

This PR was merged into the 5.1 branch.

Discussion
----------

[PropertyAccess] Fix getter call order BC

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #37052
| License       | MIT
| Doc PR        | -

Property Accessor breaks BC due to a change in the order of calling the getters, see #37052

Commits
-------

8cf80688c7 [PropertyAccess] Fix getter call order BC

7 months agobug #37117 [Messenger/DoctrineBridge] set column length for mysql 5.6 compatibility...
Nicolas Grekas [Sun, 7 Jun 2020 15:46:15 +0000 (17:46 +0200)]
bug #37117 [Messenger/DoctrineBridge] set column length for mysql 5.6 compatibility (Nemo64)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger/DoctrineBridge] set column length for mysql 5.6 compatibility

MySQL 5.6 does not support more than 191 characters when an index is used and when using utf8mb4 as charset.
As a workaround, I define the length of the queue_name field.

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37116
| License       | MIT

Commits
-------

d12190687b set column length for mysql 5.6 compatibility

7 months agobug #37127 [Messenger/AmazonSqsBridge] Fixed left-over debug statement (sstok)
Nicolas Grekas [Sun, 7 Jun 2020 15:45:39 +0000 (17:45 +0200)]
bug #37127 [Messenger/AmazonSqsBridge] Fixed left-over debug statement (sstok)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger/AmazonSqsBridge] Fixed left-over debug statement

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  |
| Deprecations? | no
| Tickets       | Related to #37038
| License       | MIT
| Doc PR        |

I noticed whats properly a left-over debugging statement that blocks the code from further execution. /cc @jderusse can you check this (thanks).

Commits
-------

8b827e46f6 Fixed left-over debug statement

7 months agoMerge branch '5.0' into 5.1
Nicolas Grekas [Sun, 7 Jun 2020 15:42:22 +0000 (17:42 +0200)]
Merge branch '5.0' into 5.1

* 5.0:
  [Mime] Remove unused var
  [HttpClient] fix monitoring timeouts when other streams are active
  [PhpUnitBridge] fix syntax on PHP 5.3
  [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
  properly cascade validation to child forms
  [PhpUnitBridge] fix undefined var on version 3.4
  Move ajax clear event listener initialization on loadToolbar
  [HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray()
  take into account the context when preserving empty array objects
  [VarExporter] tfix: s/markAsSkipped/markTestSkipped/
  bumped Symfony version to 5.0.10
  updated VERSION for 5.0.9
  updated CHANGELOG for 5.0.9
  bumped Symfony version to 4.4.10
  updated VERSION for 4.4.9
  updated CHANGELOG for 4.4.9
  bumped Symfony version to 3.4.42
  updated VERSION for 3.4.41
  update CONTRIBUTORS for 3.4.41
  updated CHANGELOG for 3.4.41

7 months agoMerge branch '4.4' into 5.0
Nicolas Grekas [Sun, 7 Jun 2020 15:38:39 +0000 (17:38 +0200)]
Merge branch '4.4' into 5.0

* 4.4:
  [Mime] Remove unused var
  [HttpClient] fix monitoring timeouts when other streams are active
  [PhpUnitBridge] fix syntax on PHP 5.3
  [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
  properly cascade validation to child forms
  [PhpUnitBridge] fix undefined var on version 3.4
  Move ajax clear event listener initialization on loadToolbar
  [HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray()
  take into account the context when preserving empty array objects
  [VarExporter] tfix: s/markAsSkipped/markTestSkipped/
  bumped Symfony version to 4.4.10
  updated VERSION for 4.4.9
  updated CHANGELOG for 4.4.9
  bumped Symfony version to 3.4.42
  updated VERSION for 3.4.41
  update CONTRIBUTORS for 3.4.41
  updated CHANGELOG for 3.4.41

7 months agobug #37048 [HttpClient] fix monitoring timeouts when other streams are active (nicola...
Nicolas Grekas [Sun, 7 Jun 2020 15:37:15 +0000 (17:37 +0200)]
bug #37048 [HttpClient] fix monitoring timeouts when other streams are active (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix monitoring timeouts when other streams are active

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

d2a53f0bda [HttpClient] fix monitoring timeouts when other streams are active

7 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Sun, 7 Jun 2020 15:34:22 +0000 (17:34 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  [PhpUnitBridge] fix syntax on PHP 5.3
  [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
  properly cascade validation to child forms
  [PhpUnitBridge] fix undefined var on version 3.4
  bumped Symfony version to 3.4.42
  updated VERSION for 3.4.41
  update CONTRIBUTORS for 3.4.41
  updated CHANGELOG for 3.4.41

7 months agoFixed left-over debug statement
Sebastiaan Stok [Sun, 7 Jun 2020 09:03:29 +0000 (11:03 +0200)]
Fixed left-over debug statement

7 months agoset column length for mysql 5.6 compatibility
Marco Pfeiffer [Fri, 5 Jun 2020 20:29:28 +0000 (22:29 +0200)]
set column length for mysql 5.6 compatibility

MySQL 5.6 does not support more than 191 characters when an index is used and when using utf8mb4 as charset.
As a workaround, I define the length of the queue_name field.

7 months agominor #37118 [Mime] Remove unused var (fabpot)
Fabien Potencier [Sat, 6 Jun 2020 10:23:53 +0000 (12:23 +0200)]
minor #37118 [Mime] Remove unused var (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mime] Remove unused var

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

86613797d1 [Mime] Remove unused var

7 months ago[Mime] Remove unused var
Fabien Potencier [Fri, 5 Jun 2020 21:42:51 +0000 (23:42 +0200)]
[Mime] Remove unused var

7 months ago[HttpClient] fix monitoring timeouts when other streams are active
Nicolas Grekas [Tue, 26 May 2020 06:30:07 +0000 (08:30 +0200)]
[HttpClient] fix monitoring timeouts when other streams are active

7 months ago[PhpUnitBridge] fix syntax on PHP 5.3
Nicolas Grekas [Thu, 4 Jun 2020 15:35:46 +0000 (17:35 +0200)]
[PhpUnitBridge] fix syntax on PHP 5.3

7 months agobug #37085 [Form] properly cascade validation to child forms (xabbuh)
Fabien Potencier [Thu, 4 Jun 2020 12:25:55 +0000 (14:25 +0200)]
bug #37085 [Form] properly cascade validation to child forms (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] properly cascade validation to child forms

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37025, Fix #37027
| License       | MIT
| Doc PR        |

TODO:

- [x] improve test coverage

Commits
-------

7df5298ddf properly cascade validation to child forms

7 months agobug #37095 [PhpUnitBridge] Fix undefined index when output of "composer show" cannot...
Nicolas Grekas [Thu, 4 Jun 2020 10:31:39 +0000 (12:31 +0200)]
bug #37095 [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed

…nnot be parsed

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37086
| License       | MIT
| Doc PR        | -

Commits
-------

d3f9b7f833 [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed

7 months ago[PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
Nicolas Grekas [Thu, 4 Jun 2020 10:27:56 +0000 (12:27 +0200)]
[PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed

7 months agoproperly cascade validation to child forms
Christian Flothmann [Wed, 3 Jun 2020 13:32:40 +0000 (15:32 +0200)]
properly cascade validation to child forms

7 months ago[PropertyAccess] Fix getter call order BC
Gábor Egyed [Mon, 1 Jun 2020 21:14:04 +0000 (23:14 +0200)]
[PropertyAccess] Fix getter call order BC

7 months agobug #37092 [PhpUnitBridge] fix undefined var on version 3.4 (nicolas-grekas)
Nicolas Grekas [Thu, 4 Jun 2020 09:19:11 +0000 (11:19 +0200)]
bug #37092 [PhpUnitBridge] fix undefined var on version 3.4 (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] fix undefined var on version 3.4

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

bd6a06a8b3 [PhpUnitBridge] fix undefined var on version 3.4

7 months ago[PhpUnitBridge] fix undefined var on version 3.4
Nicolas Grekas [Thu, 4 Jun 2020 09:02:21 +0000 (11:02 +0200)]
[PhpUnitBridge] fix undefined var on version 3.4

7 months agobug #37022 [DependencyInjection] Improve missing package/version deprecation (acrobat)
Fabien Potencier [Wed, 3 Jun 2020 08:14:01 +0000 (10:14 +0200)]
bug #37022 [DependencyInjection] Improve missing package/version deprecation (acrobat)

This PR was merged into the 5.1 branch.

Discussion
----------

[DependencyInjection] Improve missing package/version deprecation

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |
| License       | MIT
| Doc PR        |

After updating to symfony 5.1 I've got some deprecations related to the missing package/version attributes/options for `deprecated` on services.

But currently it's not clear which bundle/part of the code is triggering the deprecations. The only way for me to track down where they were coming from was by setting a xdebug breakpoint in the `XmlFileLoader` and check the `$file` variable.

So it seemed like a good idea to include the file path in the deprecation message, that way it will be easier for users to know if their code or a bundle (and which) is triggering this deprecation.

Before:
<img width="871" alt="Screenshot 2020-05-31 at 13 51 03" src="https://user-images.githubusercontent.com/1374857/83351609-d0d65600-a345-11ea-9785-3237a3ec2360.png">

After:
<img width="907" alt="Screenshot 2020-05-31 at 13 50 10" src="https://user-images.githubusercontent.com/1374857/83351606-cfa52900-a345-11ea-9617-60d07e46234b.png">

Commits
-------

f603317363 [DependencyInjection] Improve missing package/version deprecation

7 months agobug #37038 Fix invalid char in SQS Headers (jderusse)
Fabien Potencier [Wed, 3 Jun 2020 08:07:24 +0000 (10:07 +0200)]
bug #37038 Fix invalid char in SQS Headers (jderusse)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

Fix invalid char in SQS Headers

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | yes
| Tickets       | https://github.com/symfony/symfony/pull/36525#issuecomment-636658635
| License       | MIT
| Doc PR        | /

From [Amazon documnetation](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-attributes.html) header's name have constraints:
- only `a-zA-Z0-9_\.-` + not start/end with a `.`
- 256 char

This PR serialize ALL headers in a single SQS Attribute.

Commits
-------

76a18b0b47 Fix invalid char in SQS Headers

7 months agoFix invalid char in SQS Headers
Jérémy Derussé [Mon, 1 Jun 2020 08:33:14 +0000 (10:33 +0200)]
Fix invalid char in SQS Headers

7 months agobug #37047 [SecurityBundle] Only register CSRF protection listener if CSRF is availab...
Fabien Potencier [Wed, 3 Jun 2020 08:04:58 +0000 (10:04 +0200)]
bug #37047 [SecurityBundle] Only register CSRF protection listener if CSRF is available (wouterj)

This PR was merged into the 5.1 branch.

Discussion
----------

[SecurityBundle] Only register CSRF protection listener if CSRF is available

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | yes
| Tickets       | Fix #37033
| License       | MIT
| Doc PR        | -

I know we're not allowed to add new deprecations in already released versions. However, I don't think anyone is using SecurityBundle's compiler passes except from Symfony itself - so I don't think anyone is affected by this deprecation. The alternatives would be:

* Add a new compiler pass in 5.1 that conditionally registers the CSRF listener
* Do this exact change in 5.2 and...
  * accept a `null` argument in the listener for 5.1
  * or add this to the `RegisterCsrfTokenClearingLogoutHandlerPass` class in 5.1

Commits
-------

2d738b30de Only register CSRF protection listener if CSRF is available

7 months agobug #37065 [HttpClient] Throw JsonException instead of TransportException on empty...
Fabien Potencier [Wed, 3 Jun 2020 08:00:49 +0000 (10:00 +0200)]
bug #37065 [HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray() (jeroennoten)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37064
| License       | MIT

Commits
-------

69547d9cfc [HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray()

7 months agobug #37058 [FrameworkBundle] Extension Serializer issue (Korbeil)
Fabien Potencier [Wed, 3 Jun 2020 07:58:46 +0000 (09:58 +0200)]
bug #37058 [FrameworkBundle] Extension Serializer issue (Korbeil)

This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Extension Serializer issue

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ???
| License       | MIT
| Doc PR        |

Hi,

When creating a new Symfony project and requiring `symfony/serializer` we have an issue with required service.

Here is a simple reproducer:
![image](https://user-images.githubusercontent.com/944409/83497176-6266d480-a4ba-11ea-98cb-7e354be0a273.png)

This bug was introduced by https://github.com/symfony/symfony/pull/31390

Commits
-------

ab5628f0f4 FrameworkBundle Serializer issue

7 months agobug #37077 [WebProfilerBundle] Move ajax clear event listener initialization on loadT...
Fabien Potencier [Tue, 2 Jun 2020 19:29:14 +0000 (21:29 +0200)]
bug #37077 [WebProfilerBundle] Move ajax clear event listener initialization on loadToolbar (Bruno BOUTAREL)

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] Move ajax clear event listener initialization on loadToolbar

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37073
| License       | MIT

Fix ajax clear event listener stacking on each ajax request made.
Comment says if should be synced with `TwigBundle/Resources/views/base_js.html.twig`

If not applicable feel free to deny.

Commits
-------

cf4587b498 Move ajax clear event listener initialization on loadToolbar

7 months agoMove ajax clear event listener initialization on loadToolbar
Bruno BOUTAREL [Tue, 2 Jun 2020 15:27:51 +0000 (17:27 +0200)]
Move ajax clear event listener initialization on loadToolbar

7 months ago[HttpClient] Throw JsonException instead of TransportException on empty response...
Jeroen Noten [Tue, 2 Jun 2020 12:57:19 +0000 (14:57 +0200)]
[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray()

7 months agobug #37056 [DoctrineBridge] register event listeners depending on the installed packa...
Fabien Potencier [Tue, 2 Jun 2020 08:47:59 +0000 (10:47 +0200)]
bug #37056 [DoctrineBridge] register event listeners depending on the installed packages (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[DoctrineBridge] register event listeners depending on the installed packages

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37045
| License       | MIT
| Doc PR        |

Commits
-------

f61b0097f4 register event listeners depending on the installed packages

7 months agobug #37020 [ExpressionLanguage] reset the internal state when the parser is finished...
Fabien Potencier [Tue, 2 Jun 2020 08:46:57 +0000 (10:46 +0200)]
bug #37020 [ExpressionLanguage] reset the internal state when the parser is finished (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[ExpressionLanguage] reset the internal state when the parser is finished

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

d58eb020d0 reset the internal state when the parser is finished

7 months agoFix CS
Fabien Potencier [Tue, 2 Jun 2020 08:42:14 +0000 (10:42 +0200)]
Fix CS

7 months agominor #37057 [Validator] simplify the tests (xabbuh)
Fabien Potencier [Tue, 2 Jun 2020 08:41:45 +0000 (10:41 +0200)]
minor #37057 [Validator] simplify the tests (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Validator] simplify the tests

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

cfc6fc8527 simplify the tests

7 months agobug #37049 [Serializer] take into account the context when preserving empty array...
Fabien Potencier [Tue, 2 Jun 2020 08:39:56 +0000 (10:39 +0200)]
bug #37049 [Serializer] take into account the context when preserving empty array objects (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] take into account the context when preserving empty array objects

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37041
| License       | MIT
| Doc PR        |

Commits
-------

98fff21140 take into account the context when preserving empty array objects

7 months agoFrameworkBundle Serializer issue
Baptiste Leduc [Tue, 2 Jun 2020 08:14:04 +0000 (10:14 +0200)]
FrameworkBundle Serializer issue

7 months agoregister event listeners depending on the installed packages
Christian Flothmann [Tue, 2 Jun 2020 06:41:55 +0000 (08:41 +0200)]
register event listeners depending on the installed packages

7 months agotake into account the context when preserving empty array objects
Christian Flothmann [Mon, 1 Jun 2020 17:29:37 +0000 (19:29 +0200)]
take into account the context when preserving empty array objects

7 months agoOnly register CSRF protection listener if CSRF is available
Wouter de Jong [Mon, 1 Jun 2020 16:23:15 +0000 (18:23 +0200)]
Only register CSRF protection listener if CSRF is available

7 months agobug #37031 [Security] Fixed PUBLIC_ACCESS in authenticated sessions (wouterj)
Fabien Potencier [Mon, 1 Jun 2020 05:24:47 +0000 (07:24 +0200)]
bug #37031 [Security] Fixed PUBLIC_ACCESS in authenticated sessions (wouterj)

This PR was merged into the 5.1 branch.

Discussion
----------

[Security] Fixed PUBLIC_ACCESS in authenticated sessions

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Found while testing https://github.com/scheb/2fa/pull/8, sorry for not spotting it before the stable release :disappointed:

Currently, authenticated users are denied access for pages that have `PUBLIC_ACCESS` set, as this attribute is only checked when no token was set. It should be checked for both cases.

Commits
-------

0ac530f460 Also check PUBLIC_ACCESS for authenticated tokens

7 months agobug #37028 [FrameworkBundle] Fix enabled_locales behavior (tgalopin)
Fabien Potencier [Mon, 1 Jun 2020 05:21:50 +0000 (07:21 +0200)]
bug #37028 [FrameworkBundle] Fix enabled_locales behavior (tgalopin)

This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Fix enabled_locales behavior

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I was experimenting with enabled_locales on my application and I noticed the cache didn't actually change. It seems the generated service definition was invalid: the file `var/cache/dev/ContainerFEQLy1x/App_KernelDevDebugContainer.php` defined `getTranslator_DefaultService` by calling `new Translator` with 7 arguments instead of 6.

It seems to be due to the fact that the DI extension does not replace the right argument. With the following fix applied the behavior works as expected.

However, reading the comment of Javier in https://github.com/symfony/symfony/pull/32433, it seems he tested it against Demo and it worked with the previous code. I'm not sure why, @javiereguiluz I'd be interested in knowing if I'm missing something here :) .

Commits
-------

e2ce7f5030 Fix enabled_locales behavior

7 months agominor #37032 [VarExporter] tfix: s/markAsSkipped/markTestSkipped/ (DavidPrevot)
Fabien Potencier [Mon, 1 Jun 2020 05:20:03 +0000 (07:20 +0200)]
minor #37032 [VarExporter] tfix: s/markAsSkipped/markTestSkipped/ (DavidPrevot)

This PR was merged into the 4.4 branch.

Discussion
----------

[VarExporter] tfix: s/markAsSkipped/markTestSkipped/

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Just fixes a typo causing the testsuite to fail at least on PHP 7.4.5

Commits
-------

393c9d920a [VarExporter] tfix: s/markAsSkipped/markTestSkipped/

7 months ago[VarExporter] tfix: s/markAsSkipped/markTestSkipped/
David Prévot [Mon, 1 Jun 2020 00:33:19 +0000 (14:33 -1000)]
[VarExporter] tfix: s/markAsSkipped/markTestSkipped/

7 months agoAlso check PUBLIC_ACCESS for authenticated tokens
Wouter de Jong [Sun, 31 May 2020 21:35:18 +0000 (23:35 +0200)]
Also check PUBLIC_ACCESS for authenticated tokens

Currently, authenticated users are denied access for pages that have
PUBLIC_ACCESS, as this attribute is only checked when no token was set.

7 months agoFix enabled_locales behavior
Titouan Galopin [Sun, 31 May 2020 19:25:02 +0000 (21:25 +0200)]
Fix enabled_locales behavior

7 months ago[DependencyInjection] Improve missing package/version deprecation
Jeroen Thora [Sun, 31 May 2020 11:14:43 +0000 (13:14 +0200)]
[DependencyInjection] Improve missing package/version deprecation

7 months agoreset the internal state when the parser is finished
Christian Flothmann [Sun, 31 May 2020 07:33:39 +0000 (09:33 +0200)]
reset the internal state when the parser is finished

7 months agosimplify the tests
Christian Flothmann [Sun, 31 May 2020 07:20:08 +0000 (09:20 +0200)]
simplify the tests

7 months agobumped Symfony version to 5.1.1
Fabien Potencier [Sun, 31 May 2020 06:17:42 +0000 (08:17 +0200)]
bumped Symfony version to 5.1.1

7 months agoMerge pull request #37019 from fabpot/release-5.1.0 v5.1.0
Fabien Potencier [Sun, 31 May 2020 06:14:54 +0000 (08:14 +0200)]
Merge pull request #37019 from fabpot/release-5.1.0

released v5.1.0

7 months agoupdated VERSION for 5.1.0
Fabien Potencier [Sun, 31 May 2020 06:14:18 +0000 (08:14 +0200)]
updated VERSION for 5.1.0

7 months agoupdated CHANGELOG for 5.1.0
Fabien Potencier [Sun, 31 May 2020 06:14:11 +0000 (08:14 +0200)]
updated CHANGELOG for 5.1.0

7 months agobumped Symfony version to 5.0.10
Fabien Potencier [Sun, 31 May 2020 06:13:19 +0000 (08:13 +0200)]
bumped Symfony version to 5.0.10

7 months agoMerge pull request #37018 from fabpot/release-5.0.9 v5.0.9
Fabien Potencier [Sun, 31 May 2020 05:30:29 +0000 (07:30 +0200)]
Merge pull request #37018 from fabpot/release-5.0.9

released v5.0.9

7 months agoupdated VERSION for 5.0.9
Fabien Potencier [Sun, 31 May 2020 05:30:12 +0000 (07:30 +0200)]
updated VERSION for 5.0.9

7 months agoupdated CHANGELOG for 5.0.9
Fabien Potencier [Sun, 31 May 2020 05:30:04 +0000 (07:30 +0200)]
updated CHANGELOG for 5.0.9

7 months agobumped Symfony version to 4.4.10
Fabien Potencier [Sun, 31 May 2020 05:29:28 +0000 (07:29 +0200)]
bumped Symfony version to 4.4.10

7 months agoMerge pull request #37017 from fabpot/release-4.4.9 v4.4.9
Fabien Potencier [Sun, 31 May 2020 05:26:09 +0000 (07:26 +0200)]
Merge pull request #37017 from fabpot/release-4.4.9

released v4.4.9

7 months agoupdated VERSION for 4.4.9
Fabien Potencier [Sun, 31 May 2020 05:25:51 +0000 (07:25 +0200)]
updated VERSION for 4.4.9

7 months agoupdated CHANGELOG for 4.4.9
Fabien Potencier [Sun, 31 May 2020 05:25:41 +0000 (07:25 +0200)]
updated CHANGELOG for 4.4.9

7 months agobumped Symfony version to 3.4.42
Fabien Potencier [Sun, 31 May 2020 05:24:17 +0000 (07:24 +0200)]
bumped Symfony version to 3.4.42

7 months agoMerge pull request #37016 from fabpot/release-3.4.41 v3.4.41
Fabien Potencier [Sun, 31 May 2020 05:14:34 +0000 (07:14 +0200)]
Merge pull request #37016 from fabpot/release-3.4.41

released v3.4.41

7 months agoupdated VERSION for 3.4.41
Fabien Potencier [Sun, 31 May 2020 05:14:17 +0000 (07:14 +0200)]
updated VERSION for 3.4.41

7 months agoupdate CONTRIBUTORS for 3.4.41
Fabien Potencier [Sun, 31 May 2020 05:14:13 +0000 (07:14 +0200)]
update CONTRIBUTORS for 3.4.41

7 months agoupdated CHANGELOG for 3.4.41
Fabien Potencier [Sun, 31 May 2020 05:13:42 +0000 (07:13 +0200)]
updated CHANGELOG for 3.4.41

7 months agobug #37009 [Validator] use "allowedVariables" to configure the ExpressionLanguageSynt...
Nicolas Grekas [Sat, 30 May 2020 21:58:16 +0000 (23:58 +0200)]
bug #37009 [Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony/symfony-docs#13669
| License       | MIT
| Doc PR        |

Commits
-------

4807dab305 [Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint

7 months ago[Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint
Christian Flothmann [Sat, 30 May 2020 08:18:13 +0000 (10:18 +0200)]
[Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint

7 months agoMerge branch '5.0' into 5.1
Nicolas Grekas [Sat, 30 May 2020 21:52:37 +0000 (23:52 +0200)]
Merge branch '5.0' into 5.1

* 5.0:
  [Security] Fixed AbstractToken::hasUserChanged()
  [DI] fix typo

7 months agoMerge branch '4.4' into 5.0
Nicolas Grekas [Sat, 30 May 2020 21:52:15 +0000 (23:52 +0200)]
Merge branch '4.4' into 5.0

* 4.4:
  [Security] Fixed AbstractToken::hasUserChanged()
  [DI] fix typo

7 months agobug #37008 [Security] Fixed AbstractToken::hasUserChanged() (wouterj)
Nicolas Grekas [Sat, 30 May 2020 21:50:18 +0000 (23:50 +0200)]
bug #37008 [Security] Fixed AbstractToken::hasUserChanged() (wouterj)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Security] Fixed AbstractToken::hasUserChanged()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36989
| License       | MIT
| Doc PR        | -

This PR completely reverts #35944.

That PR tried to fix a BC break (ref #35941, #35509) introduced by #31177. However, this broke many authentications (ref #36989), as the User is serialized in the session (as hinted by @stof). Many applications don't include the `roles` property in the serialization (at least, the MakerBundle doesn't include it).

In 5.2, we should probably deprecate having different roles in token and user, which fixes the BC breaks all together.

Commits
-------

f297beb42c [Security] Fixed AbstractToken::hasUserChanged()

7 months ago[Security] Fixed AbstractToken::hasUserChanged()
Wouter de Jong [Sat, 30 May 2020 09:27:30 +0000 (11:27 +0200)]
[Security] Fixed AbstractToken::hasUserChanged()

7 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Sat, 30 May 2020 21:06:19 +0000 (23:06 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  [DI] fix typo

7 months ago[PropertyAccess] fix merge
Nicolas Grekas [Sat, 30 May 2020 21:17:32 +0000 (23:17 +0200)]
[PropertyAccess] fix merge

7 months ago[DI] fix typo
Nicolas Grekas [Sat, 30 May 2020 21:06:01 +0000 (23:06 +0200)]
[DI] fix typo

7 months agoMerge branch '5.0' into 5.1
Nicolas Grekas [Sat, 30 May 2020 20:35:19 +0000 (22:35 +0200)]
Merge branch '5.0' into 5.1

* 5.0:
  Fix abstract method name in PHP doc block
  Various cleanups
  [HttpClient] fix issues in tests
  Fixes sprintf(): Too few arguments in form transformer
  [Console] Fix QuestionHelper::disableStty()
  [Validator] Use Mime component to determine mime type for file validator
  validate subforms in all validation groups
  Update Hungarian translations
  Add meaningful message when Process is not installed (ProcessHelper)
  [PropertyAccess] Fix TypeError parsing again.
  [TwigBridge] fix fallback html-to-txt body converter
  [Security/Http] fix merge
  [ErrorHandler] fix setting $trace to null in FatalError
  [Form] add missing Czech validators translation
  [Validator] add missing Czech translations
  never directly validate Existence (Required/Optional) constraints

7 months agoMerge branch '4.4' into 5.0
Nicolas Grekas [Sat, 30 May 2020 20:12:43 +0000 (22:12 +0200)]
Merge branch '4.4' into 5.0

* 4.4:
  Fix abstract method name in PHP doc block
  Various cleanups
  [HttpClient] fix issues in tests
  Fixes sprintf(): Too few arguments in form transformer
  [Console] Fix QuestionHelper::disableStty()
  [Validator] Use Mime component to determine mime type for file validator
  validate subforms in all validation groups
  Update Hungarian translations
  Add meaningful message when Process is not installed (ProcessHelper)
  [PropertyAccess] Fix TypeError parsing again.
  [TwigBridge] fix fallback html-to-txt body converter
  [Form] add missing Czech validators translation
  [Validator] add missing Czech translations
  never directly validate Existence (Required/Optional) constraints

7 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Sat, 30 May 2020 20:07:26 +0000 (22:07 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Fix abstract method name in PHP doc block

7 months agominor #37015 Fix abstract method name in PHP doc block (l-vo)
Nicolas Grekas [Sat, 30 May 2020 20:07:07 +0000 (22:07 +0200)]
minor #37015 Fix abstract method name in PHP doc block (l-vo)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix abstract method name in PHP doc block

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

d6966c3147 Fix abstract method name in PHP doc block

7 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Sat, 30 May 2020 20:06:45 +0000 (22:06 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Various cleanups

7 months agoFix abstract method name in PHP doc block
Laurent VOULLEMIER [Sat, 30 May 2020 19:50:06 +0000 (21:50 +0200)]
Fix abstract method name in PHP doc block

7 months agoVarious cleanups
Nicolas Grekas [Sat, 30 May 2020 18:58:05 +0000 (20:58 +0200)]
Various cleanups

7 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Sat, 30 May 2020 18:50:54 +0000 (20:50 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Fixes sprintf(): Too few arguments in form transformer
  [Console] Fix QuestionHelper::disableStty()
  validate subforms in all validation groups
  Update Hungarian translations
  Add meaningful message when Process is not installed (ProcessHelper)
  [PropertyAccess] Fix TypeError parsing again.
  [Form] add missing Czech validators translation
  [Validator] add missing Czech translations
  never directly validate Existence (Required/Optional) constraints

7 months agobug #36894 [Validator] never directly validate Existence (Required/Optional) constrai...
Nicolas Grekas [Sat, 30 May 2020 18:43:38 +0000 (20:43 +0200)]
bug #36894 [Validator] never directly validate Existence (Required/Optional) constraints (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] never directly validate Existence (Required/Optional) constraints

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36637 #36723
| License       | MIT
| Doc PR        |

Using `Optional` or `Required` like "regular" constraints does not make any sense, but doing so didn't break before #36365. I suggest to ignore them for now and deprecate using them outside the `Collection` constraint in 5.2.

Commits
-------

d333aae187 never directly validate Existence (Required/Optional) constraints

7 months agobug #37007 [Console] Fix QuestionHelper::disableStty() (chalasr)
Nicolas Grekas [Sat, 30 May 2020 18:43:03 +0000 (20:43 +0200)]
bug #37007 [Console] Fix QuestionHelper::disableStty() (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix QuestionHelper::disableStty()

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no>
| Tickets       | -
| License       | MIT
| Doc PR        | -

We broke it when adding `Terminal::hasSttyAvailable()`.
Let's fix it on 3.4 and move it to terminal on master, as suggested in #36977

Commits
-------

5d93b61278 [Console] Fix QuestionHelper::disableStty()

7 months agominor #37003 [PropertyAccess] Fix TypeError parsing again (derrabus)
Nicolas Grekas [Sat, 30 May 2020 18:42:19 +0000 (20:42 +0200)]
minor #37003 [PropertyAccess] Fix TypeError parsing again (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

[PropertyAccess] Fix TypeError parsing again

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Apparently, the format of `TypeError`s has changed again in php8. While investigating, I noticed our error message parsing is not handling anonymous classes well, so I've added some test cases for them.

I chose a fuzzier regular expression to parse the expected return type from the error message. Additionally, I'm checking the stack trace if the caught `TypeError` is really caused by the accessor call.

Commits
-------

03b4e98630 [PropertyAccess] Fix TypeError parsing again.

7 months agobug #36865 [Form] validate subforms in all validation groups (xabbuh)
Nicolas Grekas [Sat, 30 May 2020 18:41:29 +0000 (20:41 +0200)]
bug #36865 [Form] validate subforms in all validation groups (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] validate subforms in all validation groups

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36852
| License       | MIT
| Doc PR        |

Commits
-------

b819d94d14 validate subforms in all validation groups

7 months agobug #36907 Fixes sprintf(): Too few arguments in form transformer (pedrocasado)
Nicolas Grekas [Sat, 30 May 2020 18:40:39 +0000 (20:40 +0200)]
bug #36907 Fixes sprintf(): Too few arguments in form transformer (pedrocasado)

This PR was merged into the 3.4 branch.

Discussion
----------

Fixes sprintf(): Too few arguments in form transformer

Similar to: #29482

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | none

Fixes the form reverse transformation when the method viewToNorm is called within a value with the character %:

Before : "sprintf(): Too few arguments"

After : Form reverse transformation works.

Reference : http://php.net/manual/function.sprintf.php

Commits
-------

ff7d3f4f01 Fixes sprintf(): Too few arguments in form transformer

7 months agominor #37013 [HttpClient] fix issues in tests (nicolas-grekas)
Nicolas Grekas [Sat, 30 May 2020 18:39:29 +0000 (20:39 +0200)]
minor #37013 [HttpClient] fix issues in tests (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix issues in tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

a337ba5547 [HttpClient] fix issues in tests

7 months ago[HttpClient] fix issues in tests
Nicolas Grekas [Sat, 30 May 2020 18:30:09 +0000 (20:30 +0200)]
[HttpClient] fix issues in tests

7 months agoFixes sprintf(): Too few arguments in form transformer
Pedro Casado [Fri, 22 May 2020 17:37:09 +0000 (14:37 -0300)]
Fixes sprintf(): Too few arguments in form transformer

7 months agobug #36868 [Validator] Use Mime component to determine mime type for file validator...
Fabien Potencier [Sat, 30 May 2020 07:26:56 +0000 (09:26 +0200)]
bug #36868 [Validator] Use Mime component to determine mime type for file validator (pierredup)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Use Mime component to determine mime type for file validator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

When validating the mime type for a file, the Validator component relies on the `Symfony\Component\HttpFoundation\File\File` class, but if the HttpFoundation component is not installed, then you just get the error

```
PHP Fatal error:  Uncaught Error: Class 'Symfony\Component\HttpFoundation\File\File' not found
```

This PR uses the Mime component to get the mime type for a file and throws an exception if the Mime component is not installed.

Commits
-------

472883313f [Validator] Use Mime component to determine mime type for file validator

7 months agominor #37004 [Form] Update Hungarian translations (1ed)
Fabien Potencier [Sat, 30 May 2020 07:18:49 +0000 (09:18 +0200)]
minor #37004 [Form] Update Hungarian translations (1ed)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Update Hungarian translations

| Q             | A
| ------------- | ---
| Branch?       |  3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | -
| License       | MIT
| Doc PR        | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

1614595424 Update Hungarian translations

7 months ago[Console] Fix QuestionHelper::disableStty()
Robin Chalas [Fri, 29 May 2020 14:03:43 +0000 (16:03 +0200)]
[Console] Fix QuestionHelper::disableStty()