symfony/.git
3 months agoMerge pull request #38312 from fabpot/release-4.4.14 v4.4.14
Fabien Potencier [Sun, 27 Sep 2020 04:26:00 +0000 (06:26 +0200)]
Merge pull request #38312 from fabpot/release-4.4.14

released v4.4.14

3 months agoUpdate VERSION for 4.4.14
Fabien Potencier [Sun, 27 Sep 2020 04:25:44 +0000 (06:25 +0200)]
Update VERSION for 4.4.14

3 months agoUpdate CHANGELOG for 4.4.14
Fabien Potencier [Sun, 27 Sep 2020 04:25:32 +0000 (06:25 +0200)]
Update CHANGELOG for 4.4.14

3 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Sun, 27 Sep 2020 03:36:23 +0000 (05:36 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  update missing translations arabic
  [Yaml] simplify the test
  fix test by letting mock throw the actual expected exception

4 months agominor #38299 [ErrorHandler] Return false directly and remove unused variable (fancyweb)
Nicolas Grekas [Fri, 25 Sep 2020 09:42:25 +0000 (11:42 +0200)]
minor #38299 [ErrorHandler] Return false directly and remove unused variable (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] Return false directly and remove unused variable

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/37848
| License       | MIT
| Doc PR        | -

To return true, $type and $log both need to be true. But to enter the condition, one of them has to be false.

I also spotted an unused variable below so I removed it.

Commits
-------

3933957d1a [ErrorHandler] Return false directly and remove unused variable

4 months ago[ErrorHandler] Return false directly and remove unused variable
Thomas Calvet [Fri, 25 Sep 2020 08:50:50 +0000 (10:50 +0200)]
[ErrorHandler] Return false directly and remove unused variable

4 months agominor #38294 [OptionsResolver] Assert that the error type is valid in deprecations...
Fabien Potencier [Fri, 25 Sep 2020 06:00:01 +0000 (08:00 +0200)]
minor #38294 [OptionsResolver] Assert that the error type is valid in deprecations test (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[OptionsResolver] Assert that the error type is valid in deprecations test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

A change in the code could cause a warning for example and still produce the expected number of errors and the expected last error. Checking the type of the error is a little bit better. The best would be to check all the expected deprecations one by one, maybe later? 😄

Commits
-------

926d18f2f9 [OptionsResolver] Assert that the error type is valid in deprecations test

4 months ago[OptionsResolver] Assert that the error type is valid in deprecations test
Thomas Calvet [Thu, 24 Sep 2020 16:40:22 +0000 (18:40 +0200)]
[OptionsResolver] Assert that the error type is valid in deprecations test

4 months agobug #38248 [HttpClient] Allow bearer token with colon (stephanvierkant)
Nicolas Grekas [Thu, 24 Sep 2020 13:25:52 +0000 (15:25 +0200)]
bug #38248 [HttpClient] Allow bearer token with colon (stephanvierkant)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[HttpClient] Allow bearer token with colon

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

The JetBrains Hub (YouTrack API) creates tokens with a `perm:` prefix. This doesn't work right now, because HttpClient doesn't allow a colon in the bearer token.

As far as I can see, there is no reason to disallow the use of the semicolon in the bearer token, so this PR fixes it.

Example of a token: `perm:c3RlcGhhbg==.NTUtMw==.NiZw16agafhsQAShTvclhb78hyJh2H`

Commits
-------

82ed1ec20a [HttpClient] Allow bearer token with colon

4 months ago[HttpClient] Allow bearer token with colon
Stephan Vierkant [Sun, 20 Sep 2020 12:21:38 +0000 (14:21 +0200)]
[HttpClient] Allow bearer token with colon

4 months agobug #37837 [Form] Fix custom formats deprecation with HTML5 widgets (fancyweb)
Fabien Potencier [Thu, 24 Sep 2020 10:57:15 +0000 (12:57 +0200)]
bug #37837 [Form] Fix custom formats deprecation with HTML5 widgets (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Fix custom formats deprecation with HTML5 widgets

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/37698
| License       | MIT
| Doc PR        | -

1. The options resolver only show the deprecations for user defined (overidden) options.
2. The default value of the `html5` option is enough to pass the logical condition of the callback.

That means that only setting the `format` option (like in the reproducer) does not trigger the deprecation while it should. I think we need a feature in the options resolver component to handle those kind of cases 🤷‍♂️

Meanwhile, we can fix the issue by "deprecating" all the concerned options of the logical condition of the callback.

Commits
-------

d28182f99b [Form] Fix custom formats deprecation with HTML5 widgets

4 months ago[Form] Fix custom formats deprecation with HTML5 widgets
Thomas Calvet [Fri, 14 Aug 2020 13:14:23 +0000 (15:14 +0200)]
[Form] Fix custom formats deprecation with HTML5 widgets

4 months agobug #38285 [Contracts][Translation] Optional Intl dependency (ro0NL)
Fabien Potencier [Thu, 24 Sep 2020 09:41:33 +0000 (11:41 +0200)]
bug #38285 [Contracts][Translation] Optional Intl dependency (ro0NL)

This PR was merged into the 4.4 branch.

Discussion
----------

[Contracts][Translation] Optional Intl dependency

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
same as #38283, and should help streamlining #38230

Commits
-------

d65d39da14 [Contracts][Translation] Optional Intl dependency

4 months agobug #38283 [Translator] Optional Intl dependency (ro0NL)
Fabien Potencier [Thu, 24 Sep 2020 09:40:07 +0000 (11:40 +0200)]
bug #38283 [Translator] Optional Intl dependency (ro0NL)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Translator] Optional Intl dependency

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38279
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

i decided to cast $locale at construct, given its property is documented to be string

Commits
-------

a2eb263457 [Translator] Optional Intl dependency

4 months ago[Translator] Optional Intl dependency
Roland Franssen [Wed, 23 Sep 2020 18:32:26 +0000 (20:32 +0200)]
[Translator] Optional Intl dependency

4 months agobug #38271 [ErrorHandler] Escape JSON encoded log context (ro0NL)
Robin Chalas [Thu, 24 Sep 2020 09:16:22 +0000 (11:16 +0200)]
bug #38271 [ErrorHandler] Escape JSON encoded log context (ro0NL)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] Escape JSON encoded log context

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | eno <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Fixes https://github.com/symfony/symfony/issues/35569#issuecomment-581317792
Fixes https://github.com/symfony/symfony/issues/35569#issuecomment-696767559

The initial issue remains though (the webprofiler showing the logs tab in the exception panel), i'll try to give it another look sometime, but this is a quick win nevertheless.

cc @yceruto

Commits
-------

5572a68ed7 [ErrorHandler] Escape JSON encoded log context

4 months agobug #38284 [Cache][Lock][Messenger] fix compatibility with Doctrine DBAL 3 (xabbuh)
Christian Flothmann [Thu, 24 Sep 2020 07:08:24 +0000 (09:08 +0200)]
bug #38284 [Cache][Lock][Messenger] fix compatibility with Doctrine DBAL 3 (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache][Lock][Messenger] fix compatibility with Doctrine DBAL 3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a03885168e fix compatibility with Doctrine DBAL 3

4 months agofix compatibility with Doctrine DBAL 3
Christian Flothmann [Wed, 23 Sep 2020 18:53:58 +0000 (20:53 +0200)]
fix compatibility with Doctrine DBAL 3

4 months ago[Contracts][Translation] Optional Intl dependency
Roland Franssen [Wed, 23 Sep 2020 19:16:49 +0000 (21:16 +0200)]
[Contracts][Translation] Optional Intl dependency

4 months ago[ErrorHandler] Escape JSON encoded log context
Roland Franssen [Tue, 22 Sep 2020 16:24:16 +0000 (18:24 +0200)]
[ErrorHandler] Escape JSON encoded log context

4 months agominor #38266 update missing translations arabic (zairigimad)
Fabien Potencier [Tue, 22 Sep 2020 08:57:06 +0000 (10:57 +0200)]
minor #38266 update missing translations arabic (zairigimad)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead.

Discussion
----------

update missing translations arabic

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4, 4.4 or 5.1 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

76a47b38e2 update missing translations arabic

4 months agoupdate missing translations arabic
Zairig Imad [Tue, 22 Sep 2020 08:53:06 +0000 (10:53 +0200)]
update missing translations arabic

4 months agominor #38235 [Yaml] simplify the test (xabbuh)
Christian Flothmann [Fri, 18 Sep 2020 16:15:03 +0000 (18:15 +0200)]
minor #38235 [Yaml] simplify the test (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] simplify the test

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/pull/38228#discussion_r491045753
| License       | MIT
| Doc PR        |

Commits
-------

bb64fc9c3b [Yaml] simplify the test

4 months ago[Yaml] simplify the test
Christian Flothmann [Fri, 18 Sep 2020 15:57:36 +0000 (17:57 +0200)]
[Yaml] simplify the test

4 months agominor #38234 [Intl] fix test by letting mock throw the actual expected exception...
Christian Flothmann [Fri, 18 Sep 2020 14:09:04 +0000 (16:09 +0200)]
minor #38234 [Intl] fix test by letting mock throw the actual expected exception (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] fix test by letting mock throw the actual expected exception

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37808
| License       | MIT
| Doc PR        |

This fixes a mistake I made when rewriting the tests in #37808.

Commits
-------

f6f162dcdd fix test by letting mock throw the actual expected exception

4 months agofix merge
Christian Flothmann [Fri, 18 Sep 2020 14:07:46 +0000 (16:07 +0200)]
fix merge

4 months agoMerge branch '3.4' into 4.4
Christian Flothmann [Fri, 18 Sep 2020 13:54:02 +0000 (15:54 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  drop logger mock in favor of using the BufferingLogger
  [Yaml Parser] Fix edge cases when parsing multiple documents
  fix parsing comments not prefixed by a space

4 months agofix test by letting mock throw the actual expected exception
Christian Flothmann [Fri, 18 Sep 2020 13:37:50 +0000 (15:37 +0200)]
fix test by letting mock throw the actual expected exception

4 months agominor #38233 [EventDispatcher] drop logger mock in favor of using the BufferingLogger...
Fabien Potencier [Fri, 18 Sep 2020 12:34:39 +0000 (14:34 +0200)]
minor #38233 [EventDispatcher] drop logger mock in favor of using the BufferingLogger (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] drop logger mock in favor of using the BufferingLogger

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix https://github.com/symfony/symfony/pull/37808#discussion_r469463688
| License       | MIT
| Doc PR        |

Commits
-------

86a7e3289b drop logger mock in favor of using the BufferingLogger

4 months agodrop logger mock in favor of using the BufferingLogger
Christian Flothmann [Fri, 18 Sep 2020 11:57:55 +0000 (13:57 +0200)]
drop logger mock in favor of using the BufferingLogger

4 months agominor #38231 [Validator] catch ValueError thrown on PHP 8 (xabbuh)
Christian Flothmann [Fri, 18 Sep 2020 10:06:31 +0000 (12:06 +0200)]
minor #38231 [Validator] catch ValueError thrown on PHP 8 (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] catch ValueError thrown on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

see php/php-src@95f4ee38bbe8b1f237230cd0249b626ba5d7b037

Commits
-------

fb0d7beaaf catch ValueError thrown on PHP 8

4 months agobug #38228 [Yaml Parser] Fix edge cases when parsing multiple documents (digilist)
Fabien Potencier [Fri, 18 Sep 2020 10:04:33 +0000 (12:04 +0200)]
bug #38228 [Yaml Parser] Fix edge cases when parsing multiple documents (digilist)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml Parser] Fix edge cases when parsing multiple documents

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I identified some edge cases when parsing multiple YAML documents with the same parser instance, because the totalNumberOfLines was not reset and so any subsequent parsing considered the number of lines of the first document.

Consider this document:
```yaml
a:
    b: |
        row
        row2
c: d
```

Normally, `a.b` would be parsed as `row\nrow2\n`. But if the parser parsed a shorter document before, the `\n` after row2 was missing, as the parser considered it as the end of the file (that's why the `c: d` at the end is important).

So this fix resets the `totalNumberOfLines` in the YAML parser to `null` so that any subsequent parsing will initialize the value for the new document and does not use the file length of the first parsed document.

I stumbled upon this because of a flickering unit test that was using the translation component. Sometimes the translated string contained a trailing `\n` and sometimes not. In the end it was based on this bug, as the translation files were not loaded in the same order every time (not really sure why. It's somehow related to the cache state, but even with a warm cache it was not totally deterministic).

Commits
-------

012ee4fa59 [Yaml Parser] Fix edge cases when parsing multiple documents

4 months agocatch ValueError thrown on PHP 8
Christian Flothmann [Fri, 18 Sep 2020 09:45:13 +0000 (11:45 +0200)]
catch ValueError thrown on PHP 8

4 months agobug #38229 [Yaml] fix parsing comments not prefixed by a space (xabbuh)
Christian Flothmann [Fri, 18 Sep 2020 09:29:40 +0000 (11:29 +0200)]
bug #38229 [Yaml] fix parsing comments not prefixed by a space (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] fix parsing comments not prefixed by a space

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38223
| License       | MIT
| Doc PR        |

Commits
-------

35b223aaa4 fix parsing comments not prefixed by a space

4 months ago[Yaml Parser] Fix edge cases when parsing multiple documents
Markus Fasselt [Fri, 18 Sep 2020 08:16:56 +0000 (10:16 +0200)]
[Yaml Parser] Fix edge cases when parsing multiple documents

4 months agofix parsing comments not prefixed by a space
Christian Flothmann [Fri, 18 Sep 2020 08:50:51 +0000 (10:50 +0200)]
fix parsing comments not prefixed by a space

4 months agobug #38127 [Translator] Make sure a null locale is handled properly (jschaedl)
Fabien Potencier [Fri, 18 Sep 2020 08:46:54 +0000 (10:46 +0200)]
bug #38127 [Translator] Make sure a null locale is handled properly (jschaedl)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Translator] Make sure a null locale is handled properly

| Q             | A
| ------------- | ---
| Branch?       | 4.4<!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #38124  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

080ea5a0f7 [Translator] Make sure a null locale is handled properly

4 months ago[Translator] Make sure a null locale is handled properly
Jan Schädlich [Wed, 9 Sep 2020 11:50:45 +0000 (13:50 +0200)]
[Translator] Make sure a null locale is handled properly

4 months agoMerge branch '3.4' into 4.4
Christian Flothmann [Fri, 18 Sep 2020 08:35:10 +0000 (10:35 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  deal with errors being thrown on PHP 8

4 months agominor #38227 [VarDumper] deal with errors being thrown on PHP 8 (xabbuh)
Christian Flothmann [Fri, 18 Sep 2020 08:32:31 +0000 (10:32 +0200)]
minor #38227 [VarDumper] deal with errors being thrown on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] deal with errors being thrown on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

6175d528e8 deal with errors being thrown on PHP 8

4 months agodeal with errors being thrown on PHP 8
Christian Flothmann [Fri, 18 Sep 2020 08:10:16 +0000 (10:10 +0200)]
deal with errors being thrown on PHP 8

4 months agobug #38221 [Cache] Allow cache tags to be objects implementing __toString() (lstrojny)
Fabien Potencier [Thu, 17 Sep 2020 10:06:33 +0000 (12:06 +0200)]
bug #38221 [Cache] Allow cache tags to be objects implementing __toString() (lstrojny)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Cache] Allow cache tags to be objects implementing __toString()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | maybe
| New feature?  | maybe
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

`\Symfony\Contracts\Cache\CacheInterface::get(string $key, …)` implicitly converts objects with `__toString` while `CacheItem::tag()` will throw an exception. That’s a bit of a sharp edge.

Commits
-------

c2c03e050f [Cache] Allow cache tags to be objects implementing __toString()

4 months ago[Cache] Allow cache tags to be objects implementing __toString()
Lars Strojny [Thu, 17 Sep 2020 09:19:24 +0000 (11:19 +0200)]
[Cache] Allow cache tags to be objects implementing __toString()

4 months agobug #38212 [HttpKernel] Do not override max_redirects option in HttpClientKernel...
Fabien Potencier [Thu, 17 Sep 2020 10:05:06 +0000 (12:05 +0200)]
bug #38212 [HttpKernel] Do not override max_redirects option in HttpClientKernel (dmolineus)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Do not override max_redirects option in HttpClientKernel

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38207
| License       | MIT
| Doc PR        | -

As [proposed](https://github.com/symfony/symfony/issues/38207#issuecomment-693382336) by @nicolas-grekas this pull request removes the `max_redirects` setting in the `\Symfony\Component\HttpKernel\HttpClientKernel::handle` method.

It solves the issue that requests made by the `\Symfony\Component\HttpClient\CachingHttpClient` wouldn't follow redirects as described in the linked issue.

Commits
-------

981a11beed [HttpKernel] Do not override max_redirects option in HttpClientKernel

4 months ago[HttpKernel] Do not override max_redirects option in HttpClientKernel
David Molineus [Wed, 16 Sep 2020 15:27:48 +0000 (17:27 +0200)]
[HttpKernel] Do not override max_redirects option in HttpClientKernel

4 months agobug #38215 [HttpClient] Support for CURLOPT_LOCALPORT (derrabus)
Fabien Potencier [Thu, 17 Sep 2020 04:58:25 +0000 (06:58 +0200)]
bug #38215 [HttpClient] Support for CURLOPT_LOCALPORT (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Support for CURLOPT_LOCALPORT

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/38081#issuecomment-688166943
| License       | MIT
| Doc PR        | N/A

Commits
-------

45fa6b8f24 [HttpClient] Support for CURLOPT_LOCALPORT.

4 months agominor #38214 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3) (derrabus)
Fabien Potencier [Thu, 17 Sep 2020 04:54:14 +0000 (06:54 +0200)]
minor #38214 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3) (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #37564
| License       | MIT
| Doc PR        | N/A

This is #38103 on the 4.4 branch.

Commits
-------

73647e5ffe Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Thu, 17 Sep 2020 04:53:48 +0000 (06:53 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  remove superfluous cast
  Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR
  Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).

4 months agominor #38216 Patch YAML superfluous cast (ktomk)
Fabien Potencier [Thu, 17 Sep 2020 04:49:02 +0000 (06:49 +0200)]
minor #38216 Patch YAML superfluous cast (ktomk)

This PR was merged into the 3.4 branch.

Discussion
----------

Patch YAML superfluous cast

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4, 4.4 or 5.1 for bug fixes <!-- see below --> - 3.4 as branch to patch against as documented
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | -/- <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Commits
-------

05a9660a1e remove superfluous cast

4 months agoremove superfluous cast
Tom Klingenberg [Wed, 16 Sep 2020 23:48:05 +0000 (01:48 +0200)]
remove superfluous cast

in YAML component.

minor.

4 months ago[HttpClient] Support for CURLOPT_LOCALPORT.
Alexander M. Turek [Wed, 16 Sep 2020 22:10:08 +0000 (00:10 +0200)]
[HttpClient] Support for CURLOPT_LOCALPORT.

4 months agoUpgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).
Alexander M. Turek [Wed, 16 Sep 2020 21:01:09 +0000 (23:01 +0200)]
Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).

4 months agominor #38208 [Messenger] Minor fix of exception message formatting (wouterj)
Fabien Potencier [Wed, 16 Sep 2020 10:58:28 +0000 (12:58 +0200)]
minor #38208 [Messenger] Minor fix of exception message formatting (wouterj)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Minor fix of exception message formatting

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

See e.g. https://fabbot.io/report/symfony/symfony/37546/2f27613557295a34437d865f75a6a5308764bb34

Commits
-------

69187ac9ce Fixed exception message formatting

4 months agoFixed exception message formatting
Wouter de Jong [Wed, 16 Sep 2020 10:14:09 +0000 (12:14 +0200)]
Fixed exception message formatting

4 months agobug #38202 [FrameworkBundle] Fix xsd definition which prevent to add more than one...
Fabien Potencier [Wed, 16 Sep 2020 05:39:26 +0000 (07:39 +0200)]
bug #38202 [FrameworkBundle] Fix xsd definition which prevent to add more than one workflow metadata (l-vo)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fix xsd definition which prevent to add more than one workflow metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Fix xsd definition which prevent to add more than one workflow metadata (only in xml configuration format)

Commits
-------

94e390b96a [FrameworkBundle] Fix error in xsd which prevent to register more than one metadata

4 months ago[FrameworkBundle] Fix error in xsd which prevent to register more than one metadata
Laurent VOULLEMIER [Tue, 15 Sep 2020 15:33:03 +0000 (17:33 +0200)]
[FrameworkBundle] Fix error in xsd which prevent to register more than one metadata

4 months agobug #38166 [Console] work around disabled putenv() (SenTisso)
Fabien Potencier [Tue, 15 Sep 2020 11:40:23 +0000 (13:40 +0200)]
bug #38166 [Console] work around disabled putenv() (SenTisso)

This PR was merged into the 4.4 branch.

Discussion
----------

[Console] work around disabled putenv()

If this is set to true, then putenv functions simply won't be run in this script, making this function usable on servers, where putenv is disabled

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

d3f909bff3 [Console] work around disabled putenv()

4 months agominor #38187 [Form] Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR in...
Fabien Potencier [Tue, 15 Sep 2020 11:39:30 +0000 (13:39 +0200)]
minor #38187 [Form] Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR in BaseType (vladyslavstartsev)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR in BaseType

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

The purpose of this change is to find all usages of AbstractRendererEngine::CACHE_KEY_VAR. Currently, if you search for AbstractRendererEngine::CACHE_KEY_VAR you will see only access to it, i.e. (`$view->vars[AbstractRendererEngine::CACHE_KEY_VAR]`), but you can't find it in write level. With this pull request you can see where is was used for write.

Commits
-------

4fcb41c3ba Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR

4 months agominor #38191 [PhpUnitBridge] Fix error with ReflectionClass (sanmai)
Nicolas Grekas [Tue, 15 Sep 2020 08:18:57 +0000 (10:18 +0200)]
minor #38191 [PhpUnitBridge] Fix error with ReflectionClass (sanmai)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Fix error with ReflectionClass

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Introduced in #38094. Wish I know how I missed that.

Commits
-------

ed1bffeed7 [PhpUnitBridge] Fix error with ReflectionClass

4 months ago[Console] work around disabled putenv()
SenTisso [Sat, 12 Sep 2020 15:15:36 +0000 (17:15 +0200)]
[Console] work around disabled putenv()

4 months ago[PhpUnitBridge] Fix error with ReflectionClass
Alexey Kopytko [Tue, 15 Sep 2020 07:51:47 +0000 (16:51 +0900)]
[PhpUnitBridge] Fix error with ReflectionClass

4 months agobug #38173 [HttpClient][HttpClientTrait] don't calculate alternatives if option is...
Nicolas Grekas [Tue, 15 Sep 2020 07:11:04 +0000 (09:11 +0200)]
bug #38173 [HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm (ybenhssaien)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

If option is `auth_ntlm` an exception is thrown, `$alternatives` then is not used.

Commits
-------

ab1a96c999 [HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm

4 months ago[HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm
Youssef BENHSSAIEN [Sun, 13 Sep 2020 09:20:47 +0000 (11:20 +0200)]
[HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm

4 months agoChange 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR
vladyslavstartsev [Mon, 14 Sep 2020 16:22:49 +0000 (19:22 +0300)]
Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR

The purpose of this change is to find all usages of AbstractRendererEngine::CACHE_KEY_VAR. Currently, if you search for AbstractRendererEngine::CACHE_KEY_VAR you will see only access to it, i.e. (`$view->vars[AbstractRendererEngine::CACHE_KEY_VAR]`), but you can't find it in write level. With this pull request you can see where is was used for write.

4 months agominor #38186 [Messenger][minor ]Improve connection message readability (4.4) (l-vo)
Fabien Potencier [Mon, 14 Sep 2020 15:00:55 +0000 (17:00 +0200)]
minor #38186 [Messenger][minor ]Improve connection message readability (4.4) (l-vo)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger][minor ]Improve connection message readability (4.4)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Same as #38185 but for 4.4.
I created 2 PR since bridges directory has moved in 5.1 (to ease merge)

Commits
-------

63bc620efa [Messenger] Improve error message readability

4 months ago[Messenger] Improve error message readability
Laurent VOULLEMIER [Mon, 14 Sep 2020 14:48:28 +0000 (16:48 +0200)]
[Messenger] Improve error message readability

Since slashes are escaped, vhosts are not very readable.

4 months agominor #38103 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3) (derrabus)
Fabien Potencier [Mon, 14 Sep 2020 07:43:32 +0000 (09:43 +0200)]
minor #38103 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3) (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes/no
| New feature?  | no
| Deprecations? | no
| Tickets       | #37564
| License       | MIT
| Doc PR        | N/A

Our test suite on the 3.4 branch should be compatible with more recent versions of PHPUnit now. In order to make sure that it stays that way, I'm proposing to bump PHPUnit to 8.5 for the php 7.2 job and 9.3 for the php 7.3 and 7.4 jobs.

Commits
-------

ff47516ea0 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).

4 months agoUpgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).
Alexander M. Turek [Mon, 7 Sep 2020 20:06:42 +0000 (22:06 +0200)]
Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).

4 months agominor #38172 [FrameworkBundle] fix filename being cleaned up at end of tests (xabbuh)
Fabien Potencier [Sun, 13 Sep 2020 13:38:16 +0000 (15:38 +0200)]
minor #38172 [FrameworkBundle] fix filename being cleaned up at end of tests (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix filename being cleaned up at end of tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

47a5a93e3e fix filename being cleaned up at end of tests

4 months agofix filename being cleaned up at end of tests
Christian Flothmann [Sun, 13 Sep 2020 09:04:13 +0000 (11:04 +0200)]
fix filename being cleaned up at end of tests

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Sun, 13 Sep 2020 05:00:26 +0000 (07:00 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  [HttpFoundation] Skip the cookie_max_age fixture on PHP 8.
  add choice_translation_domain tests to prevent further regressions
  Update validators.tr.xlf

4 months agominor #38163 [DoctrineBridge] add choice_translation_domain tests to prevent further...
Fabien Potencier [Sun, 13 Sep 2020 04:55:19 +0000 (06:55 +0200)]
minor #38163 [DoctrineBridge] add choice_translation_domain tests to prevent further regressions (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[DoctrineBridge] add choice_translation_domain tests to prevent further regressions

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #https://github.com/symfony/symfony/pull/37521#issuecomment-678247192
| License       | MIT
| Doc PR        |

Commits
-------

7775b3707b add choice_translation_domain tests to prevent further regressions

4 months agobug #38169 [PhpUnitBridge] Internal classes are not legacy (derrabus)
Fabien Potencier [Sun, 13 Sep 2020 04:54:39 +0000 (06:54 +0200)]
bug #38169 [PhpUnitBridge] Internal classes are not legacy (derrabus)

This PR was submitted for the master branch but it was merged into the 4.4 branch instead.

Discussion
----------

[PhpUnitBridge] Internal classes are not legacy

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #37564
| License       | MIT
| Doc PR        | N/A

This change works around the issue that we can observe in the failed Travis build of #38103.

We must not call PHPUnit's internal `Test::getGroups()` method with a built-in class, otherwise we will run into a TypeError. This won't be fixed on PHPUnit's side, so we need to prevent that call. Our DeprecationErrorHander might run into this case if a deprecation is triggered while autoloading a class.

And forgive me, I've had a really hard time trying to craft a test case for that. 🙈

Commits
-------

7d55e0c065 Internal classes are not legacy.

4 months agominor #38168 [HttpFoundation] Skip the cookie_max_age fixture on PHP 8 (derrabus)
Fabien Potencier [Sun, 13 Sep 2020 04:52:13 +0000 (06:52 +0200)]
minor #38168 [HttpFoundation] Skip the cookie_max_age fixture on PHP 8 (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Skip the cookie_max_age fixture on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR suggest to skip a certain integration test on php 8. The integration test in question triggers a warning by setting a way too high expiration date when calling `setcookie()`. Apparently, this warning has been upgraded to a fatal error on php 8.

Since the integration test is run in a separate process, we might as well adjust the expectation of that test case, but I don't really see the point in asserting fatal error behavior, to be honest.

Commits
-------

d6d9b2927d [HttpFoundation] Skip the cookie_max_age fixture on PHP 8.

4 months agoInternal classes are not legacy.
Alexander M. Turek [Sat, 12 Sep 2020 21:46:40 +0000 (23:46 +0200)]
Internal classes are not legacy.

4 months ago[HttpFoundation] Skip the cookie_max_age fixture on PHP 8.
Alexander M. Turek [Sat, 12 Sep 2020 20:41:00 +0000 (22:41 +0200)]
[HttpFoundation] Skip the cookie_max_age fixture on PHP 8.

4 months agoadd choice_translation_domain tests to prevent further regressions
Christian Flothmann [Sat, 12 Sep 2020 12:53:51 +0000 (14:53 +0200)]
add choice_translation_domain tests to prevent further regressions

4 months agominor #38159 Update validators.tr.xlf (appaydin)
Fabien Potencier [Fri, 11 Sep 2020 15:36:44 +0000 (17:36 +0200)]
minor #38159 Update validators.tr.xlf (appaydin)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead.

Discussion
----------

Update validators.tr.xlf

Turkish Spelling error corrected.

| Q             | A
| ------------- | ---
| Branch?       | 4.4 5.1 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

f346eccb60 Update validators.tr.xlf

4 months agoUpdate validators.tr.xlf
Ramazan [Fri, 11 Sep 2020 14:35:30 +0000 (17:35 +0300)]
Update validators.tr.xlf

Turkish Spelling error corrected.

4 months ago[Cache] fix previous PR
Nicolas Grekas [Fri, 11 Sep 2020 11:46:01 +0000 (13:46 +0200)]
[Cache] fix previous PR

4 months agobug #38156 [Cache] fix ProxyAdapter not persisting items with infinite expiration...
Nicolas Grekas [Fri, 11 Sep 2020 11:34:06 +0000 (13:34 +0200)]
bug #38156 [Cache] fix ProxyAdapter not persisting items with infinite expiration (dmaicher)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] fix ProxyAdapter not persisting items with infinite expiration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38066
| License       | MIT
| Doc PR        | -

Commits
-------

d3af877022 [Cache] fix ProxyAdapter not persisting items with infinite expiration

4 months agoMerge remote-tracking branch 'origin/3.4' into 4.4
Nicolas Grekas [Fri, 11 Sep 2020 11:33:24 +0000 (13:33 +0200)]
Merge remote-tracking branch 'origin/3.4' into 4.4

* origin/3.4:
  add mising sr (latn & cyrl) translations
  allow consumers to mock all methods

4 months agominor #38157 [Validator] Add missing Serbian (sr_Latn & sr_Cyrl) translations (tambait)
Fabien Potencier [Fri, 11 Sep 2020 09:38:00 +0000 (11:38 +0200)]
minor #38157 [Validator] Add missing Serbian (sr_Latn & sr_Cyrl) translations (tambait)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add missing Serbian (sr_Latn & sr_Cyrl) translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | none
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

e927c7cf69 add mising sr (latn & cyrl) translations

4 months agoadd mising sr (latn & cyrl) translations
ivan [Fri, 11 Sep 2020 09:15:40 +0000 (11:15 +0200)]
add mising sr (latn & cyrl) translations

4 months ago[Cache] fix ProxyAdapter not persisting items with infinite expiration
David Maicher [Fri, 4 Sep 2020 18:10:14 +0000 (20:10 +0200)]
[Cache] fix ProxyAdapter not persisting items with infinite expiration

4 months agobug #38148 [HttpClient] fail properly when the server replies with HTTP/0.9 (nicolas...
Nicolas Grekas [Fri, 11 Sep 2020 07:06:13 +0000 (09:06 +0200)]
bug #38148 [HttpClient] fail properly when the server replies with HTTP/0.9 (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fail properly when the server replies with HTTP/0.9

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37923
| License       | MIT
| Doc PR        | -

Commits
-------

96759af1da [HttpClient] fail properly when the server replies with HTTP/0.9

4 months ago[HttpClient] fail properly when the server replies with HTTP/0.9
Nicolas Grekas [Thu, 10 Sep 2020 18:19:03 +0000 (20:19 +0200)]
[HttpClient] fail properly when the server replies with HTTP/0.9

4 months agoFix CS
Fabien Potencier [Fri, 11 Sep 2020 05:50:30 +0000 (07:50 +0200)]
Fix CS

4 months agobug #38131 [Validator] allow consumers to mock all methods (xabbuh)
Fabien Potencier [Thu, 10 Sep 2020 17:02:04 +0000 (19:02 +0200)]
bug #38131 [Validator] allow consumers to mock all methods (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] allow consumers to mock all methods

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38048
| License       | MIT
| Doc PR        |

Commits
-------

3227303dab allow consumers to mock all methods

4 months agobug #38139 [DI] dump OS-indepent paths in the compiled container (nicolas-grekas)
Fabien Potencier [Thu, 10 Sep 2020 16:59:53 +0000 (18:59 +0200)]
bug #38139 [DI] dump OS-indepent paths in the compiled container (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] dump OS-indepent paths in the compiled container

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38123
| License       | MIT
| Doc PR        | -

This allows compiling on Windows and running on Linux (Docker).

Commits
-------

4dcf9e7d13 [DI] dump OS-indepent paths in the compiled container

4 months agobug #38126 [Cache] Limit cache version character range (lstrojny)
Nicolas Grekas [Thu, 10 Sep 2020 16:48:32 +0000 (18:48 +0200)]
bug #38126 [Cache] Limit cache version character range (lstrojny)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Cache] Limit cache version character range

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n.A.
| License       | MIT
| Doc PR        |

Follow up for https://github.com/symfony/symfony/pull/38108

With current HEAD in 4.4, this will fail eventually: `simple-phpunit --repeat 1000 --stop-on-failure --filter "testGetMultiple$" src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTextModeTest.php`

After this PR it will no longer fail

@nicolas-grekas

Commits
-------

15c21db856 [Cache] Limit cache version character range

4 months ago[Cache] Limit cache version character range
Lars Strojny [Wed, 9 Sep 2020 10:57:09 +0000 (12:57 +0200)]
[Cache] Limit cache version character range

4 months agominor #38143 [FrameworkBundle] fix tests (xabbuh)
Nicolas Grekas [Thu, 10 Sep 2020 13:21:18 +0000 (15:21 +0200)]
minor #38143 [FrameworkBundle] fix tests (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

34dbb4e118 fix tests

4 months agofix tests
Christian Flothmann [Thu, 10 Sep 2020 13:17:34 +0000 (15:17 +0200)]
fix tests

4 months agobug #38142 [FrameworkBundle] adopt src/.preload.php (nicolas-grekas)
Fabien Potencier [Thu, 10 Sep 2020 12:32:12 +0000 (14:32 +0200)]
bug #38142 [FrameworkBundle] adopt src/.preload.php (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] adopt src/.preload.php

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38123
| License       | MIT
| Doc PR        | -

The leading dot prevents PSR-4 discovery from considering the file.

Commits
-------

f4c47ebefa [FrameworkBundle] adopt src/.preload.php

4 months ago[FrameworkBundle] adopt src/.preload.php
Nicolas Grekas [Thu, 10 Sep 2020 12:29:02 +0000 (14:29 +0200)]
[FrameworkBundle] adopt src/.preload.php

4 months ago[DI] dump OS-indepent paths in the compiled container
Nicolas Grekas [Thu, 10 Sep 2020 09:46:19 +0000 (11:46 +0200)]
[DI] dump OS-indepent paths in the compiled container

4 months agoallow consumers to mock all methods
Christian Flothmann [Wed, 9 Sep 2020 16:58:25 +0000 (18:58 +0200)]
allow consumers to mock all methods

4 months agobug #38108 [Cache] Fix key encoding issue in Memcached adapter (lstrojny)
Nicolas Grekas [Wed, 9 Sep 2020 09:22:51 +0000 (11:22 +0200)]
bug #38108 [Cache] Fix key encoding issue in Memcached adapter (lstrojny)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Cache] Fix key encoding issue in Memcached adapter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n.A.
| License       | MIT
| Doc PR        | Fix double encoding in memcached which lead to overlong keys being generated

Because the memcached adapter uses `rawurlencode()` to encode each and every key, keys will sometimes be too long and therefore hit the memcached limit of 250 bytes. This happens when the key is small enough to be below 250 when passed to `AbstractAdapterTrait::getId()` and is then blown up over the 250 bytes limit in memcached adapter without validating the length again.

Looking through the code, it seems that the double encoding is wholly unnecessary assuming if one makes sure the namespace is properly encoded. This PR therefore removes the double encoding and instead uses rawurlencode on the namespace (which is in turn properly accounted for when calculating whether or not we are over the ID limit).

Commits
-------

23bf9be8ce [Cache] Fix key encoding issue in Memcached adapter

4 months ago[Cache] Fix key encoding issue in Memcached adapter
Lars Strojny [Tue, 8 Sep 2020 09:20:58 +0000 (11:20 +0200)]
[Cache] Fix key encoding issue in Memcached adapter