symfony/.git
4 months agoMerge pull request #37999 from fabpot/release-5.1.4 v5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:30 +0000 (08:18 +0200)]
Merge pull request #37999 from fabpot/release-5.1.4

released v5.1.4

4 months agoUpdate VERSION for 5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:12 +0000 (08:18 +0200)]
Update VERSION for 5.1.4

4 months agoUpdate CHANGELOG for 5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:02 +0000 (08:18 +0200)]
Update CHANGELOG for 5.1.4

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 30 Aug 2020 09:59:07 +0000 (11:59 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [FrameworkBundle] fix tests

4 months agominor #37988 [FrameworkBundle] fix tests (xabbuh)
Fabien Potencier [Sun, 30 Aug 2020 09:56:37 +0000 (11:56 +0200)]
minor #37988 [FrameworkBundle] fix tests (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/pull/37967#issuecomment-683387401
| License       | MIT
| Doc PR        |

Commits
-------

19015ec404 [FrameworkBundle] fix tests

4 months ago[FrameworkBundle] fix tests
Christian Flothmann [Sun, 30 Aug 2020 09:40:10 +0000 (11:40 +0200)]
[FrameworkBundle] fix tests

4 months agoRevert "bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)"
Fabien Potencier [Sun, 30 Aug 2020 08:29:58 +0000 (10:29 +0200)]
Revert "bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)"

This reverts commit 92cb709222493dad1faea1ef4a8867e1fbdf263b, reversing
changes made to fc3095ff2fd23748230fd68c487a224491048994.

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 30 Aug 2020 07:26:18 +0000 (09:26 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Fix CS
  [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response
  [FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agoFix CS
Fabien Potencier [Sun, 30 Aug 2020 07:21:38 +0000 (09:21 +0200)]
Fix CS

4 months agobug #37966 [HttpClient][MockHttpClient][DX] Throw when the response factory callable...
Fabien Potencier [Sun, 30 Aug 2020 06:55:38 +0000 (08:55 +0200)]
bug #37966 [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The current message is `TypeError: Argument 4 passed to Symfony\Component\HttpClient\Response\MockResponse::fromRequest() must implement interface Symfony\Contracts\HttpClient\ResponseInterface, instance of Generator given`.

I lost some time with this because I was passing a callable that returns a \Generator instead of passing the resulting \Generator directly. We could support that case but I guess with the added exception message, it is clear we don't support it at all.

Commits
-------

564dce39f8 [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

4 months agominor #37967 [FrameworkBundle] Do not pass the base uri twice to scoped http clients...
Fabien Potencier [Sun, 30 Aug 2020 06:53:37 +0000 (08:53 +0200)]
minor #37967 [FrameworkBundle] Do not pass the base uri twice to scoped http clients (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Do not pass the base uri twice to scoped http clients

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I looked at my dumped scoped http client PHP file and I noticed the base uri was passed two times. I thought there was a bug somewhere in my configuration. Actually, we only need to pass it as the method argument here.

Commits
-------

e2fce0d89f [FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 28 Aug 2020 16:19:35 +0000 (18:19 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Fix typo

4 months agoFix typo
Fabien Potencier [Fri, 28 Aug 2020 16:19:28 +0000 (18:19 +0200)]
Fix typo

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 28 Aug 2020 16:18:32 +0000 (18:18 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [PhpUnitBridge] Create a predictable symlink pointing to the local install
  [PropertyInfo] Backport support for typed properties (PHP 7.4)
  [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
  [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
  [PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months ago[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not...
Thomas Calvet [Thu, 27 Aug 2020 15:46:33 +0000 (17:46 +0200)]
[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

4 months agobug #37971 [PropertyInfo] Backport support for typed properties (PHP 7.4) (dunglas)
Fabien Potencier [Fri, 28 Aug 2020 10:27:56 +0000 (12:27 +0200)]
bug #37971 [PropertyInfo] Backport support for typed properties (PHP 7.4) (dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyInfo] Backport support for typed properties (PHP 7.4)

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A. <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/13719 to be fixed

Backports #34557 as suggested.

One of my workmate hit this issue with the Serializer component and it was not obvious for him why it was not working, without hint.

Commits
-------

1b19f255a3 [PropertyInfo] Backport support for typed properties (PHP 7.4)

4 months agominor #37974 [PhpUnitBridge] Create a predictable symlink pointing to the local insta...
Fabien Potencier [Fri, 28 Aug 2020 10:27:13 +0000 (12:27 +0200)]
minor #37974 [PhpUnitBridge] Create a predictable symlink pointing to the local install (dunglas)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Create a predictable symlink pointing to the local install

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Static analysis tools such as PHPStan need to be able to autoload classes provided by to work. It's also useful to use the assertions provided by PHPUnit with other testing tools such as Behat.
When using `simple-phpunit`, PHPUnit isn't installed in the `vendor/` directory, consequently other tools cannot autoload its classes.

A workaround is to configure these tools to load the autoloader installed by `simple-phpunit`. Example with PHPstan:

```neon
parameters:
bootstrapFiles:
- vendor/bin/.phpunit/phpunit-9.2-0/vendor/autoload.php
```

However, the path of the autoloader isn't predictable: it depends of PHPUnit version.

This PR changes `simple-phpunit` to create a symlink with a predictable path (`vendor/.phpunit/phpunit`) pointing to the currently used version of PHPUnit, so it is possible to hardcode this value in config files.

The symlink is recreated before every run, so if a different version of PHPUnit must be used because the PHP version in use is different from the previous run (frequent when developing libraries compatible with multiple PHP versions), it still works.

Commits
-------

bf7654f245 [PhpUnitBridge] Create a predictable symlink pointing to the local install

4 months ago[PhpUnitBridge] Create a predictable symlink pointing to the local install
Kévin Dunglas [Fri, 28 Aug 2020 08:54:30 +0000 (10:54 +0200)]
[PhpUnitBridge] Create a predictable symlink pointing to the local install

4 months ago[PropertyInfo] Backport support for typed properties (PHP 7.4)
Kévin Dunglas [Sat, 23 Nov 2019 16:12:25 +0000 (17:12 +0100)]
[PropertyInfo] Backport support for typed properties (PHP 7.4)

4 months agobug #37970 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions (phpfour)
Fabien Potencier [Fri, 28 Aug 2020 07:51:20 +0000 (09:51 +0200)]
bug #37970 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions (phpfour)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Polyfill new phpunit 9.1 assertions

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37320
| License       | MIT
| Doc PR        | -

Backport of #37567, follows the discussion on #37960.

Commits
-------

d945b88c1a [PhpUnitBridge] Polyfill new phpunit 9.1 assertions

4 months ago[PhpUnitBridge] Polyfill new phpunit 9.1 assertions
Mohammad Emran Hasan [Mon, 13 Jul 2020 06:07:04 +0000 (12:07 +0600)]
[PhpUnitBridge] Polyfill new phpunit 9.1 assertions

4 months ago[FrameworkBundle] Do not pass the base uri twice to scoped http clients
Thomas Calvet [Thu, 27 Aug 2020 16:01:08 +0000 (18:01 +0200)]
[FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agominor #37964 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTra...
Fabien Potencier [Thu, 27 Aug 2020 14:50:42 +0000 (16:50 +0200)]
minor #37964 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait (dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a

Move the polyfill method introduced in #37960 in the `Assert` trait. Sorry I noticed this trait later.

Commits
-------

0426113eda [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

4 months ago[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
Kévin Dunglas [Thu, 27 Aug 2020 14:43:53 +0000 (16:43 +0200)]
[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

4 months agobug #37960 [PhpUnit] Add polyfill for assertMatchesRegularExpression() (dunglas)
Fabien Potencier [Thu, 27 Aug 2020 14:03:12 +0000 (16:03 +0200)]
bug #37960 [PhpUnit] Add polyfill for assertMatchesRegularExpression() (dunglas)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnit] Add polyfill for assertMatchesRegularExpression()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

`assertRegExp()` is now deprecated in favor of `assertMatchesRegularExpression`.

Commits
-------

33eccd2a00 [PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months ago[PhpUnit] Add polyfill for assertMatchesRegularExpression()
Kévin Dunglas [Wed, 26 Aug 2020 21:49:04 +0000 (23:49 +0200)]
[PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months agominor #37962 Update Notifier bridge DSN in readme (jeremyFreeAgent)
Fabien Potencier [Thu, 27 Aug 2020 13:16:49 +0000 (15:16 +0200)]
minor #37962 Update Notifier bridge DSN in readme (jeremyFreeAgent)

This PR was merged into the 5.1 branch.

Discussion
----------

Update Notifier bridge DSN in readme

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Add missing DSN documentation in README for 5.1

Commits
-------

17c0784c44 Update Notifier bridge readme

4 months agoUpdate Notifier bridge readme
Jérémy Romey [Thu, 27 Aug 2020 12:57:37 +0000 (14:57 +0200)]
Update Notifier bridge readme

4 months agobug #37941 [TwigBridge] allow null for $message of filter method `trans` (Flinsch)
Nicolas Grekas [Wed, 26 Aug 2020 14:33:20 +0000 (16:33 +0200)]
bug #37941 [TwigBridge] allow null for $message of filter method `trans` (Flinsch)

This PR was merged into the 5.1 branch.

Discussion
----------

[TwigBridge] allow null for $message of filter method `trans`

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37931
| License       | MIT

With Symfony 5.0, filter method `trans` of Symfony Twig Bridge does not allow null values for `$message` parameter anymore, breaking backward compatibility. See also #37931. The included commit provides a fix to this BC break by allowing null values again.

Commits
-------

039fc80d6c [TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null values for `$message` parameter anymore

4 months ago[TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null...
Flinsch [Tue, 25 Aug 2020 12:44:21 +0000 (14:44 +0200)]
[TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null values for `$message` parameter anymore

5 months agobug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)
Fabien Potencier [Wed, 26 Aug 2020 13:25:49 +0000 (15:25 +0200)]
bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)

This PR was submitted for the master branch but it was squashed and merged into the 5.1 branch instead.

Discussion
----------

[PropertyAccess] Fix accessing dynamic properties

| Q             | A
| ------------- | ---
| Branch?       | 5.1 (to be switched when merging)
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #37026 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | no <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

47bd0180d1 [PropertyAccess] Fix accessing dynamic properties

5 months ago[PropertyAccess] Fix accessing dynamic properties
Andrii Serdiuk [Mon, 20 Jul 2020 22:36:57 +0000 (01:36 +0300)]
[PropertyAccess] Fix accessing dynamic properties

5 months agobug #37927 [HttpClient] fix chaining promises returned by HttplugClient (CthulhuDen)
Fabien Potencier [Wed, 26 Aug 2020 11:34:52 +0000 (13:34 +0200)]
bug #37927 [HttpClient] fix chaining promises returned by HttplugClient (CthulhuDen)

This PR was merged into the 5.1 branch.

Discussion
----------

[HttpClient] fix chaining promises returned by HttplugClient

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37925
| License       | MIT

Guzzle runtime does not play too well with foreign promises, which can be fixed by wrapping them with `promise_for`.
Added failing test case from #37925 and suggested fix.
Should not break BC because `then` callback results get resolved before being passed to next `then` callback or returned from `wait`.

Commits
-------

75043a1fb0 [HttpClient] fix chaining promises returned by HttplugClient

5 months ago[HttpClient] fix chaining promises returned by HttplugClient
cthulhu [Mon, 24 Aug 2020 00:33:27 +0000 (03:33 +0300)]
[HttpClient] fix chaining promises returned by HttplugClient

5 months agobug #37953 [DI] fix dumping lazy non-shared services (nicolas-grekas)
Fabien Potencier [Wed, 26 Aug 2020 09:10:33 +0000 (11:10 +0200)]
bug #37953 [DI] fix dumping lazy non-shared services (nicolas-grekas)

This PR was merged into the 5.1 branch.

Discussion
----------

[DI] fix dumping lazy non-shared services

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37665
| License       | MIT
| Doc PR        | -

Commits
-------

a4f4ca74a7 [DI] fix dumping lazy non-shared services

5 months ago[DI] fix dumping lazy non-shared services
Nicolas Grekas [Wed, 26 Aug 2020 08:54:29 +0000 (10:54 +0200)]
[DI] fix dumping lazy non-shared services

5 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Wed, 26 Aug 2020 08:30:57 +0000 (10:30 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Backport: Improve link script with rollback when using symlink
  fix more numeric cases changing in PHP 8

5 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Wed, 26 Aug 2020 08:30:46 +0000 (10:30 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Backport: Improve link script with rollback when using symlink
  fix more numeric cases changing in PHP 8

5 months agominor #37952 Backport: Improve link script with rollback when using symlink (noniagri...
Fabien Potencier [Wed, 26 Aug 2020 08:30:29 +0000 (10:30 +0200)]
minor #37952 Backport: Improve link script with rollback when using symlink (noniagriconomie)

This PR was merged into the 3.4 branch.

Discussion
----------

Backport: Improve link script with rollback when using symlink

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Backports #37915 to 3.4.

Even if it's a new feature, it's a contributors tool that can be used for any version to try out.

Commits
-------

ab92e9f4c3 Backport: Improve link script with rollback when using symlink

5 months agoBackport: Improve link script with rollback when using symlink
noniagriconomie [Fri, 21 Aug 2020 17:05:22 +0000 (19:05 +0200)]
Backport: Improve link script with rollback when using symlink

5 months agobug #37949 [Yaml] fix more numeric cases changing in PHP 8 (xabbuh)
Fabien Potencier [Wed, 26 Aug 2020 06:48:07 +0000 (08:48 +0200)]
bug #37949 [Yaml] fix more numeric cases changing in PHP 8 (xabbuh)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead.

Discussion
----------

[Yaml] fix more numeric cases changing in PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/yaml/commit/968ffcfa6554b05a38c69b5c20d351e5dc4a4f15#r41697638
| License       | MIT
| Doc PR        |

see also https://wiki.php.net/rfc/saner-numeric-strings

Commits
-------

7cd5106041 fix more numeric cases changing in PHP 8

5 months agofix more numeric cases changing in PHP 8
Christian Flothmann [Wed, 26 Aug 2020 06:25:12 +0000 (08:25 +0200)]
fix more numeric cases changing in PHP 8

5 months agobug #37943 [Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authent...
Fabien Potencier [Tue, 25 Aug 2020 19:08:41 +0000 (21:08 +0200)]
bug #37943 [Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authenticator (wouterj)

This PR was merged into the 5.1 branch.

Discussion
----------

[Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authenticator

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37534
| License       | MIT
| Doc PR        | n/a

The `RememberMeAuthenticator` wrongly assumed the implementation details of `AbstractRememberMeServices::autoLogin()`. This means that (a) the authenticator did not work with other - custom - implementations of `RememberMeServicesInterface` and (b) there was a potentional to get an "Call to a member function getUser() on null" error.

This code removes all assumptions of the `autoLogin()` logic, other than that stated in the PHPdoc: https://github.com/symfony/symfony/blob/32ca714e938bcdf53c72a4dceb8ad0a1093ea2ae/src/Symfony/Component/Security/Http/RememberMe/RememberMeServicesInterface.php#L43-L53

Commits
-------

93aea910d9 Fixed autoLogin() returning null

5 months agoFixed autoLogin() returning null
Wouter de Jong [Tue, 25 Aug 2020 15:09:29 +0000 (17:09 +0200)]
Fixed autoLogin() returning null

5 months agominor #37922 [Notifier] backport documentation changes (noniagriconomie)
Fabien Potencier [Sun, 23 Aug 2020 09:47:18 +0000 (11:47 +0200)]
minor #37922 [Notifier] backport documentation changes (noniagriconomie)

This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] backport documentation changes

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I think #37809 should have been merged into the `5.1` branch.

Commits
-------

ff768fbdd9 [Notifier] add doc for free mobile dsn

5 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 23 Aug 2020 09:22:34 +0000 (11:22 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  account for is_numeric() behavior changes in PHP 8
  fix expected exception messages on PHP 8

5 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Sun, 23 Aug 2020 09:22:13 +0000 (11:22 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  account for is_numeric() behavior changes in PHP 8
  fix expected exception messages on PHP 8

5 months agoFix constraint
Fabien Potencier [Sun, 23 Aug 2020 09:12:48 +0000 (11:12 +0200)]
Fix constraint

5 months ago[Notifier] add doc for free mobile dsn
noniagriconomie [Wed, 12 Aug 2020 09:21:02 +0000 (11:21 +0200)]
[Notifier] add doc for free mobile dsn

5 months agobug #37921 [Yaml] account for is_numeric() behavior changes in PHP 8 (xabbuh)
Fabien Potencier [Sun, 23 Aug 2020 09:03:06 +0000 (11:03 +0200)]
bug #37921 [Yaml] account for is_numeric() behavior changes in PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] account for is_numeric() behavior changes in PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

05db8e0fef account for is_numeric() behavior changes in PHP 8

5 months agobug #37913 [Mailer] Support Return-Path in SesApiAsyncAwsTransport (cvmiert)
Fabien Potencier [Sun, 23 Aug 2020 09:01:08 +0000 (11:01 +0200)]
bug #37913 [Mailer] Support Return-Path in SesApiAsyncAwsTransport (cvmiert)

This PR was merged into the 5.1 branch.

Discussion
----------

[Mailer] Support Return-Path in SesApiAsyncAwsTransport

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Enable sending `SendEmailRequest`s with a `Return-Path` configured in
`SesApiAsyncAwsTransport`.

Commits
-------

61754cb891 [Mailer] Support Return-Path in SesApiAsyncAwsTransport

5 months agoaccount for is_numeric() behavior changes in PHP 8
Christian Flothmann [Sun, 23 Aug 2020 07:58:10 +0000 (09:58 +0200)]
account for is_numeric() behavior changes in PHP 8

5 months ago[Mailer] Support Return-Path in SesApiAsyncAwsTransport
Clara van Miert [Thu, 20 Aug 2020 17:19:12 +0000 (19:19 +0200)]
[Mailer] Support Return-Path in SesApiAsyncAwsTransport

Enable sending `SendEmailRequest`s with a `Return-Path` configured in
`SesApiAsyncAwsTransport`.

5 months agominor #37911 [Cache] fix expected exception message on PHP 8 (xabbuh)
Fabien Potencier [Sat, 22 Aug 2020 06:24:01 +0000 (08:24 +0200)]
minor #37911 [Cache] fix expected exception message on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] fix expected exception message on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

2c9af570a2 fix expected exception messages on PHP 8

5 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 21 Aug 2020 17:19:47 +0000 (19:19 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  fix passing arguments to call_user_func_array() on PHP 8
  allow Doctrine DBAL 3
  [Filesystem] fix test on PHP 8

5 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Fri, 21 Aug 2020 17:19:37 +0000 (19:19 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  fix passing arguments to call_user_func_array() on PHP 8
  [Filesystem] fix test on PHP 8

5 months agobug #37912 [ExpressionLanguage] fix passing arguments to call_user_func_array() on...
Fabien Potencier [Fri, 21 Aug 2020 16:53:32 +0000 (18:53 +0200)]
bug #37912 [ExpressionLanguage] fix passing arguments to call_user_func_array() on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[ExpressionLanguage] fix passing arguments to call_user_func_array() on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a55ce7c8bb fix passing arguments to call_user_func_array() on PHP 8

5 months agofix expected exception messages on PHP 8
Christian Flothmann [Fri, 21 Aug 2020 13:18:27 +0000 (15:18 +0200)]
fix expected exception messages on PHP 8

5 months agofix passing arguments to call_user_func_array() on PHP 8
Christian Flothmann [Fri, 21 Aug 2020 14:12:43 +0000 (16:12 +0200)]
fix passing arguments to call_user_func_array() on PHP 8

5 months agominor #37910 [Filesystem] fix test on PHP 8 (xabbuh)
Fabien Potencier [Fri, 21 Aug 2020 13:37:43 +0000 (15:37 +0200)]
minor #37910 [Filesystem] fix test on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Filesystem] fix test on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

c08178978a [Filesystem] fix test on PHP 8

5 months agominor #37908 allow Doctrine DBAL 3 (xabbuh)
Fabien Potencier [Fri, 21 Aug 2020 13:33:39 +0000 (15:33 +0200)]
minor #37908 allow Doctrine DBAL 3 (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

allow Doctrine DBAL 3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

967331e63a allow Doctrine DBAL 3

5 months agoallow Doctrine DBAL 3
Christian Flothmann [Fri, 21 Aug 2020 11:57:31 +0000 (13:57 +0200)]
allow Doctrine DBAL 3

5 months ago[Filesystem] fix test on PHP 8
Christian Flothmann [Fri, 21 Aug 2020 12:41:08 +0000 (14:41 +0200)]
[Filesystem] fix test on PHP 8

5 months agofix merge
Christian Flothmann [Fri, 21 Aug 2020 12:10:32 +0000 (14:10 +0200)]
fix merge

5 months agoMerge branch '4.4' into 5.1
Christian Flothmann [Fri, 21 Aug 2020 11:51:31 +0000 (13:51 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  stop using the deprecated schema synchronizer API

5 months agobug #37907 [Messenger] stop using the deprecated schema synchronizer API (xabbuh)
Fabien Potencier [Fri, 21 Aug 2020 10:14:49 +0000 (12:14 +0200)]
bug #37907 [Messenger] stop using the deprecated schema synchronizer API (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] stop using the deprecated schema synchronizer API

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

see the failing tests and doctrine/dbal#4213

Commits
-------

40129d6239 stop using the deprecated schema synchronizer API

5 months agostop using the deprecated schema synchronizer API
Christian Flothmann [Fri, 21 Aug 2020 09:39:43 +0000 (11:39 +0200)]
stop using the deprecated schema synchronizer API

5 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 21 Aug 2020 09:48:22 +0000 (11:48 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [Mailer] Fixed mandrill api header structure
  [HttpClient][ResponseTrait] Fix typo
  [Mailer] Reorder headers used to determine Sender
  [Validator] Add Lithuanian translation for ISIN constraint

5 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Fri, 21 Aug 2020 09:47:32 +0000 (11:47 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  [Validator] Add Lithuanian translation for ISIN constraint

5 months agoFix CS
Fabien Potencier [Fri, 21 Aug 2020 06:40:21 +0000 (08:40 +0200)]
Fix CS

5 months agobug #37899 [Mailer] Support reply-to in SesApiAsyncAwsTransport (cvmiert)
Fabien Potencier [Fri, 21 Aug 2020 06:36:53 +0000 (08:36 +0200)]
bug #37899 [Mailer] Support reply-to in SesApiAsyncAwsTransport (cvmiert)

This PR was merged into the 5.1 branch.

Discussion
----------

[Mailer] Support reply-to in SesApiAsyncAwsTransport

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Enable sending `SendEmailRequest`s with reply-to addresses with `SesApiAsyncAwsTransport`.

Commits
-------

163e961b44 [Mailer] Support reply-to in SesApiAsyncAwsTransport

5 months agobug #37900 [Mailer] Fixed mandrill api header structure (wulff)
Fabien Potencier [Fri, 21 Aug 2020 06:31:54 +0000 (08:31 +0200)]
bug #37900 [Mailer] Fixed mandrill api header structure (wulff)

This PR was submitted for the 5.1 branch but it was squashed and merged into the 4.4 branch instead.

Discussion
----------

[Mailer] Fixed mandrill api header structure

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

When using the Mandrill API transport, it is not possible to set a reply-to address.

**How to reproduce**
Create a new email and add a reply-to address:

```php
$email = (new Email())
    ->from('from@example.com')
    ->to('to@example.com')
    ->replyTo('replyto@example.com')
    ->subject('subject')
    ->text('text');
$mailer->send($email);
```

The expected result is a payload which contains the following headers:

```
"headers": {
    "reply-to": "replyto@example.com"
}
```

But instead, the `getPayload()` method produces these headers:

```
"headers": [
    "reply-to: replyto@example.com"
]
```

**Additional context**
See https://mandrillapp.com/api/docs/messages.html.

Commits
-------

aeb4c5e6c7 [Mailer] Fixed mandrill api header structure

5 months ago[Mailer] Fixed mandrill api header structure
wulff [Thu, 20 Aug 2020 17:19:41 +0000 (19:19 +0200)]
[Mailer] Fixed mandrill api header structure

5 months ago[Mailer] Support reply-to in SesApiAsyncAwsTransport
Clara van Miert [Thu, 20 Aug 2020 17:02:43 +0000 (19:02 +0200)]
[Mailer] Support reply-to in SesApiAsyncAwsTransport

Enable sending `SendEmailRequest`s with reply-to addresses with
`SesApiAsyncAwsTransport`.

5 months agominor #37895 [HttpClient][ResponseTrait] Fix typo (fancyweb)
Fabien Potencier [Thu, 20 Aug 2020 13:33:51 +0000 (15:33 +0200)]
minor #37895 [HttpClient][ResponseTrait] Fix typo (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient][ResponseTrait] Fix typo

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

cbd8ca0625 [HttpClient][ResponseTrait] Fix typo

5 months ago[HttpClient][ResponseTrait] Fix typo
Thomas Calvet [Thu, 20 Aug 2020 12:25:15 +0000 (14:25 +0200)]
[HttpClient][ResponseTrait] Fix typo

5 months agoFix CS
Fabien Potencier [Thu, 20 Aug 2020 05:29:43 +0000 (07:29 +0200)]
Fix CS

5 months agobug #37890 [Notifier] Fixed base_uri while call auth/time API (leblanc-simon)
Fabien Potencier [Thu, 20 Aug 2020 05:28:57 +0000 (07:28 +0200)]
bug #37890 [Notifier] Fixed base_uri while call auth/time API (leblanc-simon)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Fixed base_uri while call auth/time API

This patch fixed the base_uri missing while we call the auth/time OVH
API.

* Without this patch, the API call failed because the URL is wrong :
eu.api.ovh.com/auth/time

* With this patch, the API call successed, URL is :
https://eu.api.ovh.com/1.0/auth/time

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fixed base_uri while call auth/time API
| License       | MIT

Commits
-------

2f91485c40 [Notifier] Fixed base_uri while call auth/time API

5 months ago[Notifier] Fixed base_uri while call auth/time API
Simon Leblanc [Wed, 19 Aug 2020 23:38:33 +0000 (01:38 +0200)]
[Notifier] Fixed base_uri while call auth/time API

5 months agobug #37888 [Mailer] Reorder headers used to determine Sender (cvmiert)
Fabien Potencier [Wed, 19 Aug 2020 17:15:16 +0000 (19:15 +0200)]
bug #37888 [Mailer] Reorder headers used to determine Sender (cvmiert)

This PR was submitted for the master branch but it was merged into the 4.4 branch instead.

Discussion
----------

[Mailer] Reorder headers used to determine Sender

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Use the `Return-Path` header as the last candidate to determine the Envelope's sender address.

The `Return-Path` is usually configured _in addition_ to the `Sender` and/or `From` header: it allows for email bounces and complaints to be sent to a dedicated email address. It should therefor not be used as the first candidate header to determine the sender.

Commits
-------

7e60a8f8c9 [Mailer] Reorder headers used to determine Sender

5 months ago[Mailer] Reorder headers used to determine Sender
Clara van Miert [Wed, 19 Aug 2020 15:08:06 +0000 (17:08 +0200)]
[Mailer] Reorder headers used to determine Sender

Use the `Return-Path` header as the last candidate to determine the
Envelope's sender address.

The `Return-Path` is usually configured _in addition_ to the `Sender`
and/or `From` header: it allows for email bounces and complaints to be
sent to a dedicated email address. It should therefore not be used as
the first candidate header to determine the sender.

5 months agobug #37857 [PropertyInfo] Fix ReflectionExtractor + minor tweaks (ogizanagi)
Fabien Potencier [Wed, 19 Aug 2020 11:09:12 +0000 (13:09 +0200)]
bug #37857 [PropertyInfo] Fix ReflectionExtractor + minor tweaks (ogizanagi)

This PR was merged into the 5.1 branch.

Discussion
----------

[PropertyInfo] Fix ReflectionExtractor + minor tweaks

| Q             | A
| ------------- | ---
| Branch?       | 5.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Spotted while rebasing #32133

Commits
-------

7ccb5a1cf2 [PropertyInfo] Fix ReflectionExtractor + minor tweaks

5 months agobug #37868 [Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when...
Fabien Potencier [Wed, 19 Aug 2020 10:50:41 +0000 (12:50 +0200)]
bug #37868 [Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when stripping (kralos)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when stripping

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37864
| License       | MIT
| Doc PR        |

Allow duplicate querystring keys when stripping `collection`. `readPreferenceTags` is currently allowed to be specified twice so re-assembling the querystring with `http_build_query` will also strip duplicated `readPreferenceTags`. Use `preg_match` instead.

Commits
-------

c1ea9ae476 [Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when stripping

5 months ago[Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when stripping
Joe Bennett [Tue, 18 Aug 2020 00:56:03 +0000 (10:56 +1000)]
[Lock] MongoDbStore handle duplicate querystring keys in mongodb uri when stripping

5 months agominor #37881 [Validator] Add Lithuanian translation for ISIN constraint (norkunas)
Fabien Potencier [Wed, 19 Aug 2020 04:57:51 +0000 (06:57 +0200)]
minor #37881 [Validator] Add Lithuanian translation for ISIN constraint (norkunas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add Lithuanian translation for ISIN constraint

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | none

Commits
-------

d652041647 [Validator] Add Lithuanian translation for ISIN constraint

5 months ago[Validator] Add Lithuanian translation for ISIN constraint
Tomas [Wed, 19 Aug 2020 04:26:06 +0000 (07:26 +0300)]
[Validator] Add Lithuanian translation for ISIN constraint

5 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Tue, 18 Aug 2020 11:41:36 +0000 (13:41 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport
  mark the AssertingContextualValidator class as internal
  Fix the parameter names in the SecurityFactoryInterface::create() method
  [Serializer][ClassDiscriminatorMapping] Fix getMappedObjectType() when a discriminator child extends another one
  make return type correct

5 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Tue, 18 Aug 2020 11:39:55 +0000 (13:39 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  mark the AssertingContextualValidator class as internal
  make return type correct

5 months agominor #37877 fix: clarify parameter name to comply with deprecations from #34074...
Fabien Potencier [Tue, 18 Aug 2020 11:35:02 +0000 (13:35 +0200)]
minor #37877 fix: clarify parameter name to comply with deprecations from #34074 (Dennis Langen)

This PR was submitted for the master branch but it was squashed and merged into the 5.1 branch instead.

Discussion
----------

fix: clarify parameter name to comply with deprecations from #34074

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37824
| License       | MIT
| Doc PR        |

[FrameworkBundle] Clarify parameter name from `$attributes` to `$attribute` in `AbstractController:denyUnlessGranted`

Commits
-------

91249ed0bf fix: clarify parameter name to comply with deprecations from #34074

5 months agofix: clarify parameter name to comply with deprecations from #34074
Dennis Langen [Tue, 18 Aug 2020 11:16:15 +0000 (13:16 +0200)]
fix: clarify parameter name to comply with deprecations from #34074

5 months agominor #37760 make return type correct (vladyslavstartsev)
Fabien Potencier [Tue, 18 Aug 2020 11:29:18 +0000 (13:29 +0200)]
minor #37760 make return type correct (vladyslavstartsev)

This PR was merged into the 3.4 branch.

Discussion
----------

make return type correct

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

Since the real return type is `\ArrayIterator` AND array of `FormView` I've decided to change it. Also the other reason is that phpstan iks kind of failing because of this and I need to `assert` things in children of this class.

Commits
-------

32b5b9e1d7 make return type correct

5 months agobug #37872 [Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport (arend...
Fabien Potencier [Tue, 18 Aug 2020 10:13:56 +0000 (12:13 +0200)]
bug #37872 [Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport (arendjantetteroo)

This PR was merged into the 4.4 branch.

Discussion
----------

[Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37870
| License       | MIT
| Doc PR        | no

Fixes #37870

The SendgridApiTransport was not using the envelope to get the
recipients, so overriding the recipients with the EnvelopeListener was
not working.

Commits
-------

c4e5131757 [Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport

5 months ago[Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport
Arend-Jan Tetteroo [Tue, 18 Aug 2020 09:42:56 +0000 (11:42 +0200)]
[Sendgrid-Mailer] Fixed envelope recipients on sendgridApiTransport

Fixes #37870

The SendgridApiTransport was not using the envelope to get the
recipients, so overriding the recipients with the EnvelopeListener was
not working.

5 months agominor #37869 Fix the parameter names in the SecurityFactoryInterface::create() method...
Fabien Potencier [Tue, 18 Aug 2020 10:08:43 +0000 (12:08 +0200)]
minor #37869 Fix the parameter names in the SecurityFactoryInterface::create() method (leofeyer)

This PR was merged into the 4.4 branch.

Discussion
----------

Fix the parameter names in the SecurityFactoryInterface::create() method

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

With regard to PHP 8, Psalm has added a named arguments check:
https://psalm.dev/articles/getting-ready-for-named-arguments

This check currently fails, because the `SecurityFactoryInterface` uses different parameter names than the `AbstractFactory`. You can see for yourselves at https://psalm.dev/r/81413a1c96.

Commits
-------

a73f5c1587 Fix the parameter names in the SecurityFactoryInterface::create() method

5 months agominor #37838 [Validator] fix tests (xabbuh)
Fabien Potencier [Tue, 18 Aug 2020 10:01:51 +0000 (12:01 +0200)]
minor #37838 [Validator] fix tests (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Validator] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

162771f7e3 [Validator] fix tests

5 months ago[Validator] fix tests
Christian Flothmann [Fri, 14 Aug 2020 10:50:32 +0000 (12:50 +0200)]
[Validator] fix tests

5 months agominor #37871 [Validator] mark the AssertingContextualValidator class as internal...
Fabien Potencier [Tue, 18 Aug 2020 09:14:27 +0000 (11:14 +0200)]
minor #37871 [Validator] mark the AssertingContextualValidator class as internal (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] mark the AssertingContextualValidator class as internal

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

7ff0287cd6 mark the AssertingContextualValidator class as internal

5 months agomark the AssertingContextualValidator class as internal
Christian Flothmann [Tue, 18 Aug 2020 09:07:13 +0000 (11:07 +0200)]
mark the AssertingContextualValidator class as internal

5 months agoFix the parameter names in the SecurityFactoryInterface::create() method
Leo Feyer [Tue, 18 Aug 2020 08:04:43 +0000 (10:04 +0200)]
Fix the parameter names in the SecurityFactoryInterface::create() method

5 months agoRemove obsolete file
Fabien Potencier [Tue, 18 Aug 2020 07:41:32 +0000 (09:41 +0200)]
Remove obsolete file