symfony/.git
4 months agoMerge pull request #38029 from fabpot/release-5.1.5 v5.1.5
Fabien Potencier [Wed, 2 Sep 2020 08:15:35 +0000 (10:15 +0200)]
Merge pull request #38029 from fabpot/release-5.1.5

released v5.1.5

4 months agoUpdate VERSION for 5.1.5
Fabien Potencier [Wed, 2 Sep 2020 08:15:18 +0000 (10:15 +0200)]
Update VERSION for 5.1.5

4 months agoUpdate CHANGELOG for 5.1.5
Fabien Potencier [Wed, 2 Sep 2020 08:15:01 +0000 (10:15 +0200)]
Update CHANGELOG for 5.1.5

4 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Wed, 2 Sep 2020 08:02:12 +0000 (10:02 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [HttpClient] Fix deps=low

4 months ago[HttpClient] Fix deps=low
Nicolas Grekas [Wed, 2 Sep 2020 08:01:15 +0000 (10:01 +0200)]
[HttpClient] Fix deps=low

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Wed, 2 Sep 2020 07:42:11 +0000 (09:42 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Remove headers with internal meaning from HttpClient responses

4 months agosecurity #cve-2020-15094 Remove headers with internal meaning from HttpClient respons...
Fabien Potencier [Wed, 2 Sep 2020 07:40:48 +0000 (09:40 +0200)]
security #cve-2020-15094 Remove headers with internal meaning from HttpClient responses (mpdude)

This PR was merged into the 4.4 branch.

4 months agoRemove headers with internal meaning from HttpClient responses
Matthias Pigulla [Mon, 15 Jun 2020 07:28:47 +0000 (07:28 +0000)]
Remove headers with internal meaning from HttpClient responses

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Wed, 2 Sep 2020 07:07:40 +0000 (09:07 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Fix undefined index for inconsistent command name definition

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Wed, 2 Sep 2020 07:07:21 +0000 (09:07 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Fix undefined index for inconsistent command name definition

4 months agobug #38024 [Console] Fix undefined index for inconsistent command name definition...
Fabien Potencier [Wed, 2 Sep 2020 05:48:39 +0000 (07:48 +0200)]
bug #38024 [Console] Fix undefined index for inconsistent command name definition (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix undefined index for inconsistent command name definition

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fixes #38015
| License       | MIT
| Doc PR        | -

The issue happens when the command name is set via construct/setName() and is routed via a command loader under a different name, which causes `Application::get(): Command` to return null (return type violation) with a notice. This makes it throws a proper CommandNotFoundException as expected.

Commits
-------

d59140e857 Fix undefined index for inconsistent command name definition

4 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Tue, 1 Sep 2020 18:06:24 +0000 (20:06 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [DI] fix inlining of non-shared services

4 months agoFix undefined index for inconsistent command name definition
Robin Chalas [Tue, 1 Sep 2020 17:03:51 +0000 (19:03 +0200)]
Fix undefined index for inconsistent command name definition

4 months agobug #38023 [DI] fix inlining of non-shared services (nicolas-grekas)
Nicolas Grekas [Tue, 1 Sep 2020 18:02:38 +0000 (20:02 +0200)]
bug #38023 [DI] fix inlining of non-shared services (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] fix inlining of non-shared services

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37863
| License       | MIT
| Doc PR        | -

Commits
-------

380cb10587 [DI] fix inlining of non-shared services

4 months ago[DI] fix inlining of non-shared services
Nicolas Grekas [Tue, 1 Sep 2020 14:31:57 +0000 (16:31 +0200)]
[DI] fix inlining of non-shared services

4 months agoMerge branch '4.4' into 5.1
Christian Flothmann [Tue, 1 Sep 2020 13:16:17 +0000 (15:16 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  swallow deprecations

4 months agobug #38022 Missed AbstractArgument (a-menshchikov)
Fabien Potencier [Tue, 1 Sep 2020 12:38:02 +0000 (14:38 +0200)]
bug #38022 Missed AbstractArgument (a-menshchikov)

This PR was merged into the 5.1 branch.

Discussion
----------

Missed AbstractArgument

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Missed in 5.1

Commits
-------

b5a47dac52 Missed AbstractArgument

4 months agominor #37874 stop using the deprecated at() PHPUnit matcher (xabbuh)
Fabien Potencier [Tue, 1 Sep 2020 12:25:21 +0000 (14:25 +0200)]
minor #37874 stop using the deprecated at() PHPUnit matcher (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

stop using the deprecated at() PHPUnit matcher

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

e36e73b9cf stop using the deprecated at() PHPUnit matcher

4 months agoMissed AbstractArgument
Zmey [Tue, 1 Sep 2020 12:23:56 +0000 (15:23 +0300)]
Missed AbstractArgument

4 months agobug #38020 [PhpUnitBridge] swallow deprecations (xabbuh)
Fabien Potencier [Tue, 1 Sep 2020 10:08:42 +0000 (12:08 +0200)]
bug #38020 [PhpUnitBridge] swallow deprecations (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] swallow deprecations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

f0067c106c swallow deprecations

4 months agoswallow deprecations
Christian Flothmann [Mon, 31 Aug 2020 15:41:58 +0000 (17:41 +0200)]
swallow deprecations

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Tue, 1 Sep 2020 05:52:18 +0000 (07:52 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [Cache] Psr16Cache does not handle Proxy cache items
  [Serializer] fixed fix encoding of cache keys with anonymous classes
  Bump Symfony version to 4.4.13
  Update VERSION for 4.4.12
  Update CHANGELOG for 4.4.12
  Bump Symfony version to 3.4.45
  Update VERSION for 3.4.44
  Update CONTRIBUTORS for 3.4.44
  Update CHANGELOG for 3.4.44

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Tue, 1 Sep 2020 05:50:54 +0000 (07:50 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Bump Symfony version to 3.4.45
  Update VERSION for 3.4.44
  Update CONTRIBUTORS for 3.4.44
  Update CHANGELOG for 3.4.44

4 months agobug #37961 [Mailer] Fixed 'verify_peer' option in mailer DSN being ignored (SnakePin)
Fabien Potencier [Mon, 31 Aug 2020 19:53:05 +0000 (21:53 +0200)]
bug #37961 [Mailer] Fixed 'verify_peer' option in mailer DSN being ignored (SnakePin)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Mailer] Fixed 'verify_peer' option in mailer DSN being ignored

| Q             | A
| ------------- | ---
| Branch?       | 5.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

The mailer DSN option 'verify_peer' was being ignored because `$dsn->getOption('verify_peer', true)` was returning a string and thus NOT operator on it was always resulting in false. I propose changing the line where it is used with a `filter_var` call with the `FILTER_VALIDATE_BOOLEAN` as the filter parameter to overcome this issue.

Commits
-------

1c789e87aa [Mailer] Fixed 'verify_peer' option in mailer DSN being ignored

4 months ago[Mailer] Fixed 'verify_peer' option in mailer DSN being ignored
SnakePin [Thu, 27 Aug 2020 11:14:43 +0000 (14:14 +0300)]
[Mailer] Fixed 'verify_peer' option in mailer DSN being ignored

4 months agobug #38010 [Cache] Psr16Cache does not handle Proxy cache items (alex-dev)
Nicolas Grekas [Mon, 31 Aug 2020 16:53:24 +0000 (18:53 +0200)]
bug #38010 [Cache] Psr16Cache does not handle Proxy cache items (alex-dev)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] Psr16Cache does not handle Proxy cache items

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38006
| License       | MIT

Add test for Psr16Cache along with a ProxyAdapter

Commits
-------

e525fa1055 [Cache] Psr16Cache does not handle Proxy cache items

4 months ago[Cache] Psr16Cache does not handle Proxy cache items
Alexandre Parent [Mon, 31 Aug 2020 14:08:37 +0000 (10:08 -0400)]
[Cache] Psr16Cache does not handle Proxy cache items

4 months agobug #37937 [Serializer] fixed fix encoding of cache keys with anonymous classes ...
Nicolas Grekas [Mon, 31 Aug 2020 16:04:23 +0000 (18:04 +0200)]
bug #37937 [Serializer] fixed fix encoding of cache keys with anonymous classes (michaelzangerle)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Serializer] fixed fix encoding of cache keys with anonymous classes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36589
| License       | MIT
| Doc PR        | -

Commits
-------

3a4675359d [Serializer] fixed fix encoding of cache keys with anonymous classes

4 months ago[Serializer] fixed fix encoding of cache keys with anonymous classes
Michael Zangerle [Tue, 25 Aug 2020 09:11:10 +0000 (11:11 +0200)]
[Serializer] fixed fix encoding of cache keys with anonymous classes

4 months agobug #38002 [Validator] Fix PhpUnitBridge version constraint (derrabus)
Fabien Potencier [Mon, 31 Aug 2020 10:16:44 +0000 (12:16 +0200)]
bug #38002 [Validator] Fix PhpUnitBridge version constraint (derrabus)

This PR was merged into the 5.1 branch.

Discussion
----------

[Validator] Fix PhpUnitBridge version constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

This PR allows Validator 5.1 and PhpUnitBridge 5.1 to be installed alongside each other.

Commits
-------

1055a7f29b [Validator] Fix PhpUnitBridge version constraint.

4 months agobug #38001 Fix symfony/amazon-mailer constraint (Michał Jusięga)
Fabien Potencier [Mon, 31 Aug 2020 10:16:09 +0000 (12:16 +0200)]
bug #38001 Fix symfony/amazon-mailer constraint (Michał Jusięga)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

Fix symfony/amazon-mailer constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38000
| License       | MIT
| Doc PR        |

See #38000

~~symfony/valdiator left - I need to understand why~~

Commits
-------

15643642a3 Fix symfony/amazon-mailer constraint

4 months agoFix symfony/amazon-mailer constraint
Michał Jusięga [Mon, 31 Aug 2020 07:54:17 +0000 (09:54 +0200)]
Fix symfony/amazon-mailer constraint

4 months ago[Validator] Fix PhpUnitBridge version constraint.
Alexander M. Turek [Mon, 31 Aug 2020 09:01:51 +0000 (11:01 +0200)]
[Validator] Fix PhpUnitBridge version constraint.

4 months agoBump Symfony version to 5.1.5
Fabien Potencier [Mon, 31 Aug 2020 06:22:19 +0000 (08:22 +0200)]
Bump Symfony version to 5.1.5

4 months agoMerge pull request #37999 from fabpot/release-5.1.4 v5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:30 +0000 (08:18 +0200)]
Merge pull request #37999 from fabpot/release-5.1.4

released v5.1.4

4 months agoUpdate VERSION for 5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:12 +0000 (08:18 +0200)]
Update VERSION for 5.1.4

4 months agoUpdate CHANGELOG for 5.1.4
Fabien Potencier [Mon, 31 Aug 2020 06:18:02 +0000 (08:18 +0200)]
Update CHANGELOG for 5.1.4

4 months agoBump Symfony version to 4.4.13
Fabien Potencier [Mon, 31 Aug 2020 06:14:12 +0000 (08:14 +0200)]
Bump Symfony version to 4.4.13

4 months agoMerge pull request #37998 from fabpot/release-4.4.12 v4.4.12
Fabien Potencier [Mon, 31 Aug 2020 06:09:59 +0000 (08:09 +0200)]
Merge pull request #37998 from fabpot/release-4.4.12

released v4.4.12

4 months agoUpdate VERSION for 4.4.12
Fabien Potencier [Mon, 31 Aug 2020 06:09:42 +0000 (08:09 +0200)]
Update VERSION for 4.4.12

4 months agoUpdate CHANGELOG for 4.4.12
Fabien Potencier [Mon, 31 Aug 2020 06:09:33 +0000 (08:09 +0200)]
Update CHANGELOG for 4.4.12

4 months agoBump Symfony version to 3.4.45
Fabien Potencier [Mon, 31 Aug 2020 05:58:19 +0000 (07:58 +0200)]
Bump Symfony version to 3.4.45

4 months agoMerge pull request #37997 from fabpot/release-3.4.44 v3.4.44
Fabien Potencier [Mon, 31 Aug 2020 05:54:22 +0000 (07:54 +0200)]
Merge pull request #37997 from fabpot/release-3.4.44

released v3.4.44

4 months agoUpdate VERSION for 3.4.44
Fabien Potencier [Mon, 31 Aug 2020 05:53:42 +0000 (07:53 +0200)]
Update VERSION for 3.4.44

4 months agoUpdate CONTRIBUTORS for 3.4.44
Fabien Potencier [Mon, 31 Aug 2020 05:52:54 +0000 (07:52 +0200)]
Update CONTRIBUTORS for 3.4.44

4 months agoUpdate CHANGELOG for 3.4.44
Fabien Potencier [Mon, 31 Aug 2020 05:51:46 +0000 (07:51 +0200)]
Update CHANGELOG for 3.4.44

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 30 Aug 2020 09:59:07 +0000 (11:59 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [FrameworkBundle] fix tests

4 months agominor #37988 [FrameworkBundle] fix tests (xabbuh)
Fabien Potencier [Sun, 30 Aug 2020 09:56:37 +0000 (11:56 +0200)]
minor #37988 [FrameworkBundle] fix tests (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/pull/37967#issuecomment-683387401
| License       | MIT
| Doc PR        |

Commits
-------

19015ec404 [FrameworkBundle] fix tests

4 months ago[FrameworkBundle] fix tests
Christian Flothmann [Sun, 30 Aug 2020 09:40:10 +0000 (11:40 +0200)]
[FrameworkBundle] fix tests

4 months agoRevert "bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)"
Fabien Potencier [Sun, 30 Aug 2020 08:29:58 +0000 (10:29 +0200)]
Revert "bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)"

This reverts commit 92cb709222493dad1faea1ef4a8867e1fbdf263b, reversing
changes made to fc3095ff2fd23748230fd68c487a224491048994.

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 30 Aug 2020 07:26:18 +0000 (09:26 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Fix CS
  [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response
  [FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agoFix CS
Fabien Potencier [Sun, 30 Aug 2020 07:21:38 +0000 (09:21 +0200)]
Fix CS

4 months agobug #37966 [HttpClient][MockHttpClient][DX] Throw when the response factory callable...
Fabien Potencier [Sun, 30 Aug 2020 06:55:38 +0000 (08:55 +0200)]
bug #37966 [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The current message is `TypeError: Argument 4 passed to Symfony\Component\HttpClient\Response\MockResponse::fromRequest() must implement interface Symfony\Contracts\HttpClient\ResponseInterface, instance of Generator given`.

I lost some time with this because I was passing a callable that returns a \Generator instead of passing the resulting \Generator directly. We could support that case but I guess with the added exception message, it is clear we don't support it at all.

Commits
-------

564dce39f8 [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

4 months agominor #37967 [FrameworkBundle] Do not pass the base uri twice to scoped http clients...
Fabien Potencier [Sun, 30 Aug 2020 06:53:37 +0000 (08:53 +0200)]
minor #37967 [FrameworkBundle] Do not pass the base uri twice to scoped http clients (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Do not pass the base uri twice to scoped http clients

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I looked at my dumped scoped http client PHP file and I noticed the base uri was passed two times. I thought there was a bug somewhere in my configuration. Actually, we only need to pass it as the method argument here.

Commits
-------

e2fce0d89f [FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 28 Aug 2020 16:19:35 +0000 (18:19 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Fix typo

4 months agoFix typo
Fabien Potencier [Fri, 28 Aug 2020 16:19:28 +0000 (18:19 +0200)]
Fix typo

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 28 Aug 2020 16:18:32 +0000 (18:18 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  [PhpUnitBridge] Create a predictable symlink pointing to the local install
  [PropertyInfo] Backport support for typed properties (PHP 7.4)
  [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
  [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
  [PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months ago[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not...
Thomas Calvet [Thu, 27 Aug 2020 15:46:33 +0000 (17:46 +0200)]
[HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response

4 months agobug #37971 [PropertyInfo] Backport support for typed properties (PHP 7.4) (dunglas)
Fabien Potencier [Fri, 28 Aug 2020 10:27:56 +0000 (12:27 +0200)]
bug #37971 [PropertyInfo] Backport support for typed properties (PHP 7.4) (dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyInfo] Backport support for typed properties (PHP 7.4)

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A. <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/13719 to be fixed

Backports #34557 as suggested.

One of my workmate hit this issue with the Serializer component and it was not obvious for him why it was not working, without hint.

Commits
-------

1b19f255a3 [PropertyInfo] Backport support for typed properties (PHP 7.4)

4 months agominor #37974 [PhpUnitBridge] Create a predictable symlink pointing to the local insta...
Fabien Potencier [Fri, 28 Aug 2020 10:27:13 +0000 (12:27 +0200)]
minor #37974 [PhpUnitBridge] Create a predictable symlink pointing to the local install (dunglas)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Create a predictable symlink pointing to the local install

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Static analysis tools such as PHPStan need to be able to autoload classes provided by to work. It's also useful to use the assertions provided by PHPUnit with other testing tools such as Behat.
When using `simple-phpunit`, PHPUnit isn't installed in the `vendor/` directory, consequently other tools cannot autoload its classes.

A workaround is to configure these tools to load the autoloader installed by `simple-phpunit`. Example with PHPstan:

```neon
parameters:
bootstrapFiles:
- vendor/bin/.phpunit/phpunit-9.2-0/vendor/autoload.php
```

However, the path of the autoloader isn't predictable: it depends of PHPUnit version.

This PR changes `simple-phpunit` to create a symlink with a predictable path (`vendor/.phpunit/phpunit`) pointing to the currently used version of PHPUnit, so it is possible to hardcode this value in config files.

The symlink is recreated before every run, so if a different version of PHPUnit must be used because the PHP version in use is different from the previous run (frequent when developing libraries compatible with multiple PHP versions), it still works.

Commits
-------

bf7654f245 [PhpUnitBridge] Create a predictable symlink pointing to the local install

4 months ago[PhpUnitBridge] Create a predictable symlink pointing to the local install
Kévin Dunglas [Fri, 28 Aug 2020 08:54:30 +0000 (10:54 +0200)]
[PhpUnitBridge] Create a predictable symlink pointing to the local install

4 months ago[PropertyInfo] Backport support for typed properties (PHP 7.4)
Kévin Dunglas [Sat, 23 Nov 2019 16:12:25 +0000 (17:12 +0100)]
[PropertyInfo] Backport support for typed properties (PHP 7.4)

4 months agobug #37970 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions (phpfour)
Fabien Potencier [Fri, 28 Aug 2020 07:51:20 +0000 (09:51 +0200)]
bug #37970 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions (phpfour)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Polyfill new phpunit 9.1 assertions

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37320
| License       | MIT
| Doc PR        | -

Backport of #37567, follows the discussion on #37960.

Commits
-------

d945b88c1a [PhpUnitBridge] Polyfill new phpunit 9.1 assertions

4 months ago[PhpUnitBridge] Polyfill new phpunit 9.1 assertions
Mohammad Emran Hasan [Mon, 13 Jul 2020 06:07:04 +0000 (12:07 +0600)]
[PhpUnitBridge] Polyfill new phpunit 9.1 assertions

4 months ago[FrameworkBundle] Do not pass the base uri twice to scoped http clients
Thomas Calvet [Thu, 27 Aug 2020 16:01:08 +0000 (18:01 +0200)]
[FrameworkBundle] Do not pass the base uri twice to scoped http clients

4 months agominor #37964 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTra...
Fabien Potencier [Thu, 27 Aug 2020 14:50:42 +0000 (16:50 +0200)]
minor #37964 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait (dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a

Move the polyfill method introduced in #37960 in the `Assert` trait. Sorry I noticed this trait later.

Commits
-------

0426113eda [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

4 months ago[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
Kévin Dunglas [Thu, 27 Aug 2020 14:43:53 +0000 (16:43 +0200)]
[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait

4 months agobug #37960 [PhpUnit] Add polyfill for assertMatchesRegularExpression() (dunglas)
Fabien Potencier [Thu, 27 Aug 2020 14:03:12 +0000 (16:03 +0200)]
bug #37960 [PhpUnit] Add polyfill for assertMatchesRegularExpression() (dunglas)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnit] Add polyfill for assertMatchesRegularExpression()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

`assertRegExp()` is now deprecated in favor of `assertMatchesRegularExpression`.

Commits
-------

33eccd2a00 [PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months ago[PhpUnit] Add polyfill for assertMatchesRegularExpression()
Kévin Dunglas [Wed, 26 Aug 2020 21:49:04 +0000 (23:49 +0200)]
[PhpUnit] Add polyfill for assertMatchesRegularExpression()

4 months agominor #37962 Update Notifier bridge DSN in readme (jeremyFreeAgent)
Fabien Potencier [Thu, 27 Aug 2020 13:16:49 +0000 (15:16 +0200)]
minor #37962 Update Notifier bridge DSN in readme (jeremyFreeAgent)

This PR was merged into the 5.1 branch.

Discussion
----------

Update Notifier bridge DSN in readme

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Add missing DSN documentation in README for 5.1

Commits
-------

17c0784c44 Update Notifier bridge readme

4 months agoUpdate Notifier bridge readme
Jérémy Romey [Thu, 27 Aug 2020 12:57:37 +0000 (14:57 +0200)]
Update Notifier bridge readme

4 months agobug #37941 [TwigBridge] allow null for $message of filter method `trans` (Flinsch)
Nicolas Grekas [Wed, 26 Aug 2020 14:33:20 +0000 (16:33 +0200)]
bug #37941 [TwigBridge] allow null for $message of filter method `trans` (Flinsch)

This PR was merged into the 5.1 branch.

Discussion
----------

[TwigBridge] allow null for $message of filter method `trans`

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37931
| License       | MIT

With Symfony 5.0, filter method `trans` of Symfony Twig Bridge does not allow null values for `$message` parameter anymore, breaking backward compatibility. See also #37931. The included commit provides a fix to this BC break by allowing null values again.

Commits
-------

039fc80d6c [TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null values for `$message` parameter anymore

4 months ago[TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null...
Flinsch [Tue, 25 Aug 2020 12:44:21 +0000 (14:44 +0200)]
[TwigBridge] Fix #37931: BC break where filter method `trans` did not allow null values for `$message` parameter anymore

4 months agobug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)
Fabien Potencier [Wed, 26 Aug 2020 13:25:49 +0000 (15:25 +0200)]
bug #37622 [PropertyAccess] Fix accessing dynamic properties (andreyserdjuk)

This PR was submitted for the master branch but it was squashed and merged into the 5.1 branch instead.

Discussion
----------

[PropertyAccess] Fix accessing dynamic properties

| Q             | A
| ------------- | ---
| Branch?       | 5.1 (to be switched when merging)
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #37026 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | no <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

47bd0180d1 [PropertyAccess] Fix accessing dynamic properties

4 months ago[PropertyAccess] Fix accessing dynamic properties
Andrii Serdiuk [Mon, 20 Jul 2020 22:36:57 +0000 (01:36 +0300)]
[PropertyAccess] Fix accessing dynamic properties

4 months agobug #37927 [HttpClient] fix chaining promises returned by HttplugClient (CthulhuDen)
Fabien Potencier [Wed, 26 Aug 2020 11:34:52 +0000 (13:34 +0200)]
bug #37927 [HttpClient] fix chaining promises returned by HttplugClient (CthulhuDen)

This PR was merged into the 5.1 branch.

Discussion
----------

[HttpClient] fix chaining promises returned by HttplugClient

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37925
| License       | MIT

Guzzle runtime does not play too well with foreign promises, which can be fixed by wrapping them with `promise_for`.
Added failing test case from #37925 and suggested fix.
Should not break BC because `then` callback results get resolved before being passed to next `then` callback or returned from `wait`.

Commits
-------

75043a1fb0 [HttpClient] fix chaining promises returned by HttplugClient

4 months ago[HttpClient] fix chaining promises returned by HttplugClient
cthulhu [Mon, 24 Aug 2020 00:33:27 +0000 (03:33 +0300)]
[HttpClient] fix chaining promises returned by HttplugClient

4 months agobug #37953 [DI] fix dumping lazy non-shared services (nicolas-grekas)
Fabien Potencier [Wed, 26 Aug 2020 09:10:33 +0000 (11:10 +0200)]
bug #37953 [DI] fix dumping lazy non-shared services (nicolas-grekas)

This PR was merged into the 5.1 branch.

Discussion
----------

[DI] fix dumping lazy non-shared services

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37665
| License       | MIT
| Doc PR        | -

Commits
-------

a4f4ca74a7 [DI] fix dumping lazy non-shared services

4 months ago[DI] fix dumping lazy non-shared services
Nicolas Grekas [Wed, 26 Aug 2020 08:54:29 +0000 (10:54 +0200)]
[DI] fix dumping lazy non-shared services

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Wed, 26 Aug 2020 08:30:57 +0000 (10:30 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  Backport: Improve link script with rollback when using symlink
  fix more numeric cases changing in PHP 8

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Wed, 26 Aug 2020 08:30:46 +0000 (10:30 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  Backport: Improve link script with rollback when using symlink
  fix more numeric cases changing in PHP 8

4 months agominor #37952 Backport: Improve link script with rollback when using symlink (noniagri...
Fabien Potencier [Wed, 26 Aug 2020 08:30:29 +0000 (10:30 +0200)]
minor #37952 Backport: Improve link script with rollback when using symlink (noniagriconomie)

This PR was merged into the 3.4 branch.

Discussion
----------

Backport: Improve link script with rollback when using symlink

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Backports #37915 to 3.4.

Even if it's a new feature, it's a contributors tool that can be used for any version to try out.

Commits
-------

ab92e9f4c3 Backport: Improve link script with rollback when using symlink

4 months agoBackport: Improve link script with rollback when using symlink
noniagriconomie [Fri, 21 Aug 2020 17:05:22 +0000 (19:05 +0200)]
Backport: Improve link script with rollback when using symlink

4 months agobug #37949 [Yaml] fix more numeric cases changing in PHP 8 (xabbuh)
Fabien Potencier [Wed, 26 Aug 2020 06:48:07 +0000 (08:48 +0200)]
bug #37949 [Yaml] fix more numeric cases changing in PHP 8 (xabbuh)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead.

Discussion
----------

[Yaml] fix more numeric cases changing in PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/yaml/commit/968ffcfa6554b05a38c69b5c20d351e5dc4a4f15#r41697638
| License       | MIT
| Doc PR        |

see also https://wiki.php.net/rfc/saner-numeric-strings

Commits
-------

7cd5106041 fix more numeric cases changing in PHP 8

4 months agofix more numeric cases changing in PHP 8
Christian Flothmann [Wed, 26 Aug 2020 06:25:12 +0000 (08:25 +0200)]
fix more numeric cases changing in PHP 8

4 months agobug #37943 [Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authent...
Fabien Potencier [Tue, 25 Aug 2020 19:08:41 +0000 (21:08 +0200)]
bug #37943 [Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authenticator (wouterj)

This PR was merged into the 5.1 branch.

Discussion
----------

[Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authenticator

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37534
| License       | MIT
| Doc PR        | n/a

The `RememberMeAuthenticator` wrongly assumed the implementation details of `AbstractRememberMeServices::autoLogin()`. This means that (a) the authenticator did not work with other - custom - implementations of `RememberMeServicesInterface` and (b) there was a potentional to get an "Call to a member function getUser() on null" error.

This code removes all assumptions of the `autoLogin()` logic, other than that stated in the PHPdoc: https://github.com/symfony/symfony/blob/32ca714e938bcdf53c72a4dceb8ad0a1093ea2ae/src/Symfony/Component/Security/Http/RememberMe/RememberMeServicesInterface.php#L43-L53

Commits
-------

93aea910d9 Fixed autoLogin() returning null

4 months agoFixed autoLogin() returning null
Wouter de Jong [Tue, 25 Aug 2020 15:09:29 +0000 (17:09 +0200)]
Fixed autoLogin() returning null

4 months agominor #37922 [Notifier] backport documentation changes (noniagriconomie)
Fabien Potencier [Sun, 23 Aug 2020 09:47:18 +0000 (11:47 +0200)]
minor #37922 [Notifier] backport documentation changes (noniagriconomie)

This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] backport documentation changes

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I think #37809 should have been merged into the `5.1` branch.

Commits
-------

ff768fbdd9 [Notifier] add doc for free mobile dsn

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Sun, 23 Aug 2020 09:22:34 +0000 (11:22 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  account for is_numeric() behavior changes in PHP 8
  fix expected exception messages on PHP 8

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Sun, 23 Aug 2020 09:22:13 +0000 (11:22 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  account for is_numeric() behavior changes in PHP 8
  fix expected exception messages on PHP 8

4 months agoFix constraint
Fabien Potencier [Sun, 23 Aug 2020 09:12:48 +0000 (11:12 +0200)]
Fix constraint

4 months ago[Notifier] add doc for free mobile dsn
noniagriconomie [Wed, 12 Aug 2020 09:21:02 +0000 (11:21 +0200)]
[Notifier] add doc for free mobile dsn

4 months agobug #37921 [Yaml] account for is_numeric() behavior changes in PHP 8 (xabbuh)
Fabien Potencier [Sun, 23 Aug 2020 09:03:06 +0000 (11:03 +0200)]
bug #37921 [Yaml] account for is_numeric() behavior changes in PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] account for is_numeric() behavior changes in PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

05db8e0fef account for is_numeric() behavior changes in PHP 8

4 months agobug #37913 [Mailer] Support Return-Path in SesApiAsyncAwsTransport (cvmiert)
Fabien Potencier [Sun, 23 Aug 2020 09:01:08 +0000 (11:01 +0200)]
bug #37913 [Mailer] Support Return-Path in SesApiAsyncAwsTransport (cvmiert)

This PR was merged into the 5.1 branch.

Discussion
----------

[Mailer] Support Return-Path in SesApiAsyncAwsTransport

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Enable sending `SendEmailRequest`s with a `Return-Path` configured in
`SesApiAsyncAwsTransport`.

Commits
-------

61754cb891 [Mailer] Support Return-Path in SesApiAsyncAwsTransport

4 months agoaccount for is_numeric() behavior changes in PHP 8
Christian Flothmann [Sun, 23 Aug 2020 07:58:10 +0000 (09:58 +0200)]
account for is_numeric() behavior changes in PHP 8

4 months ago[Mailer] Support Return-Path in SesApiAsyncAwsTransport
Clara van Miert [Thu, 20 Aug 2020 17:19:12 +0000 (19:19 +0200)]
[Mailer] Support Return-Path in SesApiAsyncAwsTransport

Enable sending `SendEmailRequest`s with a `Return-Path` configured in
`SesApiAsyncAwsTransport`.

4 months agominor #37911 [Cache] fix expected exception message on PHP 8 (xabbuh)
Fabien Potencier [Sat, 22 Aug 2020 06:24:01 +0000 (08:24 +0200)]
minor #37911 [Cache] fix expected exception message on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] fix expected exception message on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

2c9af570a2 fix expected exception messages on PHP 8

4 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Fri, 21 Aug 2020 17:19:47 +0000 (19:19 +0200)]
Merge branch '4.4' into 5.1

* 4.4:
  fix passing arguments to call_user_func_array() on PHP 8
  allow Doctrine DBAL 3
  [Filesystem] fix test on PHP 8

4 months agoMerge branch '3.4' into 4.4
Fabien Potencier [Fri, 21 Aug 2020 17:19:37 +0000 (19:19 +0200)]
Merge branch '3.4' into 4.4

* 3.4:
  fix passing arguments to call_user_func_array() on PHP 8
  [Filesystem] fix test on PHP 8

4 months agobug #37912 [ExpressionLanguage] fix passing arguments to call_user_func_array() on...
Fabien Potencier [Fri, 21 Aug 2020 16:53:32 +0000 (18:53 +0200)]
bug #37912 [ExpressionLanguage] fix passing arguments to call_user_func_array() on PHP 8 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[ExpressionLanguage] fix passing arguments to call_user_func_array() on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a55ce7c8bb fix passing arguments to call_user_func_array() on PHP 8