symfony/.git
2 months agoMerge pull request #39043 from fabpot/release-5.2.0-RC1 v5.2.0-RC1
Fabien Potencier [Tue, 10 Nov 2020 07:54:54 +0000 (08:54 +0100)]
Merge pull request #39043 from fabpot/release-5.2.0-RC1

released v5.2.0-RC1

2 months agoUpdate VERSION for 5.2.0-RC1
Fabien Potencier [Tue, 10 Nov 2020 07:54:37 +0000 (08:54 +0100)]
Update VERSION for 5.2.0-RC1

2 months agoUpdate CHANGELOG for 5.2.0-RC1
Fabien Potencier [Tue, 10 Nov 2020 07:54:29 +0000 (08:54 +0100)]
Update CHANGELOG for 5.2.0-RC1

2 months agobug #39004 [Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalizatio...
Fabien Potencier [Tue, 10 Nov 2020 06:17:29 +0000 (07:17 +0100)]
bug #39004 [Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalization of FlattenException::$statusText (Jean85)

This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalization of FlattenException::$statusText

| Q             | A
| ------------- | ---
| Branch?       | 5.x (bugfix of a 5.x-only feature)
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39003
| License       | MIT

~WIP~ This is now complete and, thanks to @yceruto, I've fixed two bugs in this PR:
 * `ErrorDetailsStamp` couldn't be (de)serialized properly with that constructor argument
 * `FlattenException::$statusText` wasn't (de)normalized

Commits
-------

9af554cb41 [Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalization of FlattenException::$statusText

2 months ago[Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalization of Flatte...
Alessandro Lai [Thu, 5 Nov 2020 16:09:43 +0000 (17:09 +0100)]
[Messenger] Fix JSON deserialization of ErrorDetailsStamp and normalization of FlattenException::$statusText

2 months agoMerge branch '5.1' into 5.x
Christian Flothmann [Mon, 9 Nov 2020 19:34:12 +0000 (20:34 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  failing test for issue 38861
  [DoctrineBridge]  indexBy could reference to association columns

2 months agoMerge branch '4.4' into 5.1
Christian Flothmann [Mon, 9 Nov 2020 19:27:47 +0000 (20:27 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  failing test for issue 38861
  [DoctrineBridge]  indexBy could reference to association columns

2 months agoMerge branch '3.4' into 4.4
Christian Flothmann [Mon, 9 Nov 2020 19:21:10 +0000 (20:21 +0100)]
Merge branch '3.4' into 4.4

* 3.4:
  failing test for issue 38861
  [DoctrineBridge]  indexBy could reference to association columns

2 months agobug #38628 [DoctrineBridge] indexBy could reference to association columns (juanmigu...
Nicolas Grekas [Mon, 9 Nov 2020 17:47:11 +0000 (18:47 +0100)]
bug #38628 [DoctrineBridge]  indexBy could reference to association columns (juanmiguelbesada)

This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

[DoctrineBridge]  indexBy could reference to association columns

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #37982 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
-->

This is my approach to solve #37982. It partials reverts @xabbuh PR #38604

This is my first Symfony contribution, so please, tell me if I need to do something more or something is wrong.

Also, this bug affects 4.x and 5.x versions. I think merging in this branches is done automatically. If not, please tell me.

Thanks you

Commits
-------

f9a0e000e9 failing test for issue 38861
4c36145664 [DoctrineBridge]  indexBy could reference to association columns

2 months agofailing test for issue 38861
Bart Wach [Thu, 29 Oct 2020 20:30:43 +0000 (21:30 +0100)]
failing test for issue 38861

2 months ago[DoctrineBridge] indexBy could reference to association columns
Juan Miguel Besada [Mon, 19 Oct 2020 10:26:04 +0000 (12:26 +0200)]
[DoctrineBridge]  indexBy could reference to association columns

2 months agoMerge branch '5.1' into 5.x
Fabien Potencier [Mon, 9 Nov 2020 12:21:52 +0000 (13:21 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  Optimize circular collection by removing flattening

2 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Mon, 9 Nov 2020 12:21:43 +0000 (13:21 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  Optimize circular collection by removing flattening

2 months agobug #39021 [DependencyInjection] Optimize circular collection by removing flattening...
Fabien Potencier [Mon, 9 Nov 2020 12:20:23 +0000 (13:20 +0100)]
bug #39021  [DependencyInjection] Optimize circular collection by removing flattening (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

 [DependencyInjection] Optimize circular collection by removing flattening

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39015
| License       | MIT
| Doc PR        | -

Alternative to #39019

Commits
-------

e649f47726 Optimize circular collection by removing flattening

2 months agoOptimize circular collection by removing flattening
Jérémy Derussé [Fri, 6 Nov 2020 16:43:05 +0000 (17:43 +0100)]
Optimize circular collection by removing flattening

2 months agoMerge branch '5.1' into 5.x
Fabien Potencier [Mon, 9 Nov 2020 10:58:06 +0000 (11:58 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  also reset id readers
  Fix LDAP pagination

2 months agoMerge branch '4.4' into 5.1
Fabien Potencier [Mon, 9 Nov 2020 10:57:52 +0000 (11:57 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  also reset id readers
  Fix LDAP pagination

2 months agobug #39031 [Ldap] Fix pagination (jderusse)
Fabien Potencier [Mon, 9 Nov 2020 10:55:57 +0000 (11:55 +0100)]
bug #39031 [Ldap] Fix pagination (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[Ldap] Fix pagination

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #38874
| License       | MIT
| Doc PR        | N/A

This replaces #38875 to fix a bug introduced by #38392

Commits
-------

4fe0a6f2b9 Fix LDAP pagination

2 months agominor #39029 Adds constants for YamlEncoder options (dbrumann)
Fabien Potencier [Mon, 9 Nov 2020 10:52:36 +0000 (11:52 +0100)]
minor #39029 Adds constants for YamlEncoder options (dbrumann)

This PR was merged into the 5.2-dev branch.

Discussion
----------

Adds constants for YamlEncoder options

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

As I understand it encoders and normalizers use (public) constants for context keys so IDEs can help by providing autocomplete. I added these constants for the YamlEncoder where they are missing right now. For reference see other encoders like CsvEncoder or XmlEncoder.

Commits
-------

6ebf7e164e Adds constants for YamlEncoder options

2 months agobug #39038 [DoctrineBridge] also reset id readers (xabbuh)
Fabien Potencier [Mon, 9 Nov 2020 10:48:59 +0000 (11:48 +0100)]
bug #39038 [DoctrineBridge]    also reset id readers (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge]    also reset id readers

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38890
| License       | MIT
| Doc PR        |

Commits
-------

784bd0080d also reset id readers

2 months agoalso reset id readers
Christian Flothmann [Mon, 9 Nov 2020 08:59:19 +0000 (09:59 +0100)]
also reset id readers

2 months agoAdds constants for YamlEncoder options
Denis Brumann [Sat, 7 Nov 2020 18:44:24 +0000 (19:44 +0100)]
Adds constants for YamlEncoder options

2 months agofeature #39032 [Validator] Allow load mappings from attributes without doctrine/annot...
Fabien Potencier [Sun, 8 Nov 2020 08:40:34 +0000 (09:40 +0100)]
feature #39032 [Validator] Allow load mappings from attributes without doctrine/annotations (derrabus)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Validator] Allow load mappings from attributes without doctrine/annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | #38096
| License       | MIT
| Doc PR        | TODO

Follows #38309.

Currently, we cannot enable constraint mapping from attributes without having `doctrine/annotations` installed. Lifting that limitation is a bit tricky because `ValidatorBuilder::enableAnnotationMapping()` creates an annotation reader if you don't pass one. This PR aims at deprecating this behavior.

I know it's a bit late for such a change in 5.2 and I should have seen earlier that this part was missing. 😓 Since I don't expect people to go all-in on attributes on day one, it's probably okay to postpone this change to 5.3.

Commits
-------

441c80603e [Validator] Allow load mappings from attributes without doctrine/annotations.

2 months ago[Validator] Allow load mappings from attributes without doctrine/annotations.
Alexander M. Turek [Sat, 7 Nov 2020 19:15:36 +0000 (20:15 +0100)]
[Validator] Allow load mappings from attributes without doctrine/annotations.

2 months agoFix LDAP pagination
Jérémy Derussé [Sat, 7 Nov 2020 20:18:28 +0000 (21:18 +0100)]
Fix LDAP pagination

2 months agofeature #39022 [FrameworkBundle] Allow to use attribute-based configuration of routi...
Alexander M. Turek [Sat, 7 Nov 2020 19:25:59 +0000 (20:25 +0100)]
feature #39022  [FrameworkBundle] Allow to use attribute-based configuration of routing/serializer without doctrine/annotations (derrabus)

This PR was merged into the 5.2-dev branch.

Discussion
----------

 [FrameworkBundle] Allow to use attribute-based configuration of routing/serializer without doctrine/annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Follows #37474, #38525

Currently, we need `doctrine/annotations` to be installed in order to configure routing and serializer via PHP attributes. Given that for both components we can already replace Doctrine Annotations completely, I'd like to get rid of that limitation.

Commits
-------

e5492e2e55 [FrameworkBundle] Configure PHP Attributes without doctrine/annotations.

2 months agobug #39002 [Validator] Override the default option of the choice constraint (benji07)
Maxime Steinhausser [Sat, 7 Nov 2020 16:47:31 +0000 (17:47 +0100)]
bug #39002 [Validator] Override the default option of the choice constraint (benji07)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Validator] Override the default option of the choice constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | TODO

We have a bundle that run test against the last version of symfony and we detect BC Break when passing a string as the first argument of the class Choice

Our code extends the Choice class and change the defaultOption.

I saw that others constraints class had new construct signature (for php8 attributes), but only some of them kept the array options as their first arguments. Why ?

ping @ogizanagi @derrabus

https://travis-ci.com/github/Elao/PhpEnums/jobs/410045368
```
1) Elao\Enum\Tests\Unit\Bridge\Symfony\Validator\Constraint\EnumTest::testDefaultValueIsEnumClass
Symfony\Component\Validator\Exception\MissingOptionsException: The options "class" must be set for constraint "Elao\Enum\Bridge\Symfony\Validator\Constraint\Enum".
/home/travis/build/Elao/PhpEnums/vendor/symfony/symfony/src/Symfony/Component/Validator/Constraint.php:171
/home/travis/build/Elao/PhpEnums/vendor/symfony/symfony/src/Symfony/Component/Validator/Constraint.php:110
/home/travis/build/Elao/PhpEnums/vendor/symfony/symfony/src/Symfony/Component/Validator/Constraints/Choice.php:75
/home/travis/build/Elao/PhpEnums/src/Bridge/Symfony/Validator/Constraint/Enum.php:39
/home/travis/build/Elao/PhpEnums/tests/Unit/Bridge/Symfony/Validator/Constraint/EnumTest.php:22
```

Commits
-------

d553750054 Allow user to override default options when extending the Choice Constraint

2 months agoMerge branch '5.1' into 5.x
Robin Chalas [Sat, 7 Nov 2020 16:24:48 +0000 (17:24 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  [Messenger] Fix DBAL deprecations in PostgreSQLConnection
  [DoctrineBridge] Fix DBAL deprecations in middlewares.

2 months agoMerge branch '4.4' into 5.1
Robin Chalas [Sat, 7 Nov 2020 16:24:27 +0000 (17:24 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  [DoctrineBridge] Fix DBAL deprecations in middlewares.

2 months agobug #39026 [Messenger] Fix DBAL deprecations in PostgreSqlConnection (chalasr)
Robin Chalas [Sat, 7 Nov 2020 16:22:16 +0000 (17:22 +0100)]
bug #39026 [Messenger] Fix DBAL deprecations in PostgreSqlConnection (chalasr)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] Fix DBAL deprecations in PostgreSqlConnection

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

bc42cf604e [Messenger] Fix DBAL deprecations in PostgreSQLConnection

2 months agoAllow user to override default options when extending the Choice Constraint
Benjamin Lévêque [Thu, 5 Nov 2020 14:26:06 +0000 (15:26 +0100)]
Allow user to override default options when extending the Choice Constraint

Co-authored-by: Maxime Steinhausser <maxime.steinhausser@gmail.com>
2 months agobug #39025 [DoctrineBridge] Fix DBAL deprecations in middlewares (derrabus)
Robin Chalas [Sat, 7 Nov 2020 14:51:28 +0000 (15:51 +0100)]
bug #39025 [DoctrineBridge] Fix DBAL deprecations in middlewares (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Fix DBAL deprecations in middlewares

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

969da48c98 [DoctrineBridge] Fix DBAL deprecations in middlewares.

2 months ago[Messenger] Fix DBAL deprecations in PostgreSQLConnection
Robin Chalas [Sat, 7 Nov 2020 14:33:20 +0000 (15:33 +0100)]
[Messenger] Fix DBAL deprecations in PostgreSQLConnection

2 months ago[DoctrineBridge] Fix DBAL deprecations in middlewares.
Alexander M. Turek [Sat, 7 Nov 2020 14:21:55 +0000 (15:21 +0100)]
[DoctrineBridge] Fix DBAL deprecations in middlewares.

2 months ago[FrameworkBundle] Configure PHP Attributes without doctrine/annotations.
Alexander M. Turek [Fri, 6 Nov 2020 01:06:52 +0000 (02:06 +0100)]
[FrameworkBundle] Configure PHP Attributes without doctrine/annotations.

2 months agoMerge branch '5.1' into 5.x
Alexander M. Turek [Sat, 7 Nov 2020 13:01:53 +0000 (14:01 +0100)]
Merge branch '5.1' into 5.x

2 months agoMerge branch '4.4' into 5.1
Alexander M. Turek [Sat, 7 Nov 2020 13:01:26 +0000 (14:01 +0100)]
Merge branch '4.4' into 5.1

2 months agominor #39017 [ProxyManagerBridge] replace ProxyManager\Version by feature detection...
Fabien Potencier [Fri, 6 Nov 2020 16:37:15 +0000 (17:37 +0100)]
minor #39017 [ProxyManagerBridge] replace ProxyManager\Version by feature detection (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[ProxyManagerBridge] replace ProxyManager\Version by feature detection

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I'd like to get rid of this `Version` class, which is the source of so many issues with deps.
This won't remove the class from ocramius/proxy-manager, but that's a separate story that this change could enable in the end :)

Commits
-------

5f77aad6ca [ProxyManagerBridge] replace ProxyManager\Version by feature detection

2 months ago[ProxyManagerBridge] replace ProxyManager\Version by feature detection
Nicolas Grekas [Fri, 6 Nov 2020 14:18:27 +0000 (15:18 +0100)]
[ProxyManagerBridge] replace ProxyManager\Version by feature detection

2 months agominor #39009 [CI] Fix invalid Doctrine parameter syntax (Nyholm)
Alexander M. Turek [Thu, 5 Nov 2020 21:19:20 +0000 (22:19 +0100)]
minor #39009 [CI] Fix invalid Doctrine parameter syntax (Nyholm)

This PR was merged into the 4.4 branch.

Discussion
----------

[CI] Fix invalid Doctrine parameter syntax

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39008
| License       | MIT
| Doc PR        | no

~~I cannot reproduce locally.. So Im trying to fix this with the help of the CI~~

I have reproduced locally. This fix will help.

```
❯ phpunit Tests/Transport/DoctrineIntegrationTest.php
PHPUnit 8.5.8 by Sebastian Bergmann and contributors.

.E....                                                              6 / 6 (100%)

Time: 111 ms, Memory: 6.00 MB

There was 1 error:

1) Symfony\Component\Messenger\Bridge\Doctrine\Tests\Transport\DoctrineIntegrationTest::testSendWithDelay
Doctrine\DBAL\SQLParserUtilsException: Value for :body not found in params array. Params array key should be "body"

src/Symfony/Component/Messenger/Bridge/Doctrine/vendor/doctrine/dbal/src/SQLParserUtilsException.php:21
src/Symfony/Component/Messenger/Bridge/Doctrine/vendor/doctrine/dbal/src/SQLParserUtils.php:277
src/Symfony/Component/Messenger/Bridge/Doctrine/vendor/doctrine/dbal/src/SQLParserUtils.php:203
src/Symfony/Component/Messenger/Bridge/Doctrine/vendor/doctrine/dbal/src/Connection.php:1019
src/Symfony/Component/Messenger/Bridge/Doctrine/vendor/doctrine/dbal/src/Query/QueryBuilder.php:210
src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/DoctrineIntegrationTest.php:66

ERRORS!
Tests: 6, Assertions: 8, Errors: 1.
```

Apply patch:

```
❯ phpunit Tests/Transport/DoctrineIntegrationTest.php
PHPUnit 8.5.8 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 94 ms, Memory: 6.00 MB

OK (6 tests, 9 assertions)

```

Commits
-------

0ab3032c52 [CI] Fixed invalid doctrine parameter syntax

2 months ago[CI] Fixed invalid doctrine parameter syntax
Nyholm [Thu, 5 Nov 2020 20:54:48 +0000 (21:54 +0100)]
[CI] Fixed invalid doctrine parameter syntax

2 months agofix merge
Robin Chalas [Thu, 5 Nov 2020 20:41:09 +0000 (21:41 +0100)]
fix merge

2 months agoMerge branch '5.1' into 5.x
Alexander M. Turek [Thu, 5 Nov 2020 20:05:54 +0000 (21:05 +0100)]
Merge branch '5.1' into 5.x

2 months agoMerge branch '4.4' into 5.1
Alexander M. Turek [Thu, 5 Nov 2020 19:04:46 +0000 (20:04 +0100)]
Merge branch '4.4' into 5.1

2 months agobug #38991 [Console] Fix ANSI when stdErr is not a tty (jderusse)
Robin Chalas [Thu, 5 Nov 2020 15:22:05 +0000 (16:22 +0100)]
bug #38991 [Console] Fix ANSI when stdErr is not a tty (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Fix ANSI when stdErr is not a tty

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38981
| License       | MIT
| Doc PR        | -

Taking the @wouterj 's comment into account (https://github.com/symfony/symfony/issues/38981#issuecomment-721915428)

This PR prevents using the same Formatter for stdOut and stdErr when possible.

When user send a custom formatter (or call `setFormatter`) the previous logic is kept.
Otherwise, symfony is asked to create the Formatter, and thus is able to clone the formatter.

In a future PR targeting 5.3, we could improve the constructor to let people inject 2 distinguished formatters

Commits
-------

f3a398b5af Fix ANSI when stdErr is not a tty

2 months agobug #38980 [DependencyInjection] Fix circular reference with Factory + Lazy Iterrator...
Nicolas Grekas [Thu, 5 Nov 2020 11:51:33 +0000 (12:51 +0100)]
bug #38980 [DependencyInjection] Fix circular reference with Factory + Lazy Iterrator (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Fix circular reference with Factory + Lazy Iterrator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38970
| License       | MIT
| Doc PR        | -

The issue, occurs when a `factory` iterates over services (think tagged iterator) that also need the `factory`.
The PhpDumper is not able to detect the loop because the TaggedService iterator is flaged as "lazy" which is ignored in the loop detection. https://github.com/symfony/symfony/blob/2d7e0b02c6dd8d652fe3732d0dd29f24bda1bddc/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php#L474-L476

See test case for a reproduce case.

This PR takes into account lazy services when computing loops.

I'm not sure this is the right thing to do /cc @nicolas-grekas .
A better solution could be to do this ONLY when the service is used as a factory?

Commits
-------

51ff060603 Fix circular referene with Factory and LazyIterator

2 months agoFix ANSI when stdErr is not a tty
Jérémy Derussé [Wed, 4 Nov 2020 20:14:54 +0000 (21:14 +0100)]
Fix ANSI when stdErr is not a tty

2 months agobug #38986 [DoctrineBridge] accept converting Uid-as-strings to db-values (nicolas...
Fabien Potencier [Thu, 5 Nov 2020 08:48:15 +0000 (09:48 +0100)]
bug #38986 [DoctrineBridge] accept converting Uid-as-strings to db-values (nicolas-grekas)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[DoctrineBridge] accept converting Uid-as-strings to db-values

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38929
| License       | MIT
| Doc PR        | -

In #38605 I made Uid types stricter by taking inspiration from native Doctrine types. But https://github.com/symfony/symfony/issues/38929#issuecomment-720108301 made me realize this doesn't work with ParamConverters. Here is the fix.

Commits
-------

20714d66c9 [DoctrineBridge] accept converting Uid-as-strings to db-values

2 months agominor #38995 [Security] Fix docblock (derrabus)
Nyholm [Thu, 5 Nov 2020 08:37:17 +0000 (09:37 +0100)]
minor #38995 [Security] Fix docblock (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Fix docblock

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

60e506835a [Security] Fix docblock.

2 months ago[Security] Fix docblock.
Alexander M. Turek [Wed, 4 Nov 2020 23:24:50 +0000 (00:24 +0100)]
[Security] Fix docblock.

2 months agoFix circular referene with Factory and LazyIterator
Jérémy Derussé [Wed, 4 Nov 2020 02:07:25 +0000 (03:07 +0100)]
Fix circular referene with Factory and LazyIterator

2 months ago[DoctrineBridge] accept converting Uid-as-strings to db-values
Nicolas Grekas [Wed, 4 Nov 2020 11:11:20 +0000 (12:11 +0100)]
[DoctrineBridge] accept converting Uid-as-strings to db-values

2 months agofeature #38850 [Messenger] Do not call getQueueUrl when the url is known in AmazonSqs...
Fabien Potencier [Wed, 4 Nov 2020 07:24:27 +0000 (08:24 +0100)]
feature #38850 [Messenger] Do not call getQueueUrl when the url is known in AmazonSqs transport (jderusse)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Messenger] Do not call getQueueUrl when the url is known in AmazonSqs transport

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #38849
| License       | MIT
| Doc PR        | TODO

When user provides a DSN that looks like a queueUrl, we don't need to call the `getQueueUrl` method. This PR inject the known queueUrl and prevent performing a useless call to the API when sending a message

Commits
-------

f1f44d48e0 Do not call getQueueUrl when the url is known

2 months agofeature #38940 [Messenger] Improve formatting of exception in failed message (Jeroen...
Fabien Potencier [Wed, 4 Nov 2020 07:21:06 +0000 (08:21 +0100)]
feature #38940 [Messenger] Improve formatting of exception in failed message (Jeroen Noten)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Messenger] Improve formatting of exception in failed message

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | not really, enhancement of an existing feature
| Deprecations? | no
| Tickets       | Fix #32310
| License       | MIT

This PR improves the formatting of exception details in failed messenges when displayed using `messenger:failed:show <id> -vv`.

Before:
<img width="807" alt="Screen Shot 2020-11-01 at 1 05 24 PM" src="https://user-images.githubusercontent.com/4370753/97802602-ea593200-1c44-11eb-8bcb-7fcf2d3f1db0.png">

After:
<img width="803" alt="Screen Shot 2020-11-01 at 1 03 09 PM" src="https://user-images.githubusercontent.com/4370753/97802615-f0e7a980-1c44-11eb-8c12-46b2d4510364.png">

I created a `ThrownExceptionDetails` class which will be displayed as a normal exception when dumped with the VarDumper component. Not sure if this is the right way to do it and if the class is in the right namespace, but this is the best solution I could came up with to fix #32310. I'm open for other suggestions.

Commits
-------

2ad1adda69 [Messenger] Improve formatting of thrown exception in show failed message command

2 months agofeature #38954 [HttpFundation][FrameworkBundle] Deprecate the HEADER_X_FORWARDED_ALL...
Fabien Potencier [Wed, 4 Nov 2020 07:16:55 +0000 (08:16 +0100)]
feature #38954 [HttpFundation][FrameworkBundle] Deprecate the HEADER_X_FORWARDED_ALL constant (jderusse)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[HttpFundation][FrameworkBundle] Deprecate the HEADER_X_FORWARDED_ALL constant

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | TODO

The `HEADER_X_FORWARDED_ALL` implicitly trust the `x-forwarded-host` header, leading to possible host header attack (as warned in the [documentation](https://symfony.com/doc/current/reference/configuration/framework.html#trusted-hosts).)

Moreover, this `HEADER_X_FORWARDED_ALL` does not really fowards **all** headers, as ti does not supports `X-Forwarded-Prefix` headers.

This PR deprecate the constant and the new framework bundle configuration. It will be removed in 6.0. People have to use: either:
- `Request::setTrustedProxies(['1.2.3.4'], Request::HEADER_X_FORWARDED_FOR | Request::HEADER_X_FORWARDED_HOST | Request::HEADER_X_FORWARDED_PORT | Request::HEADER_X_FORWARDED_PROTO);`
- `Request::setTrustedProxies(['1.2.3.4'], Request::HEADER_X_FORWARDED_TRAEFIK);`
- `framework.trusted_headers: [x-forwarded-for, x-forwarded-host, x-forwarded-port, x-forwarded-proto]`

Commits
-------

7cf4dd6917 Deprecate HEADER_X_FORWARDED_ALL constant

2 months agobug #38977 [HttpClient] Check status code before decoding content in TraceableRespons...
Nicolas Grekas [Tue, 3 Nov 2020 20:22:18 +0000 (21:22 +0100)]
bug #38977 [HttpClient] Check status code before decoding content in TraceableResponse (chalasr)

This PR was merged into the 5.1 branch.

Discussion
----------

[HttpClient] Check status code before decoding content in TraceableResponse

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | np
| Tickets       | -
| License       | MIT
| Doc PR        | -

Using `toArray()` on the response of a traceable client, the status code is currently checked after json decoding, which leads to `JsonException` being thrown instead of `ClientException`.
It should be the opposite, as for non-traceable responses.

Commits
-------

e5595dae73 [HttpClient] Check status code before decoding content in TraceableResponse

2 months ago[HttpClient] Check status code before decoding content in TraceableResponse
Robin Chalas [Tue, 3 Nov 2020 16:55:17 +0000 (17:55 +0100)]
[HttpClient] Check status code before decoding content in TraceableResponse

2 months agominor #38978 Rename security.pt_PT.xlf to security.pt.xlf (raziel057)
Alexander M. Turek [Tue, 3 Nov 2020 19:16:45 +0000 (20:16 +0100)]
minor #38978 Rename security.pt_PT.xlf to security.pt.xlf (raziel057)

This PR was merged into the 4.4 branch.

Discussion
----------

Rename security.pt_PT.xlf to security.pt.xlf

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38774
| License       | MIT

Missing translations for Portuguese (pt).

As agreed in https://github.com/symfony/symfony/issues/38739#issuecomment-721210579 the common Portuguese translation file for security domain should be ``security.pt.xlf`` rather than ``security.pt_PT.xlf``

Commits
-------

3dd385f319 Rename security.pt_PT.xlf to security.pt.xlf

2 months agoRename security.pt_PT.xlf to security.pt.xlf
Thomas Lallement [Tue, 3 Nov 2020 16:58:31 +0000 (17:58 +0100)]
Rename security.pt_PT.xlf to security.pt.xlf

2 months ago[Messenger] Improve formatting of thrown exception in show failed message command
Jeroen Noten [Sun, 1 Nov 2020 10:11:50 +0000 (11:11 +0100)]
[Messenger] Improve formatting of thrown exception in show failed message command

2 months agoMerge branch '5.1' into 5.x
Nicolas Grekas [Tue, 3 Nov 2020 12:14:28 +0000 (13:14 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  fix typo

2 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Tue, 3 Nov 2020 12:14:22 +0000 (13:14 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  fix typo

2 months agofix typo
Nicolas Grekas [Tue, 3 Nov 2020 12:14:11 +0000 (13:14 +0100)]
fix typo

2 months agoMerge branch '5.1' into 5.x
Nicolas Grekas [Tue, 3 Nov 2020 11:59:38 +0000 (12:59 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  [PhpUnitBridge] fix replaying skipped tests
  Switch nightly run to 8.0snapshot

2 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Tue, 3 Nov 2020 11:59:17 +0000 (12:59 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  [PhpUnitBridge] fix replaying skipped tests
  Switch nightly run to 8.0snapshot

2 months agobug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)
Nicolas Grekas [Tue, 3 Nov 2020 11:57:46 +0000 (12:57 +0100)]
bug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix replaying skipped tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while working on https://github.com/symfony/polyfill/pull/310

See also https://3v4l.org/D6Gro for the newly skipped tests in symfony/intl

Commits
-------

849d1b3845 [PhpUnitBridge] fix replaying skipped tests

2 months ago[PhpUnitBridge] fix replaying skipped tests
Nicolas Grekas [Tue, 3 Nov 2020 11:50:26 +0000 (12:50 +0100)]
[PhpUnitBridge] fix replaying skipped tests

2 months agominor #38967 Switch nightly run to 8.0snapshot (derrabus)
Fabien Potencier [Tue, 3 Nov 2020 06:19:11 +0000 (07:19 +0100)]
minor #38967 Switch nightly run to 8.0snapshot (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

Switch nightly run to 8.0snapshot

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

It's too early to test on php 8.1, so let's switch to 8.0 instead.

Commits
-------

b4730cbe1d Switch nightly run to 8.0snapshot

2 months agominor #38941 [FrameworkBundle] Register AddErrorDetailsStampListener from the Messeng...
Jérémy Derussé [Tue, 3 Nov 2020 00:02:05 +0000 (01:02 +0100)]
minor #38941 [FrameworkBundle] Register AddErrorDetailsStampListener from the Messenger component as event subscriber (Jeroen Noten)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[FrameworkBundle] Register AddErrorDetailsStampListener from the Messenger component as event subscriber

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

This is a fix for a bug in version 5.2-BETA3.

In #32904, adding the error details to a failed message in the Messenger component was moved to a separate listener. However, this listener is not registered in the FrameworkBundle, resulting in no error details stored at all (when using the Symfony skeleton). This PR adds that missing registration.

Commits
-------

deda2ac411 [FrameworkBundle] Register AddErrorDetailsStampListener from the Messenger component as event subscriber

2 months agominor #38842 [Notifier] Add unit tests for NullMessage, NullTransport and NullTranspo...
Jérémy Derussé [Mon, 2 Nov 2020 23:56:53 +0000 (00:56 +0100)]
minor #38842 [Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory (jschaedl)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
-->

Commits
-------

8a78dc2c97 [Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory

2 months ago[Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory
Jan Schädlich [Tue, 27 Oct 2020 12:28:18 +0000 (13:28 +0100)]
[Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory

2 months agoSwitch nightly run to 8.0snapshot
Alexander M. Turek [Mon, 2 Nov 2020 21:14:26 +0000 (22:14 +0100)]
Switch nightly run to 8.0snapshot

2 months agoDeprecate HEADER_X_FORWARDED_ALL constant
Jérémy Derussé [Sun, 1 Nov 2020 21:31:33 +0000 (22:31 +0100)]
Deprecate HEADER_X_FORWARDED_ALL constant

2 months agoMerge branch '5.1' into 5.x
Nicolas Grekas [Mon, 2 Nov 2020 16:09:19 +0000 (17:09 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  [HttpKernel] fix merge

2 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Mon, 2 Nov 2020 16:09:08 +0000 (17:09 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  [HttpKernel] fix merge

2 months ago[HttpKernel] fix merge
Nicolas Grekas [Mon, 2 Nov 2020 16:05:56 +0000 (17:05 +0100)]
[HttpKernel] fix merge

2 months agoMerge branch '5.1' into 5.x
Nicolas Grekas [Mon, 2 Nov 2020 15:46:10 +0000 (16:46 +0100)]
Merge branch '5.1' into 5.x

* 5.1:
  [Process] Dont test TTY if there is no TTY support
  Fixing some Mongolian
  translating the validators for european portuguese language
  Fix CI
  Update validators.he.xlf
  Update security.he.xlf
  Update validators.he.xlf
  Improve performances in CircualReference detection
  [PHPUnitBridge] Fixed crash on Windows with PHP 8
  Fix session called initized several time

2 months agoMerge branch '4.4' into 5.1
Nicolas Grekas [Mon, 2 Nov 2020 15:45:32 +0000 (16:45 +0100)]
Merge branch '4.4' into 5.1

* 4.4:
  [Process] Dont test TTY if there is no TTY support
  Fixing some Mongolian
  translating the validators for european portuguese language
  Fix CI
  Update validators.he.xlf
  Update security.he.xlf
  Update validators.he.xlf
  Improve performances in CircualReference detection
  [PHPUnitBridge] Fixed crash on Windows with PHP 8
  Fix session called initized several time

2 months agobug #38910 [HttpKernel] Fix session initialized several times (jderusse)
Nicolas Grekas [Mon, 2 Nov 2020 15:36:10 +0000 (16:36 +0100)]
bug #38910 [HttpKernel] Fix session initialized several times (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Fix session initialized several times

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The session injected in the request is a factory. When the request is **cloned** (ie sub-request) while the session is not yet used in the master request (the session is still a factory), both Master and Sub request will have a factory.
If both requests attempt to read the session afterward, they both triggers the factory, and both initialize the session.

It's not a dead end for the `SessionListener` because the session come from the container and is shared, but:
- the session is initialized ($storage->setOptions(['cookie_secure' => true])) twice
- if we replace the sesssion from container to a factory, it could be an issue

Commits
-------

30a3c7c87b Fix session called initized several time

2 months agobug #38882 [DependencyInjection] Improve performances in CircualReference detection...
Nicolas Grekas [Mon, 2 Nov 2020 15:10:49 +0000 (16:10 +0100)]
bug #38882 [DependencyInjection] Improve performances in CircualReference detection (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Improve performances in CircualReference detection

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37850
| License       | MIT
| Doc PR        | -

This PR change the way circular references are detected.  And improve the project submitted in #37850 [by **86%**](https://blackfire.io/profiles/compare/cc4aa41d-5b63-4caa-9a1b-fc282dc5d64a/graph) (Build the container in 1.1 sec instead of 10)

Issue is: When a project contains a lot Circular Reference, the Dumper [spend a lot of time](https://blackfire.io/profiles/54f6eba2-b93c-4f2b-a268-1e58883faecb/graph) in merging those circular references.
note: a circular reference is not an issue when an service is not injected by constructor, but this Can not be known until all references are resolved (performed previously by connectCircularReferences)

This PR removed the connectCircularReferences and generate a flatten tree of dependencies:
 - the key is the service ID
 - the value is the list of direct **AND** indirect dependency + path to join the dependency

I also [benched the PR with a project with few references](https://blackfire.io/profiles/compare/2f9902e6-3347-40b3-8421-e1fd09c067d2/graph) and result are almost the same before/after.

Commits
-------

d4db75692b Improve performances in CircualReference detection

2 months agobug #38950 [Process] Dont test TTY if there is no TTY support (Nyholm)
Nicolas Grekas [Mon, 2 Nov 2020 15:10:23 +0000 (16:10 +0100)]
bug #38950 [Process] Dont test TTY if there is no TTY support (Nyholm)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Process] Dont test TTY if there is no TTY support

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38946
| License       | MIT
| Doc PR        |

Commits
-------

e918e5ab30 [Process] Dont test TTY if there is no TTY support

2 months ago[Process] Dont test TTY if there is no TTY support
Nyholm [Sun, 1 Nov 2020 19:26:06 +0000 (20:26 +0100)]
[Process] Dont test TTY if there is no TTY support

2 months agobug #38921 [PHPUnitBridge] Fixed crash on Windows with PHP 8 (villfa)
Nicolas Grekas [Mon, 2 Nov 2020 15:07:32 +0000 (16:07 +0100)]
bug #38921 [PHPUnitBridge] Fixed crash on Windows with PHP 8 (villfa)

This PR was merged into the 4.4 branch.

Discussion
----------

[PHPUnitBridge] Fixed crash on Windows with PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

The install command crashed with the message "The filename, directory name, or volume label syntax is incorrect.".
It happens only on Windows with PHP 8.

Probably due to https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L1121-L1123

I have a small repo to show the problem and how it is fixed: https://github.com/villfa/test-phpunit-bridge

Commits
-------

4b958917fd [PHPUnitBridge] Fixed crash on Windows with PHP 8

2 months agominor #38917 Fixing some Mongolian (Nyholm)
Nicolas Grekas [Mon, 2 Nov 2020 15:02:38 +0000 (16:02 +0100)]
minor #38917 Fixing some Mongolian (Nyholm)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Fixing some Mongolian

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38916
| License       | MIT
| Doc PR        |

Hey @luffy1727, could you help me with the last two strings here?

Commits
-------

5c848d9796 Fixing some Mongolian

2 months agoFixing some Mongolian
Nyholm [Sat, 31 Oct 2020 09:16:35 +0000 (10:16 +0100)]
Fixing some Mongolian

2 months agominor #38930 translating the validators for european portuguese language (brunosinister)
Nicolas Grekas [Mon, 2 Nov 2020 15:00:34 +0000 (16:00 +0100)]
minor #38930 translating the validators for european portuguese language (brunosinister)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

translating the validators for european portuguese language

| Q             | A
| ------------- | ---
| Branch?       | 5.x for features / 4.4 or 5.1 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
-->

Commits
-------

c0524197a0 translating the validators for european portuguese language

2 months agotranslating the validators for european portuguese language
Bruno Araujo [Mon, 26 Oct 2020 22:51:58 +0000 (22:51 +0000)]
translating the validators for european portuguese language

2 months agominor #38963 Update validators.he.xlf (ben29)
Nicolas Grekas [Mon, 2 Nov 2020 14:37:14 +0000 (15:37 +0100)]
minor #38963 Update validators.he.xlf (ben29)

This PR was merged into the 4.4 branch.

Discussion
----------

Update validators.he.xlf

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38744
| License       | MIT
| Doc PR        |

Commits
-------

b99977efce Update validators.he.xlf

2 months agoMerge branch '3.4' into 4.4
Nicolas Grekas [Mon, 2 Nov 2020 14:31:22 +0000 (15:31 +0100)]
Merge branch '3.4' into 4.4

* 3.4:
  Fix CI

2 months agoFix CI
Nicolas Grekas [Mon, 2 Nov 2020 14:30:42 +0000 (15:30 +0100)]
Fix CI

2 months agoUpdate validators.he.xlf
Ben Hakim [Mon, 2 Nov 2020 14:11:24 +0000 (16:11 +0200)]
Update validators.he.xlf

2 months agominor #38961 Update validators.he.xlf (ben29)
Alexander M. Turek [Mon, 2 Nov 2020 14:00:41 +0000 (15:00 +0100)]
minor #38961 Update validators.he.xlf (ben29)

This PR was merged into the 4.4 branch.

Discussion
----------

Update validators.he.xlf

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38744
| License       | MIT
| Doc PR        |

Commits
-------

98a7e8e150 Update validators.he.xlf

2 months agominor #38962 Update security.he.xlf (ben29)
Alexander M. Turek [Mon, 2 Nov 2020 13:59:36 +0000 (14:59 +0100)]
minor #38962 Update security.he.xlf (ben29)

This PR was merged into the 4.4 branch.

Discussion
----------

Update security.he.xlf

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38744
| License       | MIT
| Doc PR        |

Commits
-------

c8ab10f427 Update security.he.xlf

2 months agoUpdate security.he.xlf
Ben Hakim [Mon, 2 Nov 2020 13:41:03 +0000 (15:41 +0200)]
Update security.he.xlf

2 months agoUpdate validators.he.xlf
Ben Hakim [Mon, 2 Nov 2020 13:36:19 +0000 (15:36 +0200)]
Update validators.he.xlf

2 months agoMerge branch '5.1' into 5.x
Alexander M. Turek [Mon, 2 Nov 2020 08:16:52 +0000 (09:16 +0100)]
Merge branch '5.1' into 5.x

2 months agoMerge branch '4.4' into 5.1
Alexander M. Turek [Mon, 2 Nov 2020 07:55:38 +0000 (08:55 +0100)]
Merge branch '4.4' into 5.1

2 months agominor #38932 [Validator] Merge RecursiveValidatorTest with its parents (derrabus)
Fabien Potencier [Mon, 2 Nov 2020 06:49:36 +0000 (07:49 +0100)]
minor #38932 [Validator] Merge RecursiveValidatorTest with its parents (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Merge RecursiveValidatorTest with its parents

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

`RecursiveValidatorTest` as two abstract parent classes that to my understanding exist mainly for historic reasons: We used to have different validator implementations and those abstract classes contained some shared test cases. This is not the case anymore, which leaves `RecursiveValidatorTest` as the only child class of those two abstract classes.

This PR suggests to merge the three classes into one.

I've executed the test suite before and after the change and PHPUnit reported the same number of assertions and test cases.

I've also checked how the merge to 5.1 and 5.x would look like. The merge to 5.1 works without conflicts. From 5.1 to 5.x, two additional test cases have to be moved down and the reference to a few fixture classes needs to be adjusted.

Commits
-------

6822774d37 [Validator] Merge RecursiveValidatorTest with its parents.

2 months agominor #38945 [Finder] Force set access time in test (Nyholm)
Fabien Potencier [Mon, 2 Nov 2020 06:48:36 +0000 (07:48 +0100)]
minor #38945 [Finder] Force set access time in test (Nyholm)

This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] Force set access time in test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no, it only updates the tests
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38942
| License       | MIT
| Doc PR        |

OSX don't really update atime (access time). They claim it is because performance reasons. So this PR will update the test to make PHP force access time on a file.

The different runs of `testAccept` depends on each other because each test modifies the filesystem a bit. That is why I added the extra `sleep(1)`.

Commits
-------

c5ec51abdf [Finder] Force set access time in test

2 months agominor #38911 Fix transiant tests in 4.4 (jderusse)
Fabien Potencier [Mon, 2 Nov 2020 06:46:39 +0000 (07:46 +0100)]
minor #38911 Fix transiant tests in 4.4 (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

Fix transiant tests in 4.4

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I noticed this week 2 currencies of this failure. in both case the `METADATA_EXPIRY` were 1.5 sec under the expected value

Commits
-------

833029ca7e Fix transiant tests in 4.4